Changeset 140628 in webkit

Timestamp:

Jan 23, 2013 6:17:24 PM (11 years ago)

Author:

tonyg@chromium.org

Message:

Teach threaded HTML parser to update InspectorInstrumentation when writing HTML
​https://bugs.webkit.org/show_bug.cgi?id=107755

Reviewed by Eric Seidel.

The current length is unused, so it doesn't cause any noticeable behavior difference to not pass it here.

No new tests because covered by existing tests.

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processTokensFromBackgroundParser):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/HTMLDocumentParser.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-23  Tony Gentilcore  <tonyg@chromium.org>
+
+        Teach threaded HTML parser to update InspectorInstrumentation when writing HTML
+        https://bugs.webkit.org/show_bug.cgi?id=107755
+
+        Reviewed by Eric Seidel.
+
+        The current length is unused, so it doesn't cause any noticeable behavior difference to not pass it here.
+
+        No new tests because covered by existing tests.
+
+        * html/parser/HTMLDocumentParser.cpp:
+        (WebCore::HTMLDocumentParser::processTokensFromBackgroundParser):
+
 2013-01-23  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp

@@ -291 +291 @@
     RefPtr<HTMLDocumentParser> protect(this);
 
-    // FIXME: Add support for InspectorInstrumentation.
+    // FIXME: Pass in current input length.
+    InspectorInstrumentationCookie cookie = InspectorInstrumentation::willWriteHTML(document(), 0, lineNumber().zeroBasedInt());
 
     for (Vector<CompactHTMLToken>::const_iterator it = tokens->begin(); it != tokens->end(); ++it) {
@@ -301 +302 @@
 
         if (isStopped())
-            return;
+            break;
 
         // FIXME: We'll probably need to check document()->frame()->navigationScheduler()->locationChangePending())
@@ -309 +310 @@
             ASSERT(it + 1 == tokens->end()); // The </script> is assumed to be the last token of this bunch.
             runScriptsForPausedTreeBuilder();
-            return;
+            break;
         }
 
@@ -315 +316 @@
             ASSERT(it + 1 == tokens->end()); // The EOF is assumed to be the last token of this bunch.
             prepareToStopParsing();
-            return;
+            break;
         }
     }
+
+    InspectorInstrumentation::didWriteHTML(cookie, lineNumber().zeroBasedInt());
 }