Changeset 140685 in webkit

Timestamp:

Jan 24, 2013 8:16:42 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GStreamer] Implement setPreservesPitch()
​https://bugs.webkit.org/show_bug.cgi?id=31155

Enables audio pitch preservation by using the scaletempo GStreamer
element when required by the MediaPlayer.

Patch by Victor Jaquez <​vjaquez@igalia.com> on 2013-01-24
Reviewed by Philippe Normand.

No new tests, but a layout test shall be implemented at some point
using WebAudio API.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setPreservesPitch):
(WebCore):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (5 diffs)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-24  Victor Jaquez  <vjaquez@igalia.com>
+
+        [GStreamer] Implement setPreservesPitch()
+        https://bugs.webkit.org/show_bug.cgi?id=31155
+
+        Enables audio pitch preservation by using the scaletempo GStreamer
+        element when required by the MediaPlayer.
+
+        Reviewed by Philippe Normand.
+
+        No new tests, but a layout test shall be implemented at some point
+        using WebAudio API.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::setPreservesPitch):
+        (WebCore):
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
+        (MediaPlayerPrivateGStreamer):
+
 2013-01-24  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -251 +251 @@
     , m_totalBytes(-1)
     , m_originalPreloadWasAutoAndWasOverridden(false)
+    , m_preservesPitch(false)
 {
 }
@@ -739 +740 @@
     else
         g_object_set(m_playBin.get(), "mute", mute, NULL);
+}
+
+void MediaPlayerPrivateGStreamer::setPreservesPitch(bool preservesPitch)
+{
+    m_preservesPitch = preservesPitch;
 }
 
@@ -1796 +1802 @@
 }
 
+void MediaPlayerPrivateGStreamer::createAudioSink()
+{
+    // Construct audio sink if pitch preserving is enabled.
+    if (!m_preservesPitch)
+        return;
+
+    if (!m_playBin)
+        return;
+
+    GstElement* scale = gst_element_factory_make("scaletempo", 0);
+    if (!scale) {
+        GST_WARNING("Failed to create scaletempo");
+        return;
+    }
+
+    GstElement* convert = gst_element_factory_make("audioconvert", 0);
+    GstElement* resample = gst_element_factory_make("audioresample", 0);
+    GstElement* sink = gst_element_factory_make("autoaudiosink", 0);
+
+    GstElement* audioSink = gst_bin_new("audio-sink");
+    gst_bin_add_many(GST_BIN(audioSink), scale, convert, resample, sink, NULL);
+
+    if (!gst_element_link_many(scale, convert, resample, sink, NULL)) {
+        GST_WARNING("Failed to link audio sink elements");
+        gst_object_unref(audioSink);
+        return;
+    }
+
+    GRefPtr<GstPad> pad = adoptGRef(gst_element_get_static_pad(scale, "sink"));
+    gst_element_add_pad(audioSink, gst_ghost_pad_new("sink", pad.get()));
+
+    g_object_set(m_playBin.get(), "audio-sink", audioSink, NULL);
+}
+
 void MediaPlayerPrivateGStreamer::createGSTPlayBin()
 {
@@ -1831 +1871 @@
 
 #ifndef GST_API_VERSION_1
-    m_videoSinkBin = gst_bin_new("sink");
+    m_videoSinkBin = gst_bin_new("video-sink");
 
     GstElement* videoTee = gst_element_factory_make("tee", "videoTee");
@@ -1908 +1948 @@
         g_signal_connect(videoSinkPad.get(), "notify::caps", G_CALLBACK(mediaPlayerPrivateVideoSinkCapsChangedCallback), this);
 
+    createAudioSink();
 }
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

@@ -73 +73 @@
 
             void setRate(float);
+            void setPreservesPitch(bool);
 
             void setVolume(float);
@@ -138 +139 @@
 
             void updateAudioSink();
+            void createAudioSink();
 
             float playbackPosition() const;
@@ -206 +208 @@
             KURL m_url;
             bool m_originalPreloadWasAutoAndWasOverridden;
+            bool m_preservesPitch;
     };
 }