Changeset 140805 in webkit

Timestamp:

Jan 25, 2013 2:24:16 AM (11 years ago)

Author:

pfeldman@chromium.org

Message:

Web Inspector: inspector slows down pages with many anonymous scripts.
​https://bugs.webkit.org/show_bug.cgi?id=107928

Reviewed by Alexander Pavlov.

The problem was that workspace code introduced n^{2 complexity for unique URI calculation.}

• inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.prototype.uniqueURI):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/SimpleWorkspaceProvider.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-25  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: inspector slows down pages with many anonymous scripts.
+        https://bugs.webkit.org/show_bug.cgi?id=107928
+
+        Reviewed by Alexander Pavlov.
+
+        The problem was that workspace code introduced n^2 complexity for unique URI calculation.
+
+        * inspector/front-end/SimpleWorkspaceProvider.js:
+        (WebInspector.SimpleWorkspaceProvider):
+        (WebInspector.SimpleWorkspaceProvider.prototype.uniqueURI):
+
 2013-01-25  Jussi Kukkonen  <jussi.kukkonen@intel.com>
 

trunk/Source/WebCore/inspector/front-end/SimpleWorkspaceProvider.js

@@ -39 +39 @@
     /** @type {Object.<string, WebInspector.ContentProvider>} */
     this._contentProviders = {};
+    this._lastUniqueSuffix = 0;
 }
 
@@ -130 +131 @@
     {
         var uniqueURI = uri;
-        for (var i = 1; this._contentProviders[uniqueURI]; ++i)
-            uniqueURI = uri + " (" + i + ")";
+        while (this._contentProviders[uniqueURI])
+            uniqueURI = uri + " (" + (++this._lastUniqueSuffix) + ")";
         return uniqueURI;
     },