Changeset 140925 in webkit

Timestamp:

Jan 26, 2013 10:39:38 PM (11 years ago)

Author:

tony@chromium.org

Message:

[chromium] Don't use goma to preprocess bindings idl files
​https://bugs.webkit.org/show_bug.cgi?id=107984

Reviewed by Adam Barth.

On Linux and Mac, use a local gcc or clang to preprocess the bindings idl files.
On my machine, this drops the bindings generation from 137s to 24s when
using goma and -j400.

No new tests, this is a build change.

• WebCore.gyp/WebCore.gyp: Force the use of the local gcc or clang for preprocessing.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gyp/WebCore.gyp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-26  Tony Chang  <tony@chromium.org>
+
+        [chromium] Don't use goma to preprocess bindings idl files
+        https://bugs.webkit.org/show_bug.cgi?id=107984
+
+        Reviewed by Adam Barth.
+
+        On Linux and Mac, use a local gcc or clang to preprocess the bindings idl files.
+        On my machine, this drops the bindings generation from 137s to 24s when
+        using goma and -j400.
+
+        No new tests, this is a build change.
+
+        * WebCore.gyp/WebCore.gyp: Force the use of the local gcc or clang for preprocessing.
+
 2013-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

@@ -240 +240 @@
         'gperf_exe': 'gperf',
         'bison_exe': 'bison',
-        # Without one specified, the scripts default to 'gcc'.
-        'preprocessor': '',
+
+        'conditions': [
+          # We specify a preprocess so it happens locally and won't get distributed to goma.
+          ['OS=="mac" or OS=="ios"', {
+            'preprocessor': '--preprocessor "/usr/bin/clang -E -P -x c++"'
+          },{
+            'preprocessor': '--preprocessor "/usr/bin/gcc -E -P -x c++"'
+          }]
+        ],
       }],
       ['use_x11==1 or OS=="android"', {