Changeset 141305 in webkit

Timestamp:

Jan 30, 2013 2:16:25 PM (11 years ago)

Author:

mhahnenberg@apple.com

Message:

Objective-C API: exceptionHandler needs to be released in JSContext dealloc
​https://bugs.webkit.org/show_bug.cgi?id=108378

Reviewed by Filip Pizlo.

JSContext has a (copy) exceptionHandler property that it doesn't release in dealloc.
That sounds like the potential for a leak. It should be released.

• API/JSContext.mm:

(-[JSContext dealloc]):

Location:

trunk/Source/JavaScriptCore

Files:

• API/JSContext.mm (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSContext.mm

@@ -164 +164 @@
     JSGlobalContextRelease(m_context);
     [m_virtualMachine release];
+    [self.exceptionHandler release];
     [super dealloc];
 }

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-01-30  Mark Hahnenberg  <mhahnenberg@apple.com>
+
+        Objective-C API: exceptionHandler needs to be released in JSContext dealloc
+        https://bugs.webkit.org/show_bug.cgi?id=108378
+
+        Reviewed by Filip Pizlo.
+
+        JSContext has a (copy) exceptionHandler property that it doesn't release in dealloc. 
+        That sounds like the potential for a leak. It should be released.
+
+        * API/JSContext.mm:
+        (-[JSContext dealloc]):
+
 2013-01-30  Filip Pizlo  <fpizlo@apple.com>