Changeset 141351 in webkit

Timestamp:

Jan 30, 2013 5:31:12 PM (11 years ago)

Author:

jsbell@chromium.org

Message:

IndexedDB: Remove speculative dispatchEvent crash fix now that root cause is addressed
​https://bugs.webkit.org/show_bug.cgi?id=108131

Reviewed by Tony Chang.

A patch was landed in r140027 to prevent a null pointer crash in
IDBRequest::dispatchEvent and confirm the source of the crash (which
we couldn't repro locally). Following confirmation from user reports,
the root cause was tracked down to a race condition in MessageQueue,
and was fixed in r140483. This patch is no longer needed, and there's
always been an ASSERT in place to catch regressions while debugging.

No new tests - no behavior change.

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent): Remove extraneous test.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/IDBRequest.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-30  Joshua Bell  <jsbell@chromium.org>
+
+        IndexedDB: Remove speculative dispatchEvent crash fix now that root cause is addressed
+        https://bugs.webkit.org/show_bug.cgi?id=108131
+
+        Reviewed by Tony Chang.
+
+        A patch was landed in r140027 to prevent a null pointer crash in
+        IDBRequest::dispatchEvent and confirm the source of the crash (which
+        we couldn't repro locally). Following confirmation from user reports,
+        the root cause was tracked down to a race condition in MessageQueue,
+        and was fixed in r140483. This patch is no longer needed, and there's
+        always been an ASSERT in place to catch regressions while debugging.
+
+        No new tests - no behavior change.
+
+        * Modules/indexeddb/IDBRequest.cpp:
+        (WebCore::IDBRequest::dispatchEvent): Remove extraneous test.
+
 2013-01-30  Joe Mason  <jmason@rim.com>
 

trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp

@@ -442 +442 @@
     ASSERT_WITH_MESSAGE(m_readyState < DONE, "When dispatching event %s, m_readyState < DONE(%d), was %d", event->type().string().utf8().data(), DONE, m_readyState);
 
-    // FIXME: This method should not be called if stop() was previously called,
-    // but there are crash reports (no local repro) indicating a null pointer
-    // deference in the following DOMRequestState::Scope constructor. If this
-    // resolves the crashes, track down the root cause, otherwise back this out.
-    if (m_contextStopped)
-        return false;
-
     DOMRequestState::Scope scope(m_requestState);