Changeset 141444 in webkit
- Timestamp:
- Jan 31, 2013 11:01:31 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 2 deleted
- 27 edited
- 1 copied
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/Platform/ChangeLog
r141356 r141444 1 2013-01-31 Tommy Widenflycht <tommyw@google.com> 2 3 [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack 4 https://bugs.webkit.org/show_bug.cgi?id=108458 5 6 Only renames, no other code changes. 7 8 Reviewed by Adam Barth. 9 10 * Platform.gypi: 11 * chromium/public/WebMediaStream.h: Copied from Source/Platform/chromium/public/WebMediaStreamDescriptor.h. 12 (WebCore): 13 (WebKit): 14 (WebMediaStream): 15 (ExtraData): 16 (WebKit::WebMediaStream::ExtraData::~ExtraData): 17 (WebKit::WebMediaStream::WebMediaStream): 18 (WebKit::WebMediaStream::~WebMediaStream): 19 (WebKit::WebMediaStream::operator=): 20 (WebKit::WebMediaStream::isNull): 21 * chromium/public/WebMediaStreamCenter.h: 22 (WebKit): 23 (WebMediaStreamCenter): 24 (WebKit::WebMediaStreamCenter::didAddMediaStreamTrack): 25 (WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack): 26 * chromium/public/WebMediaStreamCenterClient.h: 27 (WebKit): 28 (WebMediaStreamCenterClient): 29 * chromium/public/WebMediaStreamComponent.h: 30 * chromium/public/WebMediaStreamDescriptor.h: 31 * chromium/public/WebMediaStreamTrack.h: Added. 32 (WebCore): 33 (WebKit): 34 (WebMediaStreamTrack): 35 (WebKit::WebMediaStreamTrack::WebMediaStreamTrack): 36 (WebKit::WebMediaStreamTrack::~WebMediaStreamTrack): 37 (WebKit::WebMediaStreamTrack::operator=): 38 (WebKit::WebMediaStreamTrack::isNull): 39 * chromium/public/WebRTCPeerConnectionHandler.h: 40 (WebKit): 41 (WebRTCPeerConnectionHandler): 42 * chromium/public/WebRTCPeerConnectionHandlerClient.h: 43 (WebKit): 44 (WebRTCPeerConnectionHandlerClient): 45 * chromium/public/WebRTCStatsRequest.h: 46 (WebKit): 47 (WebRTCStatsRequest): 48 1 49 2013-01-30 Yusuf Ozuysal <yusufo@google.com> 2 50 -
trunk/Source/Platform/Platform.gypi
r140499 r141444 87 87 'chromium/public/WebMediaStreamCenterClient.h', 88 88 'chromium/public/WebMediaStreamComponent.h', 89 'chromium/public/WebMediaStream.h', 89 90 'chromium/public/WebMediaStreamDescriptor.h', 90 91 'chromium/public/WebMediaStreamSource.h', 91 92 'chromium/public/WebMediaStreamSourcesRequest.h', 93 'chromium/public/WebMediaStreamTrack.h', 92 94 'chromium/public/WebMessagePortChannel.h', 93 95 'chromium/public/WebMessagePortChannelClient.h', -
trunk/Source/Platform/chromium/public/WebMediaStream.h
r141443 r141444 1 1 /* 2 * Copyright (C) 201 1Google Inc. All rights reserved.2 * Copyright (C) 2013 Google Inc. All rights reserved. 3 3 * 4 4 * Redistribution and use in source and binary forms, with or without … … 23 23 */ 24 24 25 #ifndef WebMediaStream Descriptor_h26 #define WebMediaStream Descriptor_h25 #ifndef WebMediaStream_h 26 #define WebMediaStream_h 27 27 28 28 #include "WebCommon.h" … … 37 37 namespace WebKit { 38 38 39 class WebMediaStream Component;39 class WebMediaStreamTrack; 40 40 class WebMediaStreamSource; 41 41 class WebString; 42 42 43 class WebMediaStream Descriptor{43 class WebMediaStream { 44 44 public: 45 45 class ExtraData { … … 48 48 }; 49 49 50 WebMediaStream Descriptor() { }51 WebMediaStream Descriptor(const WebMediaStreamDescriptor& other) { assign(other); }52 ~WebMediaStream Descriptor() { reset(); }50 WebMediaStream() { } 51 WebMediaStream(const WebMediaStream& other) { assign(other); } 52 ~WebMediaStream() { reset(); } 53 53 54 WebMediaStream Descriptor& operator=(const WebMediaStreamDescriptor& other)54 WebMediaStream& operator=(const WebMediaStream& other) 55 55 { 56 56 assign(other); … … 58 58 } 59 59 60 WEBKIT_EXPORT void assign(const WebMediaStream Descriptor&);60 WEBKIT_EXPORT void assign(const WebMediaStream&); 61 61 62 62 WEBKIT_EXPORT void initialize(const WebString& label, const WebVector<WebMediaStreamSource>& audioSources, const WebVector<WebMediaStreamSource>& videoSources); … … 69 69 WEBKIT_EXPORT WebString id() const; 70 70 71 WEBKIT_EXPORT void audioSources(WebVector<WebMediaStream Component>&) const;72 WEBKIT_EXPORT void videoSources(WebVector<WebMediaStream Component>&) const;71 WEBKIT_EXPORT void audioSources(WebVector<WebMediaStreamTrack>&) const; 72 WEBKIT_EXPORT void videoSources(WebVector<WebMediaStreamTrack>&) const; 73 73 74 // Extra data associated with this WebMediaStream Descriptor.74 // Extra data associated with this WebMediaStream. 75 75 // If non-null, the extra data pointer will be deleted when the object is destroyed. 76 76 // Setting the extra data pointer will cause any existing non-null … … 80 80 81 81 #if WEBKIT_IMPLEMENTATION 82 WebMediaStream Descriptor(WebCore::MediaStreamDescriptor*);83 WebMediaStream Descriptor(const WTF::PassRefPtr<WebCore::MediaStreamDescriptor>&);82 WebMediaStream(WebCore::MediaStreamDescriptor*); 83 WebMediaStream(const WTF::PassRefPtr<WebCore::MediaStreamDescriptor>&); 84 84 operator WTF::PassRefPtr<WebCore::MediaStreamDescriptor>() const; 85 85 operator WebCore::MediaStreamDescriptor*() const; 86 WebMediaStream Descriptor& operator=(const WTF::PassRefPtr<WebCore::MediaStreamDescriptor>&);86 WebMediaStream& operator=(const WTF::PassRefPtr<WebCore::MediaStreamDescriptor>&); 87 87 #endif 88 88 … … 93 93 } // namespace WebKit 94 94 95 #endif // WebMediaStream Descriptor_h95 #endif // WebMediaStream_h -
trunk/Source/Platform/chromium/public/WebMediaStreamCenter.h
r134084 r141444 35 35 36 36 namespace WebKit { 37 class WebMediaStreamComponent; 38 class WebMediaStreamDescriptor; 37 class WebMediaStream; 39 38 class WebMediaStreamSourcesRequest; 39 class WebMediaStreamTrack; 40 40 41 41 class WebMediaStreamCenter { … … 44 44 45 45 virtual void queryMediaStreamSources(const WebMediaStreamSourcesRequest&) = 0; 46 virtual void didEnableMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent&) = 0;47 virtual void didDisableMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent&) = 0;48 virtual bool didAddMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent&) { return false; };49 virtual bool didRemoveMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent&) { return false; };50 virtual void didStopLocalMediaStream(const WebMediaStream Descriptor&) = 0;51 virtual void didCreateMediaStream(WebMediaStream Descriptor&) = 0;46 virtual void didEnableMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack&) = 0; 47 virtual void didDisableMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack&) = 0; 48 virtual bool didAddMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack&) { return false; }; 49 virtual bool didRemoveMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack&) { return false; }; 50 virtual void didStopLocalMediaStream(const WebMediaStream&) = 0; 51 virtual void didCreateMediaStream(WebMediaStream&) = 0; 52 52 }; 53 53 -
trunk/Source/Platform/chromium/public/WebMediaStreamCenterClient.h
r121691 r141444 33 33 34 34 namespace WebKit { 35 36 class WebMediaStreamComponent; 37 class WebMediaStreamDescriptor; 35 class WebMediaStream; 36 class WebMediaStreamTrack; 38 37 39 38 class WebMediaStreamCenterClient { … … 41 40 virtual ~WebMediaStreamCenterClient() { } 42 41 43 virtual void stopLocalMediaStream(const WebMediaStream Descriptor&) = 0;44 virtual void addMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent&) = 0;45 virtual void removeMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent&) = 0;42 virtual void stopLocalMediaStream(const WebMediaStream&) = 0; 43 virtual void addMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack&) = 0; 44 virtual void removeMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack&) = 0; 46 45 }; 47 46 -
trunk/Source/Platform/chromium/public/WebMediaStreamComponent.h
r141151 r141444 32 32 #define WebMediaStreamComponent_h 33 33 34 #include "WebCommon.h" 35 #include "WebNonCopyable.h" 36 #include "WebPrivatePtr.h" 34 #include <public/WebMediaStreamTrack.h> 37 35 38 namespace WebCore { 39 class MediaStreamComponent; 40 } 41 42 namespace WebKit { 43 class WebMediaStreamDescriptor; 44 class WebMediaStreamSource; 45 class WebString; 46 47 class WebMediaStreamComponent { 48 public: 49 WebMediaStreamComponent() { } 50 WebMediaStreamComponent(const WebMediaStreamComponent& other) { assign(other); } 51 ~WebMediaStreamComponent() { reset(); } 52 53 WebMediaStreamComponent& operator=(const WebMediaStreamComponent& other) 54 { 55 assign(other); 56 return *this; 57 } 58 WEBKIT_EXPORT void assign(const WebMediaStreamComponent&); 59 WEBKIT_EXPORT void initialize(const WebMediaStreamSource&); 60 WEBKIT_EXPORT void reset(); 61 bool isNull() const { return m_private.isNull(); } 62 63 WEBKIT_EXPORT WebString id() const; 64 65 WEBKIT_EXPORT WebMediaStreamDescriptor stream() const; 66 WEBKIT_EXPORT WebMediaStreamSource source() const; 67 WEBKIT_EXPORT bool isEnabled() const; 68 69 #if WEBKIT_IMPLEMENTATION 70 WebMediaStreamComponent(WebCore::MediaStreamComponent*); 71 WebMediaStreamComponent& operator=(WebCore::MediaStreamComponent*); 72 operator WTF::PassRefPtr<WebCore::MediaStreamComponent>() const; 73 operator WebCore::MediaStreamComponent*() const; 74 #endif 75 76 private: 77 WebPrivatePtr<WebCore::MediaStreamComponent> m_private; 78 }; 79 80 } // namespace WebKit 36 // The name WebMediaStreamComponent is EXTREMELY DEPRECATED. 37 #define WebMediaStreamComponent WebMediaStreamTrack 81 38 82 39 #endif // WebMediaStreamComponent_h -
trunk/Source/Platform/chromium/public/WebMediaStreamDescriptor.h
r139352 r141444 26 26 #define WebMediaStreamDescriptor_h 27 27 28 #include "WebCommon.h" 29 #include "WebNonCopyable.h" 30 #include "WebPrivatePtr.h" 31 #include "WebVector.h" 28 #include <public/WebMediaStream.h> 32 29 33 namespace WebCore { 34 class MediaStreamDescriptor; 35 } 36 37 namespace WebKit { 38 39 class WebMediaStreamComponent; 40 class WebMediaStreamSource; 41 class WebString; 42 43 class WebMediaStreamDescriptor { 44 public: 45 class ExtraData { 46 public: 47 virtual ~ExtraData() { } 48 }; 49 50 WebMediaStreamDescriptor() { } 51 WebMediaStreamDescriptor(const WebMediaStreamDescriptor& other) { assign(other); } 52 ~WebMediaStreamDescriptor() { reset(); } 53 54 WebMediaStreamDescriptor& operator=(const WebMediaStreamDescriptor& other) 55 { 56 assign(other); 57 return *this; 58 } 59 60 WEBKIT_EXPORT void assign(const WebMediaStreamDescriptor&); 61 62 WEBKIT_EXPORT void initialize(const WebString& label, const WebVector<WebMediaStreamSource>& audioSources, const WebVector<WebMediaStreamSource>& videoSources); 63 WEBKIT_EXPORT void reset(); 64 bool isNull() const { return m_private.isNull(); } 65 66 // DEPRECATED 67 WEBKIT_EXPORT WebString label() const; 68 69 WEBKIT_EXPORT WebString id() const; 70 71 WEBKIT_EXPORT void audioSources(WebVector<WebMediaStreamComponent>&) const; 72 WEBKIT_EXPORT void videoSources(WebVector<WebMediaStreamComponent>&) const; 73 74 // Extra data associated with this WebMediaStreamDescriptor. 75 // If non-null, the extra data pointer will be deleted when the object is destroyed. 76 // Setting the extra data pointer will cause any existing non-null 77 // extra data pointer to be deleted. 78 WEBKIT_EXPORT ExtraData* extraData() const; 79 WEBKIT_EXPORT void setExtraData(ExtraData*); 80 81 #if WEBKIT_IMPLEMENTATION 82 WebMediaStreamDescriptor(WebCore::MediaStreamDescriptor*); 83 WebMediaStreamDescriptor(const WTF::PassRefPtr<WebCore::MediaStreamDescriptor>&); 84 operator WTF::PassRefPtr<WebCore::MediaStreamDescriptor>() const; 85 operator WebCore::MediaStreamDescriptor*() const; 86 WebMediaStreamDescriptor& operator=(const WTF::PassRefPtr<WebCore::MediaStreamDescriptor>&); 87 #endif 88 89 private: 90 WebPrivatePtr<WebCore::MediaStreamDescriptor> m_private; 91 }; 92 93 } // namespace WebKit 30 // The name WebMediaStreamDescriptor is EXTREMELY DEPRECATED. 31 #define WebMediaStreamDescriptor WebMediaStream 94 32 95 33 #endif // WebMediaStreamDescriptor_h -
trunk/Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h
r137441 r141444 34 34 namespace WebKit { 35 35 class WebMediaConstraints; 36 class WebMediaStream Descriptor;36 class WebMediaStream; 37 37 class WebRTCConfiguration; 38 38 class WebRTCDataChannelHandler; … … 59 59 virtual bool updateICE(const WebRTCConfiguration&, const WebMediaConstraints&) = 0; 60 60 virtual bool addICECandidate(const WebRTCICECandidate&) = 0; 61 virtual bool addStream(const WebMediaStream Descriptor&, const WebMediaConstraints&) = 0;62 virtual void removeStream(const WebMediaStream Descriptor&) = 0;61 virtual bool addStream(const WebMediaStream&, const WebMediaConstraints&) = 0; 62 virtual void removeStream(const WebMediaStream&) = 0; 63 63 // FIXME: Remove default implementation when clients have changed. 64 64 virtual void getStats(const WebRTCStatsRequest&) { } -
trunk/Source/Platform/chromium/public/WebRTCPeerConnectionHandlerClient.h
r140310 r141444 33 33 34 34 namespace WebKit { 35 class WebMediaStream Descriptor;35 class WebMediaStream; 36 36 class WebRTCDataChannelHandler; 37 37 class WebRTCICECandidate; … … 71 71 virtual void didChangeICEGatheringState(ICEGatheringState) { } 72 72 virtual void didChangeICEConnectionState(ICEConnectionState) { } 73 virtual void didAddRemoteStream(const WebMediaStream Descriptor&) = 0;74 virtual void didRemoveRemoteStream(const WebMediaStream Descriptor&) = 0;73 virtual void didAddRemoteStream(const WebMediaStream&) = 0; 74 virtual void didRemoveRemoteStream(const WebMediaStream&) = 0; 75 75 virtual void didAddRemoteDataChannel(WebRTCDataChannelHandler*) { } 76 76 -
trunk/Source/Platform/chromium/public/WebRTCStatsRequest.h
r131584 r141444 42 42 namespace WebKit { 43 43 44 class WebMediaStream Component;45 class WebMediaStream Descriptor;44 class WebMediaStreamTrack; 45 class WebMediaStream; 46 46 class WebRTCStatsResponse; 47 47 … … 89 89 // required to look up a MediaStreamTrack implementation. 90 90 // It is only useful to call them when hasSelector() returns true. 91 WEBKIT_EXPORT const WebMediaStream Descriptorstream() const;91 WEBKIT_EXPORT const WebMediaStream stream() const; 92 92 93 WEBKIT_EXPORT const WebMediaStream Componentcomponent() const;93 WEBKIT_EXPORT const WebMediaStreamTrack component() const; 94 94 95 95 WEBKIT_EXPORT void requestSucceeded(const WebRTCStatsResponse&) const; -
trunk/Source/WebCore/ChangeLog
r141436 r141444 1 2013-01-31 Tommy Widenflycht <tommyw@google.com> 2 3 [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack 4 https://bugs.webkit.org/show_bug.cgi?id=108458 5 6 Reviewed by Adam Barth. 7 8 Only renames, no other code changes. 9 10 * WebCore.gypi: 11 * platform/chromium/support/WebMediaStream.cpp: Added. 12 (WebKit::WebMediaStream::WebMediaStream): 13 (WebKit): 14 (WebKit::WebMediaStream::reset): 15 (WebKit::WebMediaStream::label): 16 (WebKit::WebMediaStream::id): 17 (WebKit::WebMediaStream::extraData): 18 (WebKit::WebMediaStream::setExtraData): 19 (WebKit::WebMediaStream::audioSources): 20 (WebKit::WebMediaStream::videoSources): 21 (WebKit::WebMediaStream::operator=): 22 (WebKit::WebMediaStream::operator PassRefPtr<WebCore::MediaStreamDescriptor>): 23 (WebKit::WebMediaStream::operator WebCore::MediaStreamDescriptor*): 24 (WebKit::WebMediaStream::initialize): 25 (WebKit::WebMediaStream::assign): 26 * platform/chromium/support/WebMediaStreamComponent.cpp: Removed. 27 * platform/chromium/support/WebMediaStreamDescriptor.cpp: Removed. 28 * platform/chromium/support/WebMediaStreamTrack.cpp: Added. 29 (WebKit): 30 (WebKit::WebMediaStreamTrack::WebMediaStreamTrack): 31 (WebKit::WebMediaStreamTrack::operator=): 32 (WebKit::WebMediaStreamTrack::initialize): 33 (WebKit::WebMediaStreamTrack::reset): 34 (WebKit::WebMediaStreamTrack::operator PassRefPtr<MediaStreamComponent>): 35 (WebKit::WebMediaStreamTrack::operator MediaStreamComponent*): 36 (WebKit::WebMediaStreamTrack::isEnabled): 37 (WebKit::WebMediaStreamTrack::id): 38 (WebKit::WebMediaStreamTrack::stream): 39 (WebKit::WebMediaStreamTrack::source): 40 (WebKit::WebMediaStreamTrack::assign): 41 * platform/chromium/support/WebRTCStatsRequest.cpp: 42 (WebKit::WebRTCStatsRequest::stream): 43 (WebKit::WebRTCStatsRequest::component): 44 * platform/mediastream/chromium/MediaStreamCenterChromium.cpp: 45 (WebCore::MediaStreamCenterChromium::didCreateMediaStream): 46 (WebCore::MediaStreamCenterChromium::stopLocalMediaStream): 47 (WebCore::MediaStreamCenterChromium::addMediaStreamTrack): 48 (WebCore::MediaStreamCenterChromium::removeMediaStreamTrack): 49 * platform/mediastream/chromium/MediaStreamCenterChromium.h: 50 (WebKit): 51 (MediaStreamCenterChromium): 52 * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp: 53 (WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteStream): 54 (WebCore::RTCPeerConnectionHandlerChromium::didRemoveRemoteStream): 55 * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h: 56 (WebKit): 57 (RTCPeerConnectionHandlerChromium): 58 1 59 2013-01-31 Dmitry Zvorygin <zvorygin@chromium.org> 2 60 -
trunk/Source/WebCore/WebCore.gypi
r141382 r141444 7203 7203 'platform/chromium/support/WebHTTPLoadInfo.cpp', 7204 7204 'platform/chromium/support/WebMediaConstraints.cpp', 7205 'platform/chromium/support/WebMediaStreamComponent.cpp', 7206 'platform/chromium/support/WebMediaStreamDescriptor.cpp', 7205 'platform/chromium/support/WebMediaStream.cpp', 7207 7206 'platform/chromium/support/WebMediaStreamSource.cpp', 7208 7207 'platform/chromium/support/WebMediaStreamSourcesRequest.cpp', 7208 'platform/chromium/support/WebMediaStreamTrack.cpp', 7209 7209 'platform/chromium/support/WebPrerender.cpp', 7210 7210 'platform/chromium/support/WebRTCConfiguration.cpp', -
trunk/Source/WebCore/platform/chromium/support/WebRTCStatsRequest.cpp
r131584 r141444 1 2 1 /* 3 2 * Copyright (C) 2012 Google Inc. All rights reserved. … … 34 33 #if ENABLE(MEDIA_STREAM) 35 34 36 #include <public/WebMediaStreamComponent.h>37 #include <public/WebMediaStreamDescriptor.h>38 35 #include <public/WebRTCStatsRequest.h> 39 #include <public/WebRTCStatsResponse.h>40 36 41 37 #include "RTCStatsRequest.h" 42 38 #include "RTCStatsResponse.h" 39 #include <public/WebMediaStream.h> 40 #include <public/WebMediaStreamTrack.h> 41 #include <public/WebRTCStatsResponse.h> 43 42 #include <wtf/PassOwnPtr.h> 44 43 … … 72 71 } 73 72 74 const WebMediaStream DescriptorWebRTCStatsRequest::stream() const73 const WebMediaStream WebRTCStatsRequest::stream() const 75 74 { 76 return WebMediaStream Descriptor(m_private->stream());75 return WebMediaStream(m_private->stream()); 77 76 } 78 77 79 const WebMediaStream ComponentWebRTCStatsRequest::component() const78 const WebMediaStreamTrack WebRTCStatsRequest::component() const 80 79 { 81 return WebMediaStream Component(m_private->component());80 return WebMediaStreamTrack(m_private->component()); 82 81 } 83 82 -
trunk/Source/WebCore/platform/mediastream/chromium/MediaStreamCenterChromium.cpp
r134084 r141444 38 38 #include "MediaStreamSourcesQueryClient.h" 39 39 #include <public/Platform.h> 40 #include <public/WebMediaStream.h> 40 41 #include <public/WebMediaStreamCenter.h> 41 #include <public/WebMediaStreamComponent.h>42 #include <public/WebMediaStreamDescriptor.h>43 42 #include <public/WebMediaStreamSourcesRequest.h> 43 #include <public/WebMediaStreamTrack.h> 44 44 #include <wtf/MainThread.h> 45 45 #include <wtf/PassOwnPtr.h> … … 102 102 { 103 103 if (m_private) { 104 WebKit::WebMediaStream DescriptorwebStream(stream);104 WebKit::WebMediaStream webStream(stream); 105 105 m_private->didCreateMediaStream(webStream); 106 106 } 107 107 } 108 108 109 void MediaStreamCenterChromium::stopLocalMediaStream(const WebKit::WebMediaStream Descriptor& stream)109 void MediaStreamCenterChromium::stopLocalMediaStream(const WebKit::WebMediaStream& stream) 110 110 { 111 111 endLocalMediaStream(stream); 112 112 } 113 113 114 void MediaStreamCenterChromium::addMediaStreamTrack(const WebKit::WebMediaStream Descriptor& stream, const WebKit::WebMediaStreamComponent& component)114 void MediaStreamCenterChromium::addMediaStreamTrack(const WebKit::WebMediaStream& stream, const WebKit::WebMediaStreamTrack& component) 115 115 { 116 116 MediaStreamCenter::addMediaStreamTrack(stream, component); 117 117 } 118 118 119 void MediaStreamCenterChromium::removeMediaStreamTrack(const WebKit::WebMediaStream Descriptor& stream, const WebKit::WebMediaStreamComponent& component)119 void MediaStreamCenterChromium::removeMediaStreamTrack(const WebKit::WebMediaStream& stream, const WebKit::WebMediaStreamTrack& component) 120 120 { 121 121 MediaStreamCenter::removeMediaStreamTrack(stream, component); -
trunk/Source/WebCore/platform/mediastream/chromium/MediaStreamCenterChromium.h
r134084 r141444 42 42 43 43 namespace WebKit { 44 class WebMediaStream; 44 45 class WebMediaStreamCenter; 45 class WebMediaStreamComponent; 46 class WebMediaStreamDescriptor; 46 class WebMediaStreamTrack; 47 47 } 48 48 … … 67 67 68 68 // WebKit::WebMediaStreamCenterClient 69 virtual void stopLocalMediaStream(const WebKit::WebMediaStream Descriptor&) OVERRIDE;70 virtual void addMediaStreamTrack(const WebKit::WebMediaStream Descriptor&, const WebKit::WebMediaStreamComponent&) OVERRIDE;71 virtual void removeMediaStreamTrack(const WebKit::WebMediaStream Descriptor&, const WebKit::WebMediaStreamComponent&) OVERRIDE;69 virtual void stopLocalMediaStream(const WebKit::WebMediaStream&) OVERRIDE; 70 virtual void addMediaStreamTrack(const WebKit::WebMediaStream&, const WebKit::WebMediaStreamTrack&) OVERRIDE; 71 virtual void removeMediaStreamTrack(const WebKit::WebMediaStream&, const WebKit::WebMediaStreamTrack&) OVERRIDE; 72 72 73 73 private: -
trunk/Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp
r140310 r141444 47 47 #include <public/Platform.h> 48 48 #include <public/WebMediaConstraints.h> 49 #include <public/WebMediaStream Descriptor.h>49 #include <public/WebMediaStream.h> 50 50 #include <public/WebRTCConfiguration.h> 51 51 #include <public/WebRTCDataChannelHandler.h> … … 189 189 } 190 190 191 void RTCPeerConnectionHandlerChromium::didAddRemoteStream(const WebKit::WebMediaStream Descriptor& webMediaStreamDescriptor)191 void RTCPeerConnectionHandlerChromium::didAddRemoteStream(const WebKit::WebMediaStream& webMediaStreamDescriptor) 192 192 { 193 193 m_client->didAddRemoteStream(webMediaStreamDescriptor); 194 194 } 195 195 196 void RTCPeerConnectionHandlerChromium::didRemoveRemoteStream(const WebKit::WebMediaStream Descriptor& webMediaStreamDescriptor)196 void RTCPeerConnectionHandlerChromium::didRemoveRemoteStream(const WebKit::WebMediaStream& webMediaStreamDescriptor) 197 197 { 198 198 m_client->didRemoveRemoteStream(webMediaStreamDescriptor); -
trunk/Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h
r140310 r141444 42 42 43 43 namespace WebKit { 44 class WebMediaStream Descriptor;44 class WebMediaStream; 45 45 class WebRTCICECandidate; 46 46 } … … 79 79 virtual void didChangeICEGatheringState(WebKit::WebRTCPeerConnectionHandlerClient::ICEGatheringState) OVERRIDE; 80 80 virtual void didChangeICEConnectionState(WebKit::WebRTCPeerConnectionHandlerClient::ICEConnectionState) OVERRIDE; 81 virtual void didAddRemoteStream(const WebKit::WebMediaStream Descriptor&) OVERRIDE;82 virtual void didRemoveRemoteStream(const WebKit::WebMediaStream Descriptor&) OVERRIDE;81 virtual void didAddRemoteStream(const WebKit::WebMediaStream&) OVERRIDE; 82 virtual void didRemoveRemoteStream(const WebKit::WebMediaStream&) OVERRIDE; 83 83 virtual void didAddRemoteDataChannel(WebKit::WebRTCDataChannelHandler*) OVERRIDE; 84 84 -
trunk/Source/WebKit/chromium/ChangeLog
r141438 r141444 1 2013-01-31 Tommy Widenflycht <tommyw@google.com> 2 3 [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack 4 https://bugs.webkit.org/show_bug.cgi?id=108458 5 6 Reviewed by Adam Barth. 7 8 Only renames, no other code changes. 9 10 * public/WebMediaStreamRegistry.h: 11 (WebKit): 12 (WebMediaStreamRegistry): 13 * public/WebUserMediaRequest.h: 14 (WebKit): 15 (WebUserMediaRequest): 16 * src/WebMediaStreamRegistry.cpp: 17 (WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor): 18 * src/WebUserMediaRequest.cpp: 19 (WebKit::WebUserMediaRequest::requestSucceeded): 20 1 21 2013-01-31 Alec Flett <alecflett@chromium.org> 2 22 -
trunk/Source/WebKit/chromium/public/WebMediaStreamRegistry.h
r140621 r141444 36 36 namespace WebKit { 37 37 38 class WebMediaStream Descriptor;38 class WebMediaStream; 39 39 class WebURL; 40 40 41 41 class WebMediaStreamRegistry { 42 42 public: 43 WEBKIT_EXPORT static WebMediaStream DescriptorlookupMediaStreamDescriptor(const WebURL&);43 WEBKIT_EXPORT static WebMediaStream lookupMediaStreamDescriptor(const WebURL&); 44 44 }; 45 45 -
trunk/Source/WebKit/chromium/public/WebUserMediaRequest.h
r140621 r141444 43 43 class WebDocument; 44 44 class WebMediaConstraints; 45 class WebMediaStream Descriptor;45 class WebMediaStream; 46 46 class WebMediaStreamSource; 47 47 class WebString; … … 73 73 WEBKIT_EXPORT WebDocument ownerDocument() const; 74 74 75 WEBKIT_EXPORT void requestSucceeded(const WebMediaStream Descriptor&);75 WEBKIT_EXPORT void requestSucceeded(const WebMediaStream&); 76 76 77 77 WEBKIT_EXPORT void requestFailed(); -
trunk/Source/WebKit/chromium/src/WebMediaStreamRegistry.cpp
r130530 r141444 38 38 #include "MediaStreamDescriptor.h" 39 39 #include "MediaStreamRegistry.h" 40 #include <public/WebMediaStream Descriptor.h>40 #include <public/WebMediaStream.h> 41 41 #include <public/WebString.h> 42 42 #include <public/WebURL.h> … … 46 46 namespace WebKit { 47 47 48 WebMediaStream DescriptorWebMediaStreamRegistry::lookupMediaStreamDescriptor(const WebURL& url)48 WebMediaStream WebMediaStreamRegistry::lookupMediaStreamDescriptor(const WebURL& url) 49 49 { 50 return WebMediaStream Descriptor(MediaStreamRegistry::registry().lookupMediaStreamDescriptor(KURL(url).string()));50 return WebMediaStream(MediaStreamRegistry::registry().lookupMediaStreamDescriptor(KURL(url).string())); 51 51 } 52 52 -
trunk/Source/WebKit/chromium/src/WebUserMediaRequest.cpp
r129749 r141444 44 44 #include "WebSecurityOrigin.h" 45 45 #include <public/WebMediaConstraints.h> 46 #include <public/WebMediaStream Descriptor.h>46 #include <public/WebMediaStream.h> 47 47 #include <public/WebMediaStreamSource.h> 48 48 #include <public/WebString.h> … … 100 100 } 101 101 102 void WebUserMediaRequest::requestSucceeded(const WebMediaStream Descriptor& streamDescriptor)102 void WebUserMediaRequest::requestSucceeded(const WebMediaStream& streamDescriptor) 103 103 { 104 104 ASSERT(!isNull() && !streamDescriptor.isNull()); -
trunk/Tools/ChangeLog
r141441 r141444 1 2013-01-31 Tommy Widenflycht <tommyw@google.com> 2 3 [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack 4 https://bugs.webkit.org/show_bug.cgi?id=108458 5 6 Reviewed by Adam Barth. 7 8 Only renames, no other code changes. 9 10 * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: 11 (MockWebMediaStreamCenter::didEnableMediaStreamTrack): 12 (MockWebMediaStreamCenter::didDisableMediaStreamTrack): 13 (MockWebMediaStreamCenter::didAddMediaStreamTrack): 14 (MockWebMediaStreamCenter::didRemoveMediaStreamTrack): 15 (MockWebMediaStreamCenter::didStopLocalMediaStream): 16 (MockWebMediaStreamCenter::didCreateMediaStream): 17 * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: 18 (MockWebMediaStreamCenter): 19 * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: 20 (MockWebRTCPeerConnectionHandler::addStream): 21 (MockWebRTCPeerConnectionHandler::removeStream): 22 (MockWebRTCPeerConnectionHandler::getStats): 23 * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: 24 (MockWebRTCPeerConnectionHandler): 25 * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: 26 (UserMediaRequestTask::UserMediaRequestTask): 27 (WebUserMediaClientMock::requestUserMedia): 28 1 29 2013-01-31 Zan Dobersek <zdobersek@igalia.com> 2 30 -
trunk/Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp
r138895 r141444 35 35 36 36 #include <public/WebAudioDestinationConsumer.h> 37 #include <public/WebMediaStream.h> 37 38 #include <public/WebMediaStreamCenterClient.h> 38 #include <public/WebMediaStreamComponent.h>39 #include <public/WebMediaStreamDescriptor.h>40 39 #include <public/WebMediaStreamSource.h> 41 40 #include <public/WebMediaStreamSourcesRequest.h> 41 #include <public/WebMediaStreamTrack.h> 42 42 #include <public/WebVector.h> 43 43 … … 54 54 } 55 55 56 void MockWebMediaStreamCenter::didEnableMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent& component)56 void MockWebMediaStreamCenter::didEnableMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack& component) 57 57 { 58 58 component.source().setReadyState(WebMediaStreamSource::ReadyStateLive); 59 59 } 60 60 61 void MockWebMediaStreamCenter::didDisableMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent& component)61 void MockWebMediaStreamCenter::didDisableMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack& component) 62 62 { 63 63 component.source().setReadyState(WebMediaStreamSource::ReadyStateMuted); 64 64 } 65 65 66 bool MockWebMediaStreamCenter::didAddMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent&)66 bool MockWebMediaStreamCenter::didAddMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack&) 67 67 { 68 68 return true; 69 69 }; 70 70 71 bool MockWebMediaStreamCenter::didRemoveMediaStreamTrack(const WebMediaStream Descriptor&, const WebMediaStreamComponent&)71 bool MockWebMediaStreamCenter::didRemoveMediaStreamTrack(const WebMediaStream&, const WebMediaStreamTrack&) 72 72 { 73 73 return true; 74 74 }; 75 75 76 void MockWebMediaStreamCenter::didStopLocalMediaStream(const WebMediaStream Descriptor& stream)76 void MockWebMediaStreamCenter::didStopLocalMediaStream(const WebMediaStream& stream) 77 77 { 78 WebVector<WebMediaStream Component> audioComponents;78 WebVector<WebMediaStreamTrack> audioComponents; 79 79 stream.audioSources(audioComponents); 80 80 for (size_t i = 0; i < audioComponents.size(); ++i) 81 81 audioComponents[i].source().setReadyState(WebMediaStreamSource::ReadyStateEnded); 82 82 83 WebVector<WebMediaStream Component> videoComponents;83 WebVector<WebMediaStreamTrack> videoComponents; 84 84 stream.videoSources(videoComponents); 85 85 for (size_t i = 0; i < videoComponents.size(); ++i) … … 94 94 }; 95 95 96 void MockWebMediaStreamCenter::didCreateMediaStream(WebMediaStream Descriptor& stream)96 void MockWebMediaStreamCenter::didCreateMediaStream(WebMediaStream& stream) 97 97 { 98 WebVector<WebMediaStream Component> audioComponents;98 WebVector<WebMediaStreamTrack> audioComponents; 99 99 stream.audioSources(audioComponents); 100 100 for (size_t i = 0; i < audioComponents.size(); ++i) { -
trunk/Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.h
r134084 r141444 44 44 45 45 virtual void queryMediaStreamSources(const WebKit::WebMediaStreamSourcesRequest&) OVERRIDE; 46 virtual void didEnableMediaStreamTrack(const WebKit::WebMediaStream Descriptor&, const WebKit::WebMediaStreamComponent&) OVERRIDE;47 virtual void didDisableMediaStreamTrack(const WebKit::WebMediaStream Descriptor&, const WebKit::WebMediaStreamComponent&) OVERRIDE;48 virtual bool didAddMediaStreamTrack(const WebKit::WebMediaStream Descriptor&, const WebKit::WebMediaStreamComponent&) OVERRIDE;49 virtual bool didRemoveMediaStreamTrack(const WebKit::WebMediaStream Descriptor&, const WebKit::WebMediaStreamComponent&) OVERRIDE;50 virtual void didStopLocalMediaStream(const WebKit::WebMediaStream Descriptor&) OVERRIDE;51 virtual void didCreateMediaStream(WebKit::WebMediaStream Descriptor&) OVERRIDE;46 virtual void didEnableMediaStreamTrack(const WebKit::WebMediaStream&, const WebKit::WebMediaStreamTrack&) OVERRIDE; 47 virtual void didDisableMediaStreamTrack(const WebKit::WebMediaStream&, const WebKit::WebMediaStreamTrack&) OVERRIDE; 48 virtual bool didAddMediaStreamTrack(const WebKit::WebMediaStream&, const WebKit::WebMediaStreamTrack&) OVERRIDE; 49 virtual bool didRemoveMediaStreamTrack(const WebKit::WebMediaStream&, const WebKit::WebMediaStreamTrack&) OVERRIDE; 50 virtual void didStopLocalMediaStream(const WebKit::WebMediaStream&) OVERRIDE; 51 virtual void didCreateMediaStream(WebKit::WebMediaStream&) OVERRIDE; 52 52 53 53 private: -
trunk/Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp
r140310 r141444 38 38 #include "Task.h" 39 39 #include <public/WebMediaConstraints.h> 40 #include <public/WebMediaStream Component.h>41 #include <public/WebMediaStream Descriptor.h>40 #include <public/WebMediaStream.h> 41 #include <public/WebMediaStreamTrack.h> 42 42 #include <public/WebRTCPeerConnectionHandlerClient.h> 43 43 #include <public/WebRTCSessionDescription.h> … … 249 249 } 250 250 251 bool MockWebRTCPeerConnectionHandler::addStream(const WebMediaStream Descriptor& stream, const WebMediaConstraints&)251 bool MockWebRTCPeerConnectionHandler::addStream(const WebMediaStream& stream, const WebMediaConstraints&) 252 252 { 253 253 m_streamCount += 1; … … 257 257 } 258 258 259 void MockWebRTCPeerConnectionHandler::removeStream(const WebMediaStream Descriptor& stream)259 void MockWebRTCPeerConnectionHandler::removeStream(const WebMediaStream& stream) 260 260 { 261 261 m_streamCount -= 1; … … 269 269 double currentDate = WTF::jsCurrentTime(); 270 270 if (request.hasSelector()) { 271 WebMediaStreamDescriptor stream = request.stream(); 272 WebMediaStreamComponent component = request.component(); 271 WebMediaStream stream = request.stream(); 273 272 // FIXME: There is no check that the fetched values are valid. 274 273 size_t reportIndex = response.addReport(); -
trunk/Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h
r137441 r141444 58 58 virtual bool updateICE(const WebKit::WebRTCConfiguration&, const WebKit::WebMediaConstraints&) OVERRIDE; 59 59 virtual bool addICECandidate(const WebKit::WebRTCICECandidate&) OVERRIDE; 60 virtual bool addStream(const WebKit::WebMediaStream Descriptor&, const WebKit::WebMediaConstraints&) OVERRIDE;61 virtual void removeStream(const WebKit::WebMediaStream Descriptor&) OVERRIDE;60 virtual bool addStream(const WebKit::WebMediaStream&, const WebKit::WebMediaConstraints&) OVERRIDE; 61 virtual void removeStream(const WebKit::WebMediaStream&) OVERRIDE; 62 62 virtual void getStats(const WebKit::WebRTCStatsRequest&) OVERRIDE; 63 63 virtual WebKit::WebRTCDataChannelHandler* createDataChannel(const WebKit::WebString& label, bool reliable) OVERRIDE; -
trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp
r132138 r141444 40 40 #include "WebUserMediaRequest.h" 41 41 #include <public/WebMediaConstraints.h> 42 #include <public/WebMediaStream Descriptor.h>42 #include <public/WebMediaStream.h> 43 43 #include <public/WebMediaStreamSource.h> 44 44 #include <public/WebVector.h> … … 50 50 class UserMediaRequestTask : public WebMethodTask<WebUserMediaClientMock> { 51 51 public: 52 UserMediaRequestTask(WebUserMediaClientMock* object, const WebUserMediaRequest& request, const WebMediaStream Descriptorresult)52 UserMediaRequestTask(WebUserMediaClientMock* object, const WebUserMediaRequest& request, const WebMediaStream result) 53 53 : WebMethodTask<WebUserMediaClientMock>(object) 54 54 , m_request(request) … … 67 67 private: 68 68 WebUserMediaRequest m_request; 69 WebMediaStream Descriptorm_result;69 WebMediaStream m_result; 70 70 }; 71 71 72 72 //////////////////////////////// 73 73 74 class MockExtraData : public WebMediaStream Descriptor::ExtraData {74 class MockExtraData : public WebMediaStream::ExtraData { 75 75 public: 76 76 int foo; … … 88 88 89 89 if (request.ownerDocument().isNull() || !request.ownerDocument().frame()) { 90 postTask(new UserMediaRequestTask(this, request, WebMediaStream Descriptor()));90 postTask(new UserMediaRequestTask(this, request, WebMediaStream())); 91 91 return; 92 92 } … … 94 94 WebMediaConstraints constraints = request.audioConstraints(); 95 95 if (!constraints.isNull() && !MockConstraints::verifyConstraints(constraints)) { 96 postTask(new UserMediaRequestTask(this, request, WebMediaStream Descriptor()));96 postTask(new UserMediaRequestTask(this, request, WebMediaStream())); 97 97 return; 98 98 } 99 99 constraints = request.videoConstraints(); 100 100 if (!constraints.isNull() && !MockConstraints::verifyConstraints(constraints)) { 101 postTask(new UserMediaRequestTask(this, request, WebMediaStream Descriptor()));101 postTask(new UserMediaRequestTask(this, request, WebMediaStream())); 102 102 return; 103 103 } … … 114 114 videoSources[0].initialize("MockVideoDevice#1", WebMediaStreamSource::TypeVideo, "Mock video device"); 115 115 116 WebMediaStream Descriptorstream;116 WebMediaStream stream; 117 117 stream.initialize("foobar", audioSources, videoSources); 118 118
Note: See TracChangeset
for help on using the changeset viewer.