Changeset 141492 in webkit

Timestamp:

Jan 31, 2013 3:12:05 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

CSS3's vh attribute is not adjusting while browser resizes
​https://bugs.webkit.org/show_bug.cgi?id=86418

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-01-31
Reviewed by Antti Koivisto.

Source/WebCore:

Elements with viewport percentage units needs layout whenever
viewport size changes. Check for viewport percentage unit
was missing for height.

Test: css3/viewport-percentage-lengths/vh-resize.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::hasViewportPercentageLogicalHeight): Check if style
is specified in viewport percentage units.
(WebCore):

• rendering/RenderBox.h:

(RenderBox):

• rendering/RenderView.cpp:

(WebCore::RenderView::layout): Elements with viewport percentage units
needs relayout when viewport size changes.

LayoutTests:

Added test to check element with vh units gets resized when
viewport height is increased or decreased.

• css3/viewport-percentage-lengths/vh-resize-expected.html: Added.
• css3/viewport-percentage-lengths/vh-resize.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/viewport-percentage-lengths/vh-resize-expected.html (added)
• LayoutTests/css3/viewport-percentage-lengths/vh-resize.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlock.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.h (modified) (1 diff)
• Source/WebCore/rendering/RenderView.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-31  Uday Kiran  <udaykiran@motorola.com>
+
+        CSS3's vh attribute is not adjusting while browser resizes
+        https://bugs.webkit.org/show_bug.cgi?id=86418
+
+        Reviewed by Antti Koivisto.
+
+        Added test to check element with vh units gets resized when
+        viewport height is increased or decreased.
+
+        * css3/viewport-percentage-lengths/vh-resize-expected.html: Added.
+        * css3/viewport-percentage-lengths/vh-resize.html: Added.
+
 2013-01-31  Jessie Berlin  <jberlin@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-31  Uday Kiran  <udaykiran@motorola.com>
+
+        CSS3's vh attribute is not adjusting while browser resizes
+        https://bugs.webkit.org/show_bug.cgi?id=86418
+
+        Reviewed by Antti Koivisto.
+
+        Elements with viewport percentage units needs layout whenever
+        viewport size changes. Check for viewport percentage unit
+        was missing for height.
+
+        Test: css3/viewport-percentage-lengths/vh-resize.html
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::hasViewportPercentageLogicalHeight): Check if style
+        is specified in viewport percentage units.
+        (WebCore):
+        * rendering/RenderBox.h:
+        (RenderBox):
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::layout): Elements with viewport percentage units
+        needs relayout when viewport size changes.
+
 2013-01-31  Anton Vayvod  <avayvod@chromium.org>
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -2335 +2335 @@
     // FIXME: Technically percentage height objects only need a relayout if their percentage isn't going to be turned into
     // an auto value. Add a method to determine this, so that we can avoid the relayout.
-    if (relayoutChildren || (child->hasRelativeLogicalHeight() && !isRenderView()))
+    if (relayoutChildren || (child->hasRelativeLogicalHeight() && !isRenderView()) || child->hasViewportPercentageLogicalHeight())
         child->setChildNeedsLayout(true, MarkOnlyThis);
 

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -4403 +4403 @@
 }
 
+bool RenderBox::hasViewportPercentageLogicalHeight() const
+{
+    return style()->logicalHeight().isViewportPercentage()
+        || style()->logicalMinHeight().isViewportPercentage()
+        || style()->logicalMaxHeight().isViewportPercentage();
+}
+
 static void markBoxForRelayoutAfterSplit(RenderBox* box)
 {

trunk/Source/WebCore/rendering/RenderBox.h

@@ -548 +548 @@
     virtual bool hasRelativeDimensions() const;
     virtual bool hasRelativeLogicalHeight() const;
+    virtual bool hasViewportPercentageLogicalHeight() const;
 
     bool hasHorizontalLayoutOverflow() const

trunk/Source/WebCore/rendering/RenderView.cpp

@@ -188 +188 @@
         setChildNeedsLayout(true, MarkOnlyThis);
         for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
-            if ((child->isBox() && toRenderBox(child)->hasRelativeLogicalHeight())
+            if ((child->isBox() && (toRenderBox(child)->hasRelativeLogicalHeight() || toRenderBox(child)->hasViewportPercentageLogicalHeight()))
                     || child->style()->logicalHeight().isPercent()
                     || child->style()->logicalMinHeight().isPercent()
-                    || child->style()->logicalMaxHeight().isPercent())
+                    || child->style()->logicalMaxHeight().isPercent()
+                    || child->style()->logicalHeight().isViewportPercentage()
+                    || child->style()->logicalMinHeight().isViewportPercentage()
+                    || child->style()->logicalMaxHeight().isViewportPercentage())
                 child->setChildNeedsLayout(true, MarkOnlyThis);
         }