Changeset 141503 in webkit

Timestamp:

Jan 31, 2013 4:37:22 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
​https://bugs.webkit.org/show_bug.cgi?id=108200

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2013-01-31
Reviewed by Martin Robinson.

Source/WebCore:

Getting the Position of a PseudoElement now triggers an assertion.
This can occur when clicking on empty space in a render block.
Looking to the unignored parent's node (and passing that accessible
object on in a signal to Assistive Technologies) seems like the most
reasonable thing to do here.

No new tests; instead skipping two tests that were crashing as a result.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(objectFocusedAndCaretOffsetUnignored):

LayoutTests:

Unskip two crashing tests having fixed the underlying bug.

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-31  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
+        https://bugs.webkit.org/show_bug.cgi?id=108200
+
+        Reviewed by Martin Robinson.
+
+        Unskip two crashing tests having fixed the underlying bug.
+
+        * platform/gtk/TestExpectations:
+
 2013-01-31  Ojan Vafai  <ojan@chromium.org>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -519 +519 @@
 webkit.org/b/107377 storage/indexeddb/objectstore-basics.html [ Crash Pass ]
 webkit.org/b/107194 storage/indexeddb/objectstore-basics-workers.html [ Crash Failure ]
-
-webkit.org/b/108200 fast/css-generated-content/block-and-box-hit-testing.html [ Crash Pass ]
-webkit.org/b/108200 fast/css/relative-positioned-block-crash.html [ Crash Pass ]
 
 webkit.org/b/108365 http/tests/security/inactive-document-with-empty-security-origin.html [ Crash ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-31  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
+        https://bugs.webkit.org/show_bug.cgi?id=108200
+
+        Reviewed by Martin Robinson.
+
+        Getting the Position of a PseudoElement now triggers an assertion.
+        This can occur when clicking on empty space in a render block.
+        Looking to the unignored parent's node (and passing that accessible
+        object on in a signal to Assistive Technologies) seems like the most
+        reasonable thing to do here.
+
+        No new tests; instead skipping two tests that were crashing as a result.
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+        (objectFocusedAndCaretOffsetUnignored):
+
 2013-01-31  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

@@ -1094 +1094 @@
             startNode = axFirstChild->node();
     }
-    if (!startNode)
+    // Getting the Position of a PseudoElement now triggers an assertion.
+    // This can occur when clicking on empty space in a render block.
+    if (!startNode || startNode->isPseudoElement())
         startNode = firstUnignoredParent->node();