Changeset 141518 in webkit


Ignore:
Timestamp:
Jan 31, 2013 5:57:36 PM (11 years ago)
Author:
haraken@chromium.org
Message:

Unreviewed, rolling out r141502.
​http://trac.webkit.org/changeset/141502
​https://bugs.webkit.org/show_bug.cgi?id=108441

Hit assert in SVGElementInstance

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):

  • dom/EventTarget.idl:
  • svg/SVGElementInstance.idl:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r141517 r141518  
     12013-01-31  Kentaro Hara  <haraken@chromium.org>
     2
     3        Unreviewed, rolling out r141502.
     4        http://trac.webkit.org/changeset/141502
     5        https://bugs.webkit.org/show_bug.cgi?id=108441
     6
     7        Hit assert in SVGElementInstance
     8
     9        * bindings/scripts/CodeGeneratorV8.pm:
     10        (GetInternalFields):
     11        * dom/EventTarget.idl:
     12        * svg/SVGElementInstance.idl:
     13
    1142013-01-31  Ojan Vafai  <ojan@chromium.org>
    215

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r141511 r141518  
    617617
    618618    my @customInternalFields = ();
     619    # We can't ask whether a parent type has a given extendedAttribute,
     620    # so special-case AbstractWorker and WorkerContext to include all sub-types.
    619621    # Event listeners on DOM nodes are explicitly supported in the GC controller.
    620     if (!$codeGenerator->InheritsInterface($interface, "Node") &&
    621         $codeGenerator->InheritsExtendedAttribute($interface, "EventTarget")) {
     622    # FIXME: Simplify this when all EventTargets are subtypes of EventTarget.
     623    if (!$codeGenerator->InheritsInterface($interface, "Node")
     624        && ($interface->extendedAttributes->{"EventTarget"}
     625            || $interface->extendedAttributes->{"IsWorkerContext"}
     626            || $codeGenerator->InheritsInterface($interface, "AbstractWorker")
     627            || $codeGenerator->InheritsInterface($interface, "EventTarget"))) {
    622628        push(@customInternalFields, "eventListenerCacheIndex");
    623629    }
     630
    624631    return @customInternalFields;
    625632}

  • trunk/Source/WebCore/dom/EventTarget.idl

    r141502 r141518  
    2626    CustomToJSObject,
    2727    JSCustomToNativeObject,
    28     V8NoWrapperCache,
    29     EventTarget
     28    V8NoWrapperCache
    3029] interface EventTarget {
    3130    [ObjCLegacyUnnamedParameters] void addEventListener(in DOMString type,

  • trunk/Source/WebCore/svg/SVGElementInstance.idl

    r141502 r141518  
    2929    JSCustomMarkFunction,
    3030    JSGenerateToNativeObject,
    31     JSGenerateToJSObject,
    32     EventTarget
     31    JSGenerateToJSObject
    3332] interface SVGElementInstance
    3433#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
Note: See TracChangeset for help on using the changeset viewer.