Changeset 141520 in webkit

Timestamp:

Jan 31, 2013 6:41:27 PM (11 years ago)

Author:

hayato@chromium.org

Message:

Use TouchEvent.targetTouches rather than TouchEvent.touches since the order of Touches in TouchList is not guaranteed.
​https://bugs.webkit.org/show_bug.cgi?id=108426

Reviewed by Dimitri Glazkov.

Neat fix for LayoutTest in ​http://trac.webkit.org/changeset/141054.

In this LayoutTest context, the length of touchEvent.touches is 2.
The Touch order in TouchList is not guaranteed. Therefore
touchEvent.touches[0] can be another touch. Rather, we should use
touchEvent.targetTouches here since its length is 1 in this context.

• fast/dom/shadow/touch-event.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/dom/shadow/touch-event.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-31  Hayato Ito  <hayato@chromium.org>
+
+        Use TouchEvent.targetTouches rather than TouchEvent.touches since the order of Touches in TouchList is not guaranteed.
+        https://bugs.webkit.org/show_bug.cgi?id=108426
+
+        Reviewed by Dimitri Glazkov.
+
+        Neat fix for LayoutTest in http://trac.webkit.org/changeset/141054.
+
+        In this LayoutTest context, the length of touchEvent.touches is 2.
+        The Touch order in TouchList is not guaranteed. Therefore
+        touchEvent.touches[0] can be another touch.  Rather, we should use
+        touchEvent.targetTouches here since its length is 1 in this context.
+
+        * fast/dom/shadow/touch-event.html:
+
 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
 

trunk/LayoutTests/fast/dom/shadow/touch-event.html

@@ -24 +24 @@
 var touchTargetsForHost1;
 host1.addEventListener('touchstart', function(e) {
-    touchTargetForHost1 = e.touches[0].target;
+    touchTargetForHost1 = e.targetTouches[0].target;
 });
 
@@ -34 +34 @@
 var touchTargetForInput1;
 input1.addEventListener('touchstart', function(e) {
-    touchTargetForInput1 = e.touches[1].target;
+    touchTargetForInput1 = e.targetTouches[0].target;
 });