Changeset 141528 in webkit

Timestamp:

Jan 31, 2013 7:52:13 PM (11 years ago)

Author:

rafael.lobo@openbossa.org

Message:

[Qt][WK2] Another attempt to fix build after recent WebKit2 changes
​https://bugs.webkit.org/show_bug.cgi?id=108548

Reviewed by Anders Carlsson.

• Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::processMessage): Change Deque to Vector and do similar
logic as on patch for ​https://bugs.webkit.org/show_bug.cgi?id=108517
(CoreIPC::Connection::open):
(CoreIPC::Connection::setShouldCloseConnectionOnProcessTermination):

• Platform/qt/WorkQueueQt.cpp: Reflect changes on Qt WorkQueue to increase ref

count when the execution is started and decrease it when the work item is deleted,
following the logic on ​https://bugs.webkit.org/show_bug.cgi?id=108544
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath): This function was moved from WebProcessProxy but
mac specific code was not protected properly: ​https://bugs.webkit.org/show_bug.cgi?id=108407

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/unix/ConnectionUnix.cpp (modified) (8 diffs)
• Platform/qt/WorkQueueQt.cpp (modified) (3 diffs)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-01-31  Rafael Brandao  <rafael.lobo@openbossa.org>
+
+        [Qt][WK2] Another attempt to fix build after recent WebKit2 changes
+        https://bugs.webkit.org/show_bug.cgi?id=108548
+
+        Reviewed by Anders Carlsson.
+
+        * Platform/CoreIPC/unix/ConnectionUnix.cpp:
+        (CoreIPC::Connection::platformInvalidate):
+        (CoreIPC::Connection::processMessage): Change Deque to Vector and do similar
+        logic as on patch for https://bugs.webkit.org/show_bug.cgi?id=108517
+        (CoreIPC::Connection::open):
+        (CoreIPC::Connection::setShouldCloseConnectionOnProcessTermination):
+        * Platform/qt/WorkQueueQt.cpp: Reflect changes on Qt WorkQueue to increase ref
+        count when the execution is started and decrease it when the work item is deleted,
+        following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544
+        (WorkQueue::WorkItemQt::~WorkItemQt):
+        (WorkQueue::WorkItemQt::execute):
+        (WorkQueue::dispatch):
+        (WorkQueue::dispatchAfterDelay):
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::getPluginPath): This function was moved from WebProcessProxy but
+        mac specific code was not protected properly: https://bugs.webkit.org/show_bug.cgi?id=108407
+
 2013-01-31  Changhun Kang  <temoochin@company100.net>
 

trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp

@@ -141 +141 @@
 
 #if PLATFORM(GTK)
-    m_connectionQueue.unregisterEventSourceHandler(m_socketDescriptor);
+    m_connectionQueue->unregisterEventSourceHandler(m_socketDescriptor);
 #endif
 
@@ -150 +150 @@
 
 #if PLATFORM(EFL)
-    m_connectionQueue.unregisterSocketEventHandler(m_socketDescriptor);
+    m_connectionQueue->unregisterSocketEventHandler(m_socketDescriptor);
 #endif
 
@@ -208 +208 @@
         return false;
 
-    Deque<Attachment> attachments;
-    AttachmentResourceGuard<Deque<Attachment>, Deque<Attachment>::iterator> attachementDisposer(attachments);
-    RefPtr<WebKit::SharedMemory> oolMessageBody;
-
     size_t attachmentFileDescriptorCount = 0;
     size_t attachmentCount = messageInfo.attachmentCount();
+    OwnArrayPtr<AttachmentInfo> attachmentInfo;
+
     if (attachmentCount) {
-        OwnArrayPtr<AttachmentInfo> attachmentInfo = adoptArrayPtr(new AttachmentInfo[attachmentCount]);
+        attachmentInfo = adoptArrayPtr(new AttachmentInfo[attachmentCount]);
         memcpy(attachmentInfo.get(), messageData, sizeof(AttachmentInfo) * attachmentCount);
         messageData += sizeof(AttachmentInfo) * attachmentCount;
@@ -227 +225 @@
             case Attachment::Uninitialized:
             default:
+                ASSERT_NOT_REACHED();
                 break;
             }
@@ -233 +232 @@
         if (messageInfo.isMessageBodyIsOutOfLine())
             attachmentCount--;
-
+    }
+
+    Vector<Attachment> attachments(attachmentCount);
+    AttachmentResourceGuard<Vector<Attachment>, Vector<Attachment>::iterator> attachementDisposer(attachments);
+    RefPtr<WebKit::SharedMemory> oolMessageBody;
+
+    if (attachmentCount) {
         size_t fdIndex = 0;
         for (size_t i = 0; i < attachmentCount; ++i) {
@@ -241 +246 @@
                 if (!attachmentInfo[i].isNull())
                     fd = m_fileDescriptors[fdIndex++];
-                attachments.append(Attachment(fd, attachmentInfo[i].getSize()));
+                attachments[attachmentCount - i - 1] = Attachment(fd, attachmentInfo[i].getSize());
                 break;
             case Attachment::SocketType:
                 if (!attachmentInfo[i].isNull())
                     fd = m_fileDescriptors[fdIndex++];
-                attachments.append(Attachment(fd));
+                attachments[attachmentCount - i - 1] = Attachment(fd);
                 break;
             case Attachment::Uninitialized:
-                attachments.append(Attachment());
+                attachments[attachmentCount - i - 1] = Attachment();
             default:
                 break;
@@ -419 +424 @@
     m_isConnected = true;
 #if PLATFORM(QT)
-    m_socketNotifier = m_connectionQueue.registerSocketEventHandler(m_socketDescriptor, QSocketNotifier::Read, WTF::bind(&Connection::readyReadHandler, this));
+    m_socketNotifier = m_connectionQueue->registerSocketEventHandler(m_socketDescriptor, QSocketNotifier::Read, WTF::bind(&Connection::readyReadHandler, this));
 #elif PLATFORM(GTK)
-    m_connectionQueue.registerEventSourceHandler(m_socketDescriptor, (G_IO_HUP | G_IO_ERR), WTF::bind(&Connection::connectionDidClose, this));
-    m_connectionQueue.registerEventSourceHandler(m_socketDescriptor, G_IO_IN, WTF::bind(&Connection::readyReadHandler, this));
+    m_connectionQueue->registerEventSourceHandler(m_socketDescriptor, (G_IO_HUP | G_IO_ERR), WTF::bind(&Connection::connectionDidClose, this));
+    m_connectionQueue->registerEventSourceHandler(m_socketDescriptor, G_IO_IN, WTF::bind(&Connection::readyReadHandler, this));
 #elif PLATFORM(EFL)
-    m_connectionQueue.registerSocketEventHandler(m_socketDescriptor, WTF::bind(&Connection::readyReadHandler, this));
+    m_connectionQueue->registerSocketEventHandler(m_socketDescriptor, WTF::bind(&Connection::readyReadHandler, this));
 #endif
 
     // Schedule a call to readyReadHandler. Data may have arrived before installation of the signal
     // handler.
-    m_connectionQueue.dispatch(WTF::bind(&Connection::readyReadHandler, this));
+    m_connectionQueue->dispatch(WTF::bind(&Connection::readyReadHandler, this));
 
     return true;
@@ -557 +562 @@
 void Connection::setShouldCloseConnectionOnProcessTermination(WebKit::PlatformProcessIdentifier process)
 {
-    m_connectionQueue.dispatchOnTermination(process, WTF::bind(&Connection::connectionDidClose, this));
+    m_connectionQueue->dispatchOnTermination(process, WTF::bind(&Connection::connectionDidClose, this));
 }
 #endif

trunk/Source/WebKit2/Platform/qt/WorkQueueQt.cpp

@@ -56 +56 @@
     ~WorkItemQt()
     {
+        m_queue->deref();
     }
 
     Q_SLOT void execute() 
     { 
-        if (m_queue->m_isValid)
-            m_function();
+        m_function();
     }
 
@@ -109 +109 @@
 void WorkQueue::dispatch(const Function<void()>& function)
 {
+    ref();
     WorkQueue::WorkItemQt* itemQt = new WorkQueue::WorkItemQt(this, function);
     itemQt->moveToThread(m_workThread);
@@ -116 +117 @@
 void WorkQueue::dispatchAfterDelay(const Function<void()>& function, double delayInSecond)
 {
+    ref();
     WorkQueue::WorkItemQt* itemQt = new WorkQueue::WorkItemQt(this, function);
     itemQt->startTimer(static_cast<int>(delayInSecond * 1000));

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -1237 +1237 @@
         return;
 
+#if PLATFORM(MAC)
     pluginLoadPolicy = m_uiClient.shouldInstantiatePlugin(this, plugin.bundleIdentifier, plugin.info.name) ? PluginModuleLoadNormally : PluginModuleBlocked;
     if (pluginLoadPolicy != PluginModuleLoadNormally)
         return;
+#endif
 
     pluginPath = plugin.path;