Changeset 141533 in webkit


Ignore:
Timestamp:
Jan 31, 2013 8:25:42 PM (11 years ago)
Author:
tkent@chromium.org
Message:

Refactoring: Remove the default argument value for Node::setFocus
https://bugs.webkit.org/show_bug.cgi?id=108554

Reviewed by Kentaro Hara.

There is no code to use the default argument.
No new tests. Just a refactoring.

  • dom/Node.h: Remove default argument value for setFocus.
  • dom/ContainerNode.h:

(ContainerNode): Ditto.

  • html/HTMLAreaElement.h:

(HTMLAreaElement): Add OVERRIDE to setFocus.

  • html/HTMLFrameElementBase.h:

(HTMLFrameElementBase): Ditto.

Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r141531 r141533  
     12013-01-31  Kent Tamura  <tkent@chromium.org>
     2
     3        Refactoring: Remove the default argument value for Node::setFocus
     4        https://bugs.webkit.org/show_bug.cgi?id=108554
     5
     6        Reviewed by Kentaro Hara.
     7
     8        There is no code to use the default argument.
     9        No new tests. Just a refactoring.
     10
     11        * dom/Node.h: Remove default argument value for setFocus.
     12        * dom/ContainerNode.h:
     13        (ContainerNode): Ditto.
     14        * html/HTMLAreaElement.h:
     15        (HTMLAreaElement): Add OVERRIDE to setFocus.
     16        * html/HTMLFrameElementBase.h:
     17        (HTMLFrameElementBase): Ditto.
     18
    1192013-01-31  Victor Carbune  <vcarbune@chromium.org>
    220
  • trunk/Source/WebCore/dom/ContainerNode.h

    r141524 r141533  
    110110    virtual void detach() OVERRIDE;
    111111    virtual LayoutRect boundingBox() const OVERRIDE;
    112     virtual void setFocus(bool = true) OVERRIDE;
     112    virtual void setFocus(bool) OVERRIDE;
    113113    virtual void setActive(bool active = true, bool pause = false) OVERRIDE;
    114114    virtual void setHovered(bool = true) OVERRIDE;
  • trunk/Source/WebCore/dom/Node.h

    r141524 r141533  
    390390    void lazyReattach(ShouldSetAttached = SetAttached);
    391391
    392     virtual void setFocus(bool flag = true);
     392    virtual void setFocus(bool flag);
    393393    virtual void setActive(bool flag = true, bool pause = false);
    394394    virtual void setHovered(bool flag = true);
  • trunk/Source/WebCore/html/HTMLAreaElement.h

    r135069 r141533  
    5858    virtual bool isFocusable() const;
    5959    virtual void updateFocusAppearance(bool /*restorePreviousSelection*/);
    60     virtual void setFocus(bool);
     60    virtual void setFocus(bool) OVERRIDE;
    6161
    6262#if ENABLE(MICRODATA)
  • trunk/Source/WebCore/html/HTMLFrameElementBase.h

    r141277 r141533  
    5757private:
    5858    virtual bool supportsFocus() const;
    59     virtual void setFocus(bool);
     59    virtual void setFocus(bool) OVERRIDE;
    6060   
    6161    virtual bool isURLAttribute(const Attribute&) const OVERRIDE;
Note: See TracChangeset for help on using the changeset viewer.