Changeset 141539 in webkit

Timestamp:

Jan 31, 2013 10:52:09 PM (11 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: Native Memory Instrumentation: replace nodeName argument with className
​https://bugs.webkit.org/show_bug.cgi?id=107278

Reviewed by Yury Semikhatsky.

I replaced nodeName with className because we newer report node name for private and raw buffers
but need to report their class names.

• wtf/MemoryInstrumentation.cpp:

(WTF::MemoryInstrumentation::reportLinkToBuffer):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):

• wtf/MemoryInstrumentation.h:

(WTF::MemoryInstrumentation::addRawBuffer):
(MemoryClassInfo):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/MemoryInstrumentation.cpp (modified) (3 diffs)
• wtf/MemoryInstrumentation.h (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-01-31  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: Native Memory Instrumentation: replace nodeName argument with className
+        https://bugs.webkit.org/show_bug.cgi?id=107278
+
+        Reviewed by Yury Semikhatsky.
+
+        I replaced nodeName with className because we newer report node name for private and raw buffers
+        but need to report their class names.
+
+        * wtf/MemoryInstrumentation.cpp:
+        (WTF::MemoryInstrumentation::reportLinkToBuffer):
+        (WTF::MemoryClassInfo::addRawBuffer):
+        (WTF::MemoryClassInfo::addPrivateBuffer):
+        * wtf/MemoryInstrumentation.h:
+        (WTF::MemoryInstrumentation::addRawBuffer):
+        (MemoryClassInfo):
+
 2013-01-31  Jessie Berlin  <jberlin@apple.com>
 

trunk/Source/WTF/wtf/MemoryInstrumentation.cpp

@@ -65 +65 @@
 }
 
-void MemoryInstrumentation::reportLinkToBuffer(const void* buffer, MemoryObjectType ownerObjectType, size_t size, const char* nodeName, const char* edgeName)
+void MemoryInstrumentation::reportLinkToBuffer(const void* buffer, MemoryObjectType ownerObjectType, size_t size, const char* className, const char* edgeName)
 {
     MemoryObjectInfo memoryObjectInfo(this, ownerObjectType, 0);
     memoryObjectInfo.reportObjectInfo(buffer, ownerObjectType, size);
-    memoryObjectInfo.setName(nodeName);
+    memoryObjectInfo.setClassName(className);
     m_client->reportLeaf(memoryObjectInfo, edgeName);
 }
@@ -130 +130 @@
 }
 
-void MemoryClassInfo::addRawBuffer(const void* buffer, size_t size, const char* nodeName, const char* edgeName)
+void MemoryClassInfo::addRawBuffer(const void* buffer, size_t size, const char* className, const char* edgeName)
 {
     if (!m_skipMembers)
-        m_memoryInstrumentation->addRawBuffer(buffer, m_objectType, size, nodeName, edgeName);
+        m_memoryInstrumentation->addRawBuffer(buffer, m_objectType, size, className, edgeName);
 }
 
-void MemoryClassInfo::addPrivateBuffer(size_t size, MemoryObjectType ownerObjectType, const char* nodeName, const char* edgeName)
+void MemoryClassInfo::addPrivateBuffer(size_t size, MemoryObjectType ownerObjectType, const char* className, const char* edgeName)
 {
     if (!size)
@@ -145 +145 @@
         ownerObjectType = m_objectType;
     m_memoryInstrumentation->countObjectSize(0, ownerObjectType, size);
-    m_memoryInstrumentation->reportLinkToBuffer(0, ownerObjectType, size, nodeName, edgeName);
+    m_memoryInstrumentation->reportLinkToBuffer(0, ownerObjectType, size, className, edgeName);
 }
 

trunk/Source/WTF/wtf/MemoryInstrumentation.h

@@ -170 +170 @@
 
     template<typename T> void addObject(const T& t, MemoryObjectInfo* ownerObjectInfo, const char* edgeName) { MemberTypeTraits<T>::addObject(this, t, ownerObjectInfo, edgeName); }
-    void addRawBuffer(const void* buffer, MemoryObjectType ownerObjectType, size_t size, const char* nodeName = 0, const char* edgeName = 0)
+    void addRawBuffer(const void* buffer, MemoryObjectType ownerObjectType, size_t size, const char* className = 0, const char* edgeName = 0)
     {
         if (!buffer || visited(buffer))
             return;
         countObjectSize(buffer, ownerObjectType, size);
-        reportLinkToBuffer(buffer, ownerObjectType, size, nodeName, edgeName);
+        reportLinkToBuffer(buffer, ownerObjectType, size, className, edgeName);
     }
     WTF_EXPORT_PRIVATE void reportLinkToBuffer(const void* buffer, MemoryObjectType ownerObjectType, size_t, const char* nodeName, const char* edgeName);
@@ -245 +245 @@
     }
 
-    WTF_EXPORT_PRIVATE void addRawBuffer(const void* buffer, size_t, const char* nodeName = 0, const char* edgeName = 0);
-    WTF_EXPORT_PRIVATE void addPrivateBuffer(size_t, MemoryObjectType ownerObjectType = 0, const char* nodeName = 0, const char* edgeName = 0);
+    WTF_EXPORT_PRIVATE void addRawBuffer(const void* buffer, size_t, const char* className = 0, const char* edgeName = 0);
+    WTF_EXPORT_PRIVATE void addPrivateBuffer(size_t, MemoryObjectType ownerObjectType = 0, const char* className = 0, const char* edgeName = 0);
     WTF_EXPORT_PRIVATE void setCustomAllocation(bool);