Changeset 141547 in webkit

Timestamp:

Feb 1, 2013 12:19:35 AM (11 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible
​https://bugs.webkit.org/show_bug.cgi?id=108575

Reviewed by Yury Semikhatsky.

Source/WebCore:

• inspector/front-end/FileMapping.js:

(WebInspector.FileMapping.prototype._entryMatchesURL):
(WebInspector.FileMapping.prototype.urlForURI):

• inspector/front-end/FileSystemMapping.js:

(get WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(get WebInspector.FileSystemMappingImpl.prototype.uriForPath):

LayoutTests:

• http/tests/inspector/console-cd-completions.html:
• http/tests/inspector/console-cd.html:
• http/tests/inspector/indexeddb/indexeddb-test.js:

(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):

• inspector/network-status-non-http.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/inspector/console-cd-completions.html (modified) (1 diff)
• LayoutTests/http/tests/inspector/console-cd.html (modified) (1 diff)
• LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js (modified) (1 diff)
• LayoutTests/inspector/network-status-non-http.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/FileMapping.js (modified) (2 diffs)
• Source/WebCore/inspector/front-end/FileSystemMapping.js (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-01  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible
+        https://bugs.webkit.org/show_bug.cgi?id=108575
+
+        Reviewed by Yury Semikhatsky.
+
+        * http/tests/inspector/console-cd-completions.html:
+        * http/tests/inspector/console-cd.html:
+        * http/tests/inspector/indexeddb/indexeddb-test.js:
+        (initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
+        (initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):
+        * inspector/network-status-non-http.html:
+
 2013-01-31  Aurimas Liutikas  <aurimas@chromium.org>
 

trunk/LayoutTests/http/tests/inspector/console-cd-completions.html

@@ -11 +11 @@
     var option = selector.firstChild;
     while (option) {
-        if (option.textContent && option.textContent.indexOf("myIFrame") === 0)
+        if (option.textContent && option.textContent.startsWith("myIFrame"))
             break;
         option = option.nextSibling;

trunk/LayoutTests/http/tests/inspector/console-cd.html

@@ -12 +12 @@
     var option = selector.firstChild;
     while (option) {
-        if (option.textContent && option.textContent.indexOf("myIFrame") === 0)
+        if (option.textContent && option.textContent.startsWith("myIFrame"))
             break;
         option = option.nextSibling;

trunk/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js

@@ -54 +54 @@
     {
         var text = msg._messageText;
-        if (text.indexOf(callbackIdPrefix) !== 0) {
+        if (!text.startsWith(callbackIdPrefix)) {
             InspectorTest.addConsoleSniffer(consoleMessageOverride, false);
             return;

trunk/LayoutTests/inspector/network-status-non-http.html

@@ -22 +22 @@
                 var outputStatus = status.stringValue;
                 // Truncate the status string on failure, since the description following "(failed)" is platform-dependent.
-                if (outputStatus.indexOf("(failed)") == 0)
+                if (outputStatus.startsWith("(failed)"))
                     outputStatus = "(failed)";
                 outputStrings.push(urlFragment + ": " + outputStatus);

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-01  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible
+        https://bugs.webkit.org/show_bug.cgi?id=108575
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/FileMapping.js:
+        (WebInspector.FileMapping.prototype._entryMatchesURL):
+        (WebInspector.FileMapping.prototype.urlForURI):
+        * inspector/front-end/FileSystemMapping.js:
+        (get WebInspector.FileSystemMappingImpl.prototype.fileForURI):
+        (get WebInspector.FileSystemMappingImpl.prototype.uriForPath):
+
 2013-01-31  Aurimas Liutikas  <aurimas@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/FileMapping.js

@@ -50 +50 @@
     _entryMatchesURL: function(entry, url)
     {
-        return url.indexOf(entry.urlPrefix) === 0;
+        return url.startsWith(entry.urlPrefix);
     },
     
@@ -105 +105 @@
             var entry = this._entries[i];
             var uriPrefix = this._entryURIPrefix(entry);
-            if (uriPrefix && uri.indexOf(uriPrefix) === 0)
+            if (uriPrefix && uri.startsWith(uriPrefix))
                 return entry.urlPrefix + uri.substring(uriPrefix.length);
         }

trunk/Source/WebCore/inspector/front-end/FileSystemMapping.js

@@ -165 +165 @@
         for (var fileSystemPath in this._mappedNames) {
             var uriPrefix = this._uriPrefixForMappedName(this._mappedNames[fileSystemPath]);
-            if (uri.indexOf(uriPrefix) === 0)
+            if (uri.startsWith(uriPrefix))
                 return new WebInspector.FileSystemMapping.FileDescriptor(fileSystemPath, "/" + uri.substring(uriPrefix.length));
         }
@@ -188 +188 @@
     {
         for (var fileSystemPath in this._mappedNames) {
-            if (path.indexOf(fileSystemPath) === 0) {
+            if (path.startsWith(fileSystemPath)) {
                 var uriPrefix = this._uriPrefixForMappedName(this._mappedNames[fileSystemPath]);
                 var subPath = path.substring(fileSystemPath.length);