Changeset 141553 in webkit


Ignore:
Timestamp:
Feb 1, 2013 12:45:57 AM (11 years ago)
Author:
haraken@chromium.org
Message:

[V8] Add a temporary optional Isolate parameter to HasInstance()
​https://bugs.webkit.org/show_bug.cgi?id=108567

Reviewed by Adam Barth.

The optional Isolate parameter will be removed once all call sites have an Isolate.
It will require several patches.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructorCallback):
(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

Location:
trunk/Source/WebCore
Files:
28 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r141551 r141553  
     12013-01-31  Kentaro Hara  <haraken@chromium.org>
     2
     3        [V8] Add a temporary optional Isolate parameter to HasInstance()
     4        https://bugs.webkit.org/show_bug.cgi?id=108567
     5
     6        Reviewed by Adam Barth.
     7
     8        The optional Isolate parameter will be removed once all call sites have an Isolate.
     9        It will require several patches.
     10
     11        No tests. No change in behavior.
     12
     13        * bindings/scripts/CodeGeneratorV8.pm:
     14        (GenerateHeader):
     15        (GenerateNormalAttrSetter):
     16        (GenerateParametersCheckExpression):
     17        (GenerateParametersCheck):
     18        (GenerateImplementation):
     19        * bindings/scripts/test/V8/V8Float64Array.cpp:
     20        (WebCore::V8Float64Array::HasInstance):
     21        * bindings/scripts/test/V8/V8Float64Array.h:
     22        (V8Float64Array):
     23        * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
     24        (WebCore::V8TestActiveDOMObject::HasInstance):
     25        * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
     26        (V8TestActiveDOMObject):
     27        * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
     28        (WebCore::V8TestCustomNamedGetter::HasInstance):
     29        * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
     30        (V8TestCustomNamedGetter):
     31        * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
     32        (WebCore::V8TestEventConstructor::HasInstance):
     33        * bindings/scripts/test/V8/V8TestEventConstructor.h:
     34        (V8TestEventConstructor):
     35        * bindings/scripts/test/V8/V8TestEventTarget.cpp:
     36        (WebCore::V8TestEventTarget::HasInstance):
     37        * bindings/scripts/test/V8/V8TestEventTarget.h:
     38        (V8TestEventTarget):
     39        * bindings/scripts/test/V8/V8TestException.cpp:
     40        (WebCore::V8TestException::HasInstance):
     41        * bindings/scripts/test/V8/V8TestException.h:
     42        (V8TestException):
     43        * bindings/scripts/test/V8/V8TestInterface.cpp:
     44        (WebCore::V8TestInterface::HasInstance):
     45        * bindings/scripts/test/V8/V8TestInterface.h:
     46        (V8TestInterface):
     47        * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
     48        (WebCore::V8TestMediaQueryListListener::HasInstance):
     49        * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
     50        (V8TestMediaQueryListListener):
     51        * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
     52        (WebCore::V8TestNamedConstructor::HasInstance):
     53        * bindings/scripts/test/V8/V8TestNamedConstructor.h:
     54        (V8TestNamedConstructor):
     55        * bindings/scripts/test/V8/V8TestNode.cpp:
     56        (WebCore::V8TestNode::HasInstance):
     57        * bindings/scripts/test/V8/V8TestNode.h:
     58        (V8TestNode):
     59        * bindings/scripts/test/V8/V8TestObj.cpp:
     60        (WebCore::TestObjV8Internal::overloadedMethodCallback):
     61        (WebCore::TestObjV8Internal::variadicNodeMethodCallback):
     62        (WebCore::V8TestObj::HasInstance):
     63        * bindings/scripts/test/V8/V8TestObj.h:
     64        (V8TestObj):
     65        * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
     66        (WebCore::V8TestOverloadedConstructors::constructorCallback):
     67        (WebCore::V8TestOverloadedConstructors::HasInstance):
     68        * bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
     69        (V8TestOverloadedConstructors):
     70        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
     71        (WebCore::V8TestSerializedScriptValueInterface::HasInstance):
     72        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
     73        (V8TestSerializedScriptValueInterface):
     74
    1752013-02-01  Nils Barth  <nbarth@google.com>
    276

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r141518 r141553  
    354354
    355355    push(@headerContent, <<END);
    356     static bool HasInstance(v8::Handle<v8::Value>);
     356    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    357357    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    358358    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);
    … …  
    11761176        my $argType = $attribute->signature->type;
    11771177        if (IsWrapperType($argType)) {
    1178             push(@implContentDecls, "    if (!isUndefinedOrNull(value) && !V8${argType}::HasInstance(value)) {\n");
     1178            push(@implContentDecls, "    if (!isUndefinedOrNull(value) && !V8${argType}::HasInstance(value, info.GetIsolate())) {\n");
    11791179            push(@implContentDecls, "        throwTypeError(0, info.GetIsolate());\n");
    11801180            push(@implContentDecls, "        return;\n");
    … …  
    14271427        } elsif (IsWrapperType($type)) {
    14281428            if ($parameter->isNullable) {
    1429                 push(@andExpression, "(${value}->IsNull() || V8${type}::HasInstance($value))");
     1429                push(@andExpression, "(${value}->IsNull() || V8${type}::HasInstance($value, args.GetIsolate()))");
    14301430            } else {
    1431                 push(@andExpression, "(V8${type}::HasInstance($value))");
     1431                push(@andExpression, "(V8${type}::HasInstance($value, args.GetIsolate()))");
    14321432            }
    14331433        }
    … …  
    18041804                $parameterCheckString .= "    Vector<$nativeElementType> $parameterName;\n";
    18051805                $parameterCheckString .= "    for (int i = $paramIndex; i < args.Length(); ++i) {\n";
    1806                 $parameterCheckString .= "        if (!V8${argType}::HasInstance(args[i]))\n";
     1806                $parameterCheckString .= "        if (!V8${argType}::HasInstance(args[i], args.GetIsolate()))\n";
    18071807                $parameterCheckString .= "            return throwTypeError(0, args.GetIsolate());\n";
    18081808                $parameterCheckString .= "        $parameterName.append(V8${argType}::toNative(v8::Handle<v8::Object>::Cast(args[i])));\n";
    … …  
    18251825                my $argType = $parameter->type;
    18261826                if (IsWrapperType($argType)) {
    1827                     $parameterCheckString .= "    if (args.Length() > $paramIndex && !isUndefinedOrNull($argValue) && !V8${argType}::HasInstance($argValue))\n";
     1827                    $parameterCheckString .= "    if (args.Length() > $paramIndex && !isUndefinedOrNull($argValue) && !V8${argType}::HasInstance($argValue, args.GetIsolate()))\n";
    18281828                    $parameterCheckString .= "        return throwTypeError(0, args.GetIsolate());\n";
    18291829                }
    … …  
    31493149}
    31503150
    3151 bool ${v8InterfaceName}::HasInstance(v8::Handle<v8::Value> value)
    3152 {
    3153     return GetRawTemplate()->HasInstance(value);
     3151bool ${v8InterfaceName}::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
     3152{
     3153    return GetRawTemplate(isolate)->HasInstance(value);
    31543154}
    31553155

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp

    r141511 r141553  
    164164}
    165165
    166 bool V8Float64Array::HasInstance(v8::Handle<v8::Value> value)
     166bool V8Float64Array::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
    167167{
    168     return GetRawTemplate()->HasInstance(value);
     168    return GetRawTemplate(isolate)->HasInstance(value);
    169169}
    170170

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h

    r140616 r141553  
    3636public:
    3737    static const bool hasDependentLifetime = V8ArrayBufferView::hasDependentLifetime;
    38     static bool HasInstance(v8::Handle<v8::Value>);
     38    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    4040    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp

    r141511 r141553  
    192192}
    193193
    194 bool V8TestActiveDOMObject::HasInstance(v8::Handle<v8::Value> value)
    195 {
    196     return GetRawTemplate()->HasInstance(value);
     194bool V8TestActiveDOMObject::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
     195{
     196    return GetRawTemplate(isolate)->HasInstance(value);
    197197}
    198198

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h

    r140616 r141553  
    3535public:
    3636    static const bool hasDependentLifetime = false;
    37     static bool HasInstance(v8::Handle<v8::Value>);
     37    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3838    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp

    r141105 r141553  
    130130}
    131131
    132 bool V8TestCustomNamedGetter::HasInstance(v8::Handle<v8::Value> value)
     132bool V8TestCustomNamedGetter::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
    133133{
    134     return GetRawTemplate()->HasInstance(value);
     134    return GetRawTemplate(isolate)->HasInstance(value);
    135135}
    136136

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h

    r140616 r141553  
    3535public:
    3636    static const bool hasDependentLifetime = false;
    37     static bool HasInstance(v8::Handle<v8::Value>);
     37    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3838    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp

    r141105 r141553  
    162162}
    163163
    164 bool V8TestEventConstructor::HasInstance(v8::Handle<v8::Value> value)
     164bool V8TestEventConstructor::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
    165165{
    166     return GetRawTemplate()->HasInstance(value);
     166    return GetRawTemplate(isolate)->HasInstance(value);
    167167}
    168168

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h

    r140616 r141553  
    3636public:
    3737    static const bool hasDependentLifetime = false;
    38     static bool HasInstance(v8::Handle<v8::Value>);
     38    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    4040    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.cpp

    r141105 r141553  
    191191}
    192192
    193 bool V8TestEventTarget::HasInstance(v8::Handle<v8::Value> value)
    194 {
    195     return GetRawTemplate()->HasInstance(value);
     193bool V8TestEventTarget::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
     194{
     195    return GetRawTemplate(isolate)->HasInstance(value);
    196196}
    197197

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h

    r140657 r141553  
    3535public:
    3636    static const bool hasDependentLifetime = false;
    37     static bool HasInstance(v8::Handle<v8::Value>);
     37    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3838    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp

    r141105 r141553  
    121121}
    122122
    123 bool V8TestException::HasInstance(v8::Handle<v8::Value> value)
     123bool V8TestException::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
    124124{
    125     return GetRawTemplate()->HasInstance(value);
     125    return GetRawTemplate(isolate)->HasInstance(value);
    126126}
    127127

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h

    r140616 r141553  
    3535public:
    3636    static const bool hasDependentLifetime = false;
    37     static bool HasInstance(v8::Handle<v8::Value>);
     37    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3838    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp

    r141105 r141553  
    346346}
    347347
    348 bool V8TestInterface::HasInstance(v8::Handle<v8::Value> value)
    349 {
    350     return GetRawTemplate()->HasInstance(value);
     348bool V8TestInterface::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
     349{
     350    return GetRawTemplate(isolate)->HasInstance(value);
    351351}
    352352

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h

    r140616 r141553  
    3737public:
    3838    static const bool hasDependentLifetime = true;
    39     static bool HasInstance(v8::Handle<v8::Value>);
     39    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    4040    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    4141    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp

    r141105 r141553  
    130130}
    131131
    132 bool V8TestMediaQueryListListener::HasInstance(v8::Handle<v8::Value> value)
     132bool V8TestMediaQueryListListener::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
    133133{
    134     return GetRawTemplate()->HasInstance(value);
     134    return GetRawTemplate(isolate)->HasInstance(value);
    135135}
    136136

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h

    r140616 r141553  
    3535public:
    3636    static const bool hasDependentLifetime = false;
    37     static bool HasInstance(v8::Handle<v8::Value>);
     37    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3838    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp

    r141511 r141553  
    166166}
    167167
    168 bool V8TestNamedConstructor::HasInstance(v8::Handle<v8::Value> value)
    169 {
    170     return GetRawTemplate()->HasInstance(value);
     168bool V8TestNamedConstructor::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
     169{
     170    return GetRawTemplate(isolate)->HasInstance(value);
    171171}
    172172

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h

    r140616 r141553  
    4141public:
    4242    static const bool hasDependentLifetime = true;
    43     static bool HasInstance(v8::Handle<v8::Value>);
     43    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    4444    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    4545    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.cpp

    r141511 r141553  
    128128}
    129129
    130 bool V8TestNode::HasInstance(v8::Handle<v8::Value> value)
     130bool V8TestNode::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
    131131{
    132     return GetRawTemplate()->HasInstance(value);
     132    return GetRawTemplate(isolate)->HasInstance(value);
    133133}
    134134

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h

    r140657 r141553  
    3535public:
    3636    static const bool hasDependentLifetime = true;
    37     static bool HasInstance(v8::Handle<v8::Value>);
     37    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3838    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp

    r141360 r141553  
    15481548static v8::Handle<v8::Value> overloadedMethodCallback(const v8::Arguments& args)
    15491549{
    1550     if ((args.Length() == 2 && (args[0]->IsNull() || V8TestObj::HasInstance(args[0])) && (args[1]->IsNull() || args[1]->IsUndefined() || args[1]->IsString() || args[1]->IsObject())))
     1550    if ((args.Length() == 2 && (args[0]->IsNull() || V8TestObj::HasInstance(args[0], args.GetIsolate())) && (args[1]->IsNull() || args[1]->IsUndefined() || args[1]->IsString() || args[1]->IsObject())))
    15511551        return overloadedMethod1Callback(args);
    1552     if ((args.Length() == 1 && (args[0]->IsNull() || V8TestObj::HasInstance(args[0]))) || (args.Length() == 2 && (args[0]->IsNull() || V8TestObj::HasInstance(args[0]))))
     1552    if ((args.Length() == 1 && (args[0]->IsNull() || V8TestObj::HasInstance(args[0], args.GetIsolate()))) || (args.Length() == 2 && (args[0]->IsNull() || V8TestObj::HasInstance(args[0], args.GetIsolate()))))
    15531553        return overloadedMethod2Callback(args);
    15541554    if ((args.Length() == 1 && (args[0]->IsNull() || args[0]->IsUndefined() || args[0]->IsString() || args[0]->IsObject())))
    … …  
    15581558    if ((args.Length() == 1 && (args[0]->IsNull() || args[0]->IsFunction())))
    15591559        return overloadedMethod5Callback(args);
    1560     if ((args.Length() == 1 && (args[0]->IsNull() || V8DOMStringList::HasInstance(args[0]))))
     1560    if ((args.Length() == 1 && (args[0]->IsNull() || V8DOMStringList::HasInstance(args[0], args.GetIsolate()))))
    15611561        return overloadedMethod6Callback(args);
    15621562    if ((args.Length() == 1 && (args[0]->IsNull() || args[0]->IsArray())))
    15631563        return overloadedMethod7Callback(args);
    1564     if ((args.Length() == 1 && (V8TestObj::HasInstance(args[0]))))
     1564    if ((args.Length() == 1 && (V8TestObj::HasInstance(args[0], args.GetIsolate()))))
    15651565        return overloadedMethod8Callback(args);
    15661566    if ((args.Length() == 1 && (args[0]->IsArray())))
    … …  
    18461846    Vector<RefPtr<Node> > tail;
    18471847    for (int i = 1; i < args.Length(); ++i) {
    1848         if (!V8Node::HasInstance(args[i]))
     1848        if (!V8Node::HasInstance(args[i], args.GetIsolate()))
    18491849            return throwTypeError(0, args.GetIsolate());
    18501850        tail.append(V8Node::toNative(v8::Handle<v8::Object>::Cast(args[i])));
    … …  
    22422242}
    22432243
    2244 bool V8TestObj::HasInstance(v8::Handle<v8::Value> value)
    2245 {
    2246     return GetRawTemplate()->HasInstance(value);
     2244bool V8TestObj::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
     2245{
     2246    return GetRawTemplate(isolate)->HasInstance(value);
    22472247}
    22482248

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h

    r140616 r141553  
    3535public:
    3636    static const bool hasDependentLifetime = false;
    37     static bool HasInstance(v8::Handle<v8::Value>);
     37    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3838    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp

    r141105 r141553  
    124124    if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)
    125125        return args.Holder();
    126     if ((args.Length() == 1 && (V8ArrayBuffer::HasInstance(args[0]))))
     126    if ((args.Length() == 1 && (V8ArrayBuffer::HasInstance(args[0], args.GetIsolate()))))
    127127        return constructor1Callback(args);
    128     if ((args.Length() == 1 && (V8ArrayBufferView::HasInstance(args[0]))))
     128    if ((args.Length() == 1 && (V8ArrayBufferView::HasInstance(args[0], args.GetIsolate()))))
    129129        return constructor2Callback(args);
    130     if ((args.Length() == 1 && (V8Blob::HasInstance(args[0]))))
     130    if ((args.Length() == 1 && (V8Blob::HasInstance(args[0], args.GetIsolate()))))
    131131        return constructor3Callback(args);
    132132    if (args.Length() == 1)
    … …  
    185185}
    186186
    187 bool V8TestOverloadedConstructors::HasInstance(v8::Handle<v8::Value> value)
    188 {
    189     return GetRawTemplate()->HasInstance(value);
     187bool V8TestOverloadedConstructors::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
     188{
     189    return GetRawTemplate(isolate)->HasInstance(value);
    190190}
    191191

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h

    r140616 r141553  
    3535public:
    3636    static const bool hasDependentLifetime = false;
    37     static bool HasInstance(v8::Handle<v8::Value>);
     37    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    3838    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    3939    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp

    r141105 r141553  
    303303}
    304304
    305 bool V8TestSerializedScriptValueInterface::HasInstance(v8::Handle<v8::Value> value)
    306 {
    307     return GetRawTemplate()->HasInstance(value);
     305bool V8TestSerializedScriptValueInterface::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate)
     306{
     307    return GetRawTemplate(isolate)->HasInstance(value);
    308308}
    309309

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h

    r140616 r141553  
    3737public:
    3838    static const bool hasDependentLifetime = false;
    39     static bool HasInstance(v8::Handle<v8::Value>);
     39    static bool HasInstance(v8::Handle<v8::Value>, v8::Isolate* = 0);
    4040    static v8::Persistent<v8::FunctionTemplate> GetRawTemplate(v8::Isolate* = 0);
    4141    static v8::Persistent<v8::FunctionTemplate> GetTemplate(v8::Isolate* = 0);
Note: See TracChangeset for help on using the changeset viewer.