Changeset 141556 in webkit

Timestamp:

Feb 1, 2013 12:52:01 AM (11 years ago)

Author:

tsepez@chromium.org

Message:

Dubious cast from HTMLCollection to HTMLAllCollection
​https://bugs.webkit.org/show_bug.cgi?id=108538

Reviewed by Adam Barth.

Patch is tested by enabling V8 binding integrity on HTMLAllCollection and
running the existing tests without introducing new crashes.

• dom/Document.cpp:

(WebCore::Document::all):
Pass correct type to template.

• html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):

• html/HTMLAllCollection.h:

(HTMLAllCollection):
Make create() method arguments compatible with template above.

• html/HTMLAllCollection.idl:

Enable binding integrity.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)
• html/HTMLAllCollection.cpp (modified) (1 diff)
• html/HTMLAllCollection.h (modified) (2 diffs)
• html/HTMLAllCollection.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-01  Tom Sepez  <tsepez@chromium.org>
+
+        Dubious cast from HTMLCollection to HTMLAllCollection
+        https://bugs.webkit.org/show_bug.cgi?id=108538
+
+        Reviewed by Adam Barth.
+
+        Patch is tested by enabling V8 binding integrity on HTMLAllCollection and
+        running the existing tests without introducing new crashes.
+
+        * dom/Document.cpp:
+        (WebCore::Document::all):
+        Pass correct type to template.
+        
+        * html/HTMLAllCollection.cpp:
+        (WebCore::HTMLAllCollection::create):
+        (WebCore::HTMLAllCollection::HTMLAllCollection):
+        * html/HTMLAllCollection.h:
+        (HTMLAllCollection):
+        Make create() method arguments compatible with template above.
+
+        * html/HTMLAllCollection.idl:
+        Enable binding integrity.
+
 2013-02-01  Ken Kania  <kkania@chromium.org>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -4370 +4370 @@
 PassRefPtr<HTMLCollection> Document::all()
 {
-    return ensureCachedCollection(DocAll);
+    return ensureRareData()->ensureNodeLists()->addCacheWithAtomicName<HTMLAllCollection>(this, DocAll);
 }
 

trunk/Source/WebCore/html/HTMLAllCollection.cpp

@@ -31 +31 @@
 namespace WebCore {
 
-PassRefPtr<HTMLAllCollection> HTMLAllCollection::create(Document* document)
+PassRefPtr<HTMLAllCollection> HTMLAllCollection::create(Node* node, CollectionType type)
 {
-    return adoptRef(new HTMLAllCollection(document));
+    return adoptRef(new HTMLAllCollection(node, type));
 }
 
-HTMLAllCollection::HTMLAllCollection(Document* document)
-    : HTMLCollection(document, DocAll, DoesNotOverrideItemAfter)
+HTMLAllCollection::HTMLAllCollection(Node* node, CollectionType type)
+    : HTMLCollection(node, type, DoesNotOverrideItemAfter)
 {
 }

trunk/Source/WebCore/html/HTMLAllCollection.h

@@ -33 +33 @@
 class HTMLAllCollection : public HTMLCollection {
 public:
-    static PassRefPtr<HTMLAllCollection> create(Document*);
+    static PassRefPtr<HTMLAllCollection> create(Node*, CollectionType);
     virtual ~HTMLAllCollection();
 
@@ -39 +39 @@
 
 private:
-    HTMLAllCollection(Document*);
+    HTMLAllCollection(Node*, CollectionType);
 };
 

trunk/Source/WebCore/html/HTMLAllCollection.idl

@@ -31 +31 @@
     GenerateIsReachable=ImplOwnerNodeRoot,
     V8DependentLifetime,
-    V8SkipVTableValidation
 ] interface HTMLAllCollection {
     readonly attribute unsigned long length;