Changeset 141561 in webkit
- Timestamp:
- Feb 1, 2013 1:52:10 AM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r141560 r141561 1 2013-02-01 Andrey Adaikin <aandrey@chromium.org> 2 3 Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend 4 https://bugs.webkit.org/show_bug.cgi?id=108591 5 6 Reviewed by Pavel Feldman. 7 8 Send a dropTraceLog command to the backend when deleting a profile header from the sidebar. 9 Before we were sending the command only upon deleting an existing view of a profile, so we would not 10 sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method). 11 Drive-by: fixed an odd formatting of property functions. 12 13 * inspector/front-end/CanvasProfileView.js: 14 (WebInspector.CanvasProfileView.prototype.dispose): 15 (WebInspector.CanvasProfileHeader.prototype.reset): 16 * inspector/front-end/ProfilesPanel.js: 17 (WebInspector.ProfileHeader.prototype.reset): 18 (WebInspector.ProfileHeader.prototype.load): 19 (WebInspector.ProfileHeader.prototype.canSaveToFile): 20 (WebInspector.ProfileHeader.prototype.saveToFile): 21 (WebInspector.ProfileHeader.prototype.loadFromFile): 22 (WebInspector.ProfileHeader.prototype.fromFile): 23 (WebInspector.ProfilesPanel): 24 (WebInspector.ProfilesPanel.prototype._reset): 25 (WebInspector.ProfilesPanel.prototype._removeProfileHeader): 26 1 27 2013-02-01 Chris Fleizach <cfleizach@apple.com> 2 28 -
trunk/Source/WebCore/inspector/front-end/CanvasProfileView.js
r141403 r141561 104 104 this._logGridNodes = []; 105 105 this._linkifier.reset(); 106 CanvasAgent.dropTraceLog(this._traceLogId);107 106 }, 108 107 … … 768 767 769 768 /** 769 * @override 770 */ 771 reset: function() 772 { 773 if (this._traceLogId) 774 CanvasAgent.dropTraceLog(this._traceLogId); 775 }, 776 777 /** 770 778 * @param {CanvasAgent.TraceLog=} traceLog 771 779 */ -
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
r141409 r141561 185 185 }, 186 186 187 reset: function() 188 { 189 }, 190 187 191 /** 188 192 * @param {Function} callback 189 193 */ 190 load: function(callback) { }, 194 load: function(callback) 195 { 196 }, 191 197 192 198 /** 193 199 * @return {boolean} 194 200 */ 195 canSaveToFile: function() { return false; }, 196 197 saveToFile: function() { throw new Error("Needs implemented"); }, 201 canSaveToFile: function() 202 { 203 return false; 204 }, 205 206 saveToFile: function() 207 { 208 throw new Error("Needs implemented"); 209 }, 198 210 199 211 /** 200 212 * @param {File} file 201 213 */ 202 loadFromFile: function(file) { throw new Error("Needs implemented"); }, 214 loadFromFile: function(file) 215 { 216 throw new Error("Needs implemented"); 217 }, 203 218 204 219 /** 205 220 * @return {boolean} 206 221 */ 207 fromFile: function() { return this._fromFile; } 222 fromFile: function() 223 { 224 return this._fromFile; 225 } 208 226 } 209 227 … … 265 283 this._profileViewStatusBarItemsContainer.className = "status-bar-items"; 266 284 285 /** @type {!Array.<!WebInspector.ProfileHeader>} */ 267 286 this._profiles = []; 268 287 this._profilerEnabled = !Capabilities.profilerCausesRecompilation; … … 401 420 view.dispose(); 402 421 } 422 this._profiles[i].reset(); 403 423 } 404 424 delete this.visibleView; … … 595 615 profile = this._profiles[i]; 596 616 this._profiles.splice(i, 1); 617 profile.reset(); 597 618 break; 598 619 }
Note: See TracChangeset
for help on using the changeset viewer.