Changeset 141645 in webkit
- Timestamp:
- Feb 1, 2013 2:38:50 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r141644 r141645 1 2013-02-01 Philip Rogers <pdr@google.com> 2 3 Prevent skipped repaints for children of inner SVG elements 4 https://bugs.webkit.org/show_bug.cgi?id=108429 5 6 Reviewed by Eric Seidel. 7 8 Need to update expectations for a single file (just a 1px difference). 9 10 * platform/chromium/TestExpectations: 11 * platform/efl/TestExpectations: 12 * platform/mac/TestExpectations: 13 * platform/qt/TestExpectations: 14 * platform/win/TestExpectations: 15 * svg/repaint/svgsvgelement-repaint-children-expected.png: Added. 16 * svg/repaint/svgsvgelement-repaint-children-expected.txt: Added. 17 * svg/repaint/svgsvgelement-repaint-children.html: Added. 18 1 19 2013-02-01 Philip Rogers <pdr@google.com> 2 20 -
trunk/LayoutTests/platform/chromium/TestExpectations
r141644 r141645 3569 3569 webkit.org/b/94242 [ Android Debug ] media/track/track-cues-sorted-before-dispatch.html [ Pass Timeout ] 3570 3570 3571 # Needs a rebaseline after WK108429 lands. 3572 webkit.org/b/108429 svg/custom/text-ctm.svg [ Pass Failure ] 3573 webkit.org/b/108429 svg/repaint/svgsvgelement-repaint-children.html [ Pass Failure ] 3574 3571 3575 # Chromium still has the CC toggle button, not the menu of tracks. 3572 3576 webkit.org/b/101670 media/video-controls-captions-trackmenu.html [ Skip ] -
trunk/LayoutTests/platform/efl/TestExpectations
r141624 r141645 1842 1842 webkit.org/b/107476 fast/block/margin-collapse/empty-clear-blocks.html [ Failure ] 1843 1843 1844 # Needs a rebaseline after WK108429 lands. 1845 webkit.org/b/108429 svg/custom/text-ctm.svg [ Pass Failure ] 1846 1844 1847 # New ruby selection test (in r140613) fails to render correctly, not generating an expected result 1845 1848 webkit.org/b/108315 fast/ruby/select-ruby.html [ Missing ] -
trunk/LayoutTests/platform/mac/TestExpectations
r141638 r141645 1154 1154 webkit.org/b/104595 fast/css/empty-generated-content.html [ Failure ] 1155 1155 1156 # Needs a rebaseline after WK108429 lands. 1157 webkit.org/b/108429 svg/custom/text-ctm.svg [ Pass Failure ] 1158 1156 1159 webkit.org/b/93247 [ Debug ] fast/lists/list-marker-remove-crash.html [ Crash ] 1157 1160 -
trunk/LayoutTests/platform/qt/TestExpectations
r141621 r141645 2446 2446 webkit.org/b/99870 svg/custom/pattern-scaling.svg [ Pass ImageOnlyFailure Missing ] 2447 2447 2448 # Needs a rebaseline after WK108429 lands. 2449 webkit.org/b/108429 svg/custom/text-ctm.svg [ Pass Failure ] 2450 2448 2451 # Disable webaudio codec tests, including proprietary codecs. 2449 2452 webkit.org/b/88794 webaudio/codec-tests -
trunk/LayoutTests/platform/win/TestExpectations
r141629 r141645 2054 2054 fast/forms/time-multiple-fields 2055 2055 fast/forms/week-multiple-fields 2056 2057 # Needs a rebaseline after WK108429 lands. 2058 svg/custom/text-ctm.svg 2056 2059 2057 2060 # Require rebaseline after https://bugs.webkit.org/show_bug.cgi?id=84286 -
trunk/Source/WebCore/ChangeLog
r141637 r141645 1 2013-02-01 Philip Rogers <pdr@google.com> 2 3 Prevent skipped repaints for children of inner SVG elements 4 https://bugs.webkit.org/show_bug.cgi?id=108429 5 6 Reviewed by Eric Seidel. 7 8 This patch fixes a bug caused by r108699 and r133786 where we would not repaint children 9 of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport 10 containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints. 11 12 I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed 13 with this patch. 14 15 Test: svg/repaint/svgsvgelement-repaint-children.html 16 17 * rendering/svg/RenderSVGViewportContainer.cpp: 18 (WebCore::RenderSVGViewportContainer::calcViewport): 19 20 This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate. 21 22 (WebCore::RenderSVGViewportContainer::calculateLocalTransform): 23 24 This change is straightforward and is similar to the equivalent assignment in 25 RenderSVGTransformableContainer::calculateLocalTransform(). 26 1 27 2013-02-01 Philip Rogers <pdr@google.com> 2 28 -
trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp
r109097 r141645 115 115 116 116 if (oldViewport != m_viewport) { 117 m_didTransformToRootUpdate = true;118 117 setNeedsBoundariesUpdate(); 119 118 setNeedsTransformUpdate(); … … 123 122 bool RenderSVGViewportContainer::calculateLocalTransform() 124 123 { 124 m_didTransformToRootUpdate = m_needsTransformUpdate || SVGRenderSupport::transformToRootChanged(parent()); 125 125 if (!m_needsTransformUpdate) 126 126 return false;
Note: See TracChangeset
for help on using the changeset viewer.