Changeset 141659 in webkit


Ignore:
Timestamp:
Feb 1, 2013 4:14:17 PM (11 years ago)
Author:
ojan@chromium.org
Message:

Make svg-fonts-in-text-controls.html have the same results across platforms
​https://bugs.webkit.org/show_bug.cgi?id=108676

Reviewed by Dirk Pranke.

Mac uses a different default font-size for form controls and Windows
uses different padding for textareas/inputs. Override these so
this test doesn't need platform specific expectations.

  • platform/chromium/TestExpectations:
  • platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.png: Removed.
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
  • svg/custom/script-tests/svg-fonts-in-text-controls.js:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
  • svg/custom/svg-fonts-in-text-controls.html:

These dummy elements aren't needed anymore. js-test-pre.js inserts them.

Location:
trunk/LayoutTests
Files:
3 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r141650 r141659  
     12013-02-01  Ojan Vafai  <ojan@chromium.org>
     2
     3        Make svg-fonts-in-text-controls.html have the same results across platforms
     4        https://bugs.webkit.org/show_bug.cgi?id=108676
     5
     6        Reviewed by Dirk Pranke.
     7
     8        Mac uses a different default font-size for form controls and Windows
     9        uses different padding for textareas/inputs. Override these so
     10        this test doesn't need platform specific expectations.
     11
     12        * platform/chromium/TestExpectations:
     13        * platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
     14        * platform/qt/svg/custom/svg-fonts-in-text-controls-expected.png: Removed.
     15        * platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
     16        * svg/custom/script-tests/svg-fonts-in-text-controls.js:
     17        * svg/custom/svg-fonts-in-text-controls-expected.txt:
     18        * svg/custom/svg-fonts-in-text-controls.html:
     19        These dummy elements aren't needed anymore. js-test-pre.js inserts them.
     20
    1212013-02-01  Rouslan Solomakhin  <rouslan@chromium.org>
    222

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r141650 r141659  
    19231923crbug.com/11001 http/tests/history/back-to-post.php [ Timeout ]
    19241924
    1925 # Regressions from WebKit Merge 42932:42994 due to text metric changes.
    1926 crbug.com/11251 [ Android Linux Win ] svg/custom/svg-fonts-in-text-controls.html [ Failure ]
    1927 
    19281925# WebKit 45086:45111
    19291926crbug.com/15270 fast/js/excessive-comma-usage.html [ Failure ]

  • trunk/LayoutTests/svg/custom/script-tests/svg-fonts-in-text-controls.js

    r48554 r141659  
    88var textarea = document.createElement('textarea');
    99textarea.style.fontFamily = 'SVGraffiti';
     10textarea.style.fontSize = '11px';
     11textarea.style.padding = 0;
    1012textarea.cols = 20;
    1113document.body.appendChild(textarea);
    … …  
    1315var input = document.createElement('input');
    1416input.style.fontFamily = 'SVGraffiti';
     17input.style.fontSize = '11px';
     18input.style.padding = 0;
    1519input.size = 20;
    1620document.body.appendChild(input);

  • trunk/LayoutTests/svg/custom/svg-fonts-in-text-controls-expected.txt

    r117673 r141659  
    77
    88TEST COMPLETE
    9 Textarea offsetWidth: 121
    10 Input offsetWidth: 106
     9Textarea offsetWidth: 117
     10Input offsetWidth: 104
    1111

  • trunk/LayoutTests/svg/custom/svg-fonts-in-text-controls.html

    r99220 r141659  
    55</head>
    66<body>
    7 <p id="description"></p>
    8 <div id="console"></div>
    97<script src="script-tests/svg-fonts-in-text-controls.js"></script>
    108<script src="../../fast/js/resources/js-test-post.js"></script>
Note: See TracChangeset for help on using the changeset viewer.