Changeset 141672 in webkit

Timestamp:

Feb 1, 2013 6:16:54 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Update LayoutTests scripts to skip webgl folder on ports
​https://bugs.webkit.org/show_bug.cgi?id=108705

Patch by Gregg Tavares <​gman@google.com> on 2013-02-01
Reviewed by Dirk Pranke.

I'm working on checking in the WebGL Conformance Tests
as layout tests into LayoutTests/webgl. For ports
that do not have WebGL enabled this changes will
skip tests in the "webgl" folder.

• Scripts/webkitpy/layout_tests/port/base.py:

(Port._missing_symbol_to_skipped_tests):

• Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_skipped_directories_for_symbols):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/base.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/port_testcase.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-02-01  Gregg Tavares  <gman@google.com>
+
+        Update LayoutTests scripts to skip webgl folder on ports
+        https://bugs.webkit.org/show_bug.cgi?id=108705
+
+        Reviewed by Dirk Pranke.
+
+        I'm working on checking in the WebGL Conformance Tests
+        as layout tests into LayoutTests/webgl. For ports
+        that do not have WebGL enabled this changes will
+        skip tests in the "webgl" folder.
+
+        * Scripts/webkitpy/layout_tests/port/base.py:
+        (Port._missing_symbol_to_skipped_tests):
+        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
+        (PortTestCase.test_skipped_directories_for_symbols):
+
 2013-02-01  Roger Fong  <roger_fong@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -1505 +1505 @@
             "GraphicsLayer": ["compositing"],
             "WebCoreHas3DRendering": ["animations/3d", "transforms/3d"],
-            "WebGLShader": ["fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl"],
+            "WebGLShader": ["fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "webgl"],
             "MHTMLArchive": ["mhtml"],
             "CSSVariableValue": ["fast/css/variables", "inspector/styles/variables"],

trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

@@ -459 +459 @@
             "compositing/webgl",  # Requires WebGLShader
             "http/tests/canvas/webgl",  # Requires WebGLShader
+            "webgl",  # Requires WebGLShader
             "mhtml",  # Requires MHTMLArchive
             "fast/css/variables",  # Requires CSS Variables
@@ -474 +475 @@
 """
         # Note 'compositing' is not in the list of skipped directories (hence the parsing of GraphicsLayer worked):
-        expected_directories = set(['mathml', 'transforms/3d', 'compositing/webgl', 'fast/canvas/webgl', 'animations/3d', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables', 'inspector/styles/variables'])
+        expected_directories = set(['mathml', 'transforms/3d', 'compositing/webgl', 'fast/canvas/webgl', 'animations/3d', 'webgl', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables', 'inspector/styles/variables'])
         result_directories = set(TestWebKitPort(symbols_string=symbols_string)._skipped_tests_for_unsupported_features(test_list=['mathml/foo.html']))
         self.assertEqual(result_directories, expected_directories)