Changeset 141691 in webkit

Timestamp:

Feb 2, 2013 5:05:11 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Improper initialization of ANGLEResources
​https://bugs.webkit.org/show_bug.cgi?id=101489

Patch by Jonathan Feldstein <​jfeldstein@rim.com> on 2013-02-02
Reviewed by Antonio Gomes.

MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle have already been initialized through ShBuiltInResources function and these fields do not need to be set again in GraphicsContext3dBlackBerry.cpp. In addition, the extension flags cannot be set to true without getExtension having been called (Khronos WebGL specs, section 5.14.14.). Thus these lines need to be removed.

• platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-02  Jonathan Feldstein  <jfeldstein@rim.com>
+
+        [BlackBerry] Improper initialization of ANGLEResources
+        https://bugs.webkit.org/show_bug.cgi?id=101489
+
+        Reviewed by Antonio Gomes.
+
+        MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle have already been initialized through ShBuiltInResources function and these fields do not need to be set again in GraphicsContext3dBlackBerry.cpp. In addition, the extension flags cannot be set to true without getExtension having been called (Khronos WebGL specs, section 5.14.14.). Thus these lines need to be removed.
+
+        * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
+        (WebCore::GraphicsContext3D::GraphicsContext3D):
+
 2013-02-02  Vivek Galatage  <vivek.vg@samsung.com>
 

trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp

@@ -113 +113 @@
 
     ANGLEResources.MaxDrawBuffers = 1; // Always set to 1 for OpenGL ES.
-    ANGLEResources.OES_standard_derivatives = m_extensions->supports("GL_OES_standard_derivatives");
-    ANGLEResources.OES_EGL_image_external = m_extensions->supports("GL_EGL_image_external");
-    ANGLEResources.ARB_texture_rectangle = m_extensions->supports("GL_ARB_texture_rectangle");
     m_compiler.setResources(ANGLEResources);