Changeset 141840 in webkit

Timestamp:

Feb 4, 2013 6:01:20 PM (11 years ago)

Author:

dino@apple.com

Message:

Allow TextTracks to be marked as closed captions
​https://bugs.webkit.org/show_bug.cgi?id=108856

Reviewed by Darin Adler.

While this isn't exposed directly in markup, some platform media frameworks can
provide indication that a caption track is a closed caption. Expose such a flag
on TextTrack and platforms can show a different UI if they want to.

No tests - this isn't used elsewhere yet, nor exposed to the DOM.

• html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Initialise new member.

• html/track/TextTrack.h:

(WebCore::TextTrack::isClosedCaptions): New member variable.
(WebCore::TextTrack::setIsClosedCaptions):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/track/TextTrack.cpp (modified) (1 diff)
• html/track/TextTrack.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-04  Dean Jackson  <dino@apple.com>
+
+        Allow TextTracks to be marked as closed captions
+        https://bugs.webkit.org/show_bug.cgi?id=108856
+
+        Reviewed by Darin Adler.
+
+        While this isn't exposed directly in markup, some platform media frameworks can
+        provide indication that a caption track is a closed caption. Expose such a flag
+        on TextTrack and platforms can show a different UI if they want to.
+
+        No tests - this isn't used elsewhere yet, nor exposed to the DOM.
+
+        * html/track/TextTrack.cpp:
+        (WebCore::TextTrack::TextTrack): Initialise new member.
+        * html/track/TextTrack.h:
+        (WebCore::TextTrack::isClosedCaptions): New member variable.
+        (WebCore::TextTrack::setIsClosedCaptions):
+
 2013-02-04  Chris Hopman  <cjhopman@chromium.org>
 

trunk/Source/WebCore/html/track/TextTrack.cpp

@@ -108 +108 @@
     , m_renderedTrackIndex(invalidTrackIndex)
     , m_hasBeenConfigured(false)
+    , m_isClosedCaptions(false)
 {
     setKind(kind);

trunk/Source/WebCore/html/track/TextTrack.h

@@ -110 +110 @@
     TextTrackType trackType() const { return m_trackType; }
 
+    bool isClosedCaptions() const { return m_isClosedCaptions; }
+    void setIsClosedCaptions(bool isClosedCaptions) { m_isClosedCaptions = isClosedCaptions; }
+
     int trackIndex();
     void invalidateTrackIndex();
@@ -142 +145 @@
     int m_renderedTrackIndex;
     bool m_hasBeenConfigured;
+    bool m_isClosedCaptions;
 };