Changeset 142009 in webkit

Timestamp:

Feb 6, 2013 10:54:06 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Assertion failure on MiniBrowser exit
​https://bugs.webkit.org/show_bug.cgi?id=108932

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-02-06
Reviewed by Anders Carlsson.

WorkQueue is now refcounted after r141497, so increase ref
count when a new job is scheduled and unref it when it finishes.

• Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::performWork):
(WorkQueue::performTimerWork):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/efl/WorkQueueEfl.cpp (modified) (4 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-02-06  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
+
+        [EFL][WK2] Assertion failure on MiniBrowser exit
+        https://bugs.webkit.org/show_bug.cgi?id=108932
+
+        Reviewed by Anders Carlsson.
+
+        WorkQueue is now refcounted after r141497, so increase ref
+        count when a new job is scheduled and unref it when it finishes.
+
+        * Platform/efl/WorkQueueEfl.cpp:
+        (WorkQueue::performWork):
+        (WorkQueue::performTimerWork):
+        (WorkQueue::dispatch):
+        (WorkQueue::dispatchAfterDelay):
+
 2013-02-06  Simon Hausmann  <simon.hausmann@digia.com>, Zoltan Arvai  <zarvai@inf.u-szeged.hu>
 

trunk/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp

@@ -80 +80 @@
         }
 
-        for (size_t i = 0; i < workItemQueue.size(); ++i)
+        for (size_t i = 0; i < workItemQueue.size(); ++i) {
             workItemQueue[i]();
+            deref();
+        }
     }
 }
@@ -163 +165 @@
         // If a timer work item expired, dispatch the function of the work item.
         timerWorkItems[i]->dispatch();
+        deref();
     }
 }
@@ -211 +214 @@
 void WorkQueue::dispatch(const Function<void()>& function)
 {
+    ref();
+
     {
         MutexLocker locker(m_workItemQueueLock);
@@ -228 +233 @@
         return;
 
+    ref();
     insertTimerWorkItem(timerWorkItem.release());
     sendMessageToThread(wakupThreadMessage);