Changeset 142075 in webkit

Timestamp:

Feb 7, 2013 12:38:55 AM (11 years ago)

Author:

haraken@chromium.org

Message:

Remove DOMWindow::parseModalDialogFeatures()
​https://bugs.webkit.org/show_bug.cgi?id=109139

Reviewed by Kent Tamura.

No one uses the method. FIXME is saying:

FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.

Given that V8's showModalDialog() is now using DOMWindow, we can remove it.

No tests. No change in behavior.

• page/DOMWindow.cpp:
• page/DOMWindow.h:

(DOMWindow):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMWindow.cpp (modified) (1 diff)
• page/DOMWindow.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-06  Kentaro Hara  <haraken@chromium.org>
+
+        Remove DOMWindow::parseModalDialogFeatures()
+        https://bugs.webkit.org/show_bug.cgi?id=109139
+
+        Reviewed by Kent Tamura.
+
+        No one uses the method. FIXME is saying:
+
+          // FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.
+
+        Given that V8's showModalDialog() is now using DOMWindow, we can remove it.
+
+        No tests. No change in behavior.
+
+        * page/DOMWindow.cpp:
+        * page/DOMWindow.h:
+        (DOMWindow):
+
 2013-02-06  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -350 +350 @@
 }
 
-// FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.
-void DOMWindow::parseModalDialogFeatures(const String& string, HashMap<String, String>& map)
-{
-    WindowFeatures::parseDialogFeatures(string, map);
-}
-
 bool DOMWindow::allowPopUp(Frame* firstFrame)
 {

trunk/Source/WebCore/page/DOMWindow.h

@@ -122 +122 @@
 
         static FloatRect adjustWindowRect(Page*, const FloatRect& pendingChanges);
-
-        // FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.
-        static void parseModalDialogFeatures(const String&, HashMap<String, String>&);
 
         bool allowPopUp(); // Call on first window, not target window.