Changeset 142111 in webkit
- Timestamp:
- Feb 7, 2013 6:42:20 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 6 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r142110 r142111 1 2013-02-07 Keishi Hattori <keishi@webkit.org> 2 3 REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute 4 https://bugs.webkit.org/show_bug.cgi?id=108055 5 6 Reviewed by Kent Tamura. 7 8 * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added. 9 * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added. 10 * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added. 11 * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added. 12 * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added. 13 * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added. 14 * platform/chromium/TestExpectations: 15 1 16 2013-02-07 Ádám Kallai <kadam@inf.u-szeged.hu> 2 17 -
trunk/LayoutTests/platform/chromium/TestExpectations
r142084 r142111 4233 4233 webkit.org/b/107508 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html [ ImageOnlyFailure Pass ] 4234 4234 webkit.org/b/107508 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html [ ImageOnlyFailure Pass ] 4235 webkit.org/b/109136 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html [ ImageOnlyFailure Pass ] 4236 webkit.org/b/109136 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ ImageOnlyFailure Pass ] 4235 4237 4236 4238 # Rebaseline after currentPath -
trunk/Source/WebCore/ChangeLog
r142108 r142111 1 2013-02-07 Keishi Hattori <keishi@webkit.org> 2 3 REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute 4 https://bugs.webkit.org/show_bug.cgi?id=109136 5 6 Reviewed by Kent Tamura. 7 8 Calendar picker was using the "Clear" button to calculate the window width. 9 Since it doesn't exist when the input element has a required attribute, 10 it was throwing an error. This patch fixes the width calculating logic. 11 12 Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html 13 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html 14 15 * Resources/pagepopups/calendarPicker.css: 16 (.today-clear-area): 17 * Resources/pagepopups/calendarPicker.js: 18 (CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate 19 the width. We don't want to use clear button because it doesn't exist 20 when a value is required. 21 1 22 2013-02-07 Gustavo Noronha Silva <gns@gnome.org> 2 23 -
trunk/Source/WebCore/Resources/pagepopups/calendarPicker.css
r140778 r142111 275 275 margin-right: 8px; 276 276 } 277 278 .today-clear-area { 279 display: inline-block; 280 /* display: block is added in the JS code. */ 281 } -
trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js
r140778 r142111 761 761 var yearMonthRightElement = this._element.getElementsByClassName(ClassNames.YearMonthButtonRight)[0]; 762 762 var daysAreaElement = this._element.getElementsByClassName(ClassNames.DaysArea)[0]; 763 var clearButton = this._element.getElementsByClassName(ClassNames.ClearButton)[0];763 var todayClearArea = this._element.getElementsByClassName(ClassNames.TodayClearArea)[0]; 764 764 var headers = daysAreaElement.getElementsByClassName(ClassNames.DayLabel); 765 765 var maxCellWidth = 0; … … 780 780 yearMonthEnd = startOffset - yearMonthRightElement.offsetLeft; 781 781 daysAreaEnd = startOffset - (daysAreaElement.offsetLeft + daysAreaElement.offsetWidth) + weekColumnWidth + maxCellWidth * 7 + DaysAreaContainerBorder; 782 todayClearAreaEnd = startOffset - clearButton.offsetLeft;782 todayClearAreaEnd = startOffset - todayClearArea.offsetLeft; 783 783 } else { 784 784 yearMonthEnd = yearMonthRightElement.offsetLeft + yearMonthRightElement.offsetWidth; 785 785 daysAreaEnd = daysAreaElement.offsetLeft + weekColumnWidth + maxCellWidth * 7 + DaysAreaContainerBorder; 786 todayClearAreaEnd = clearButton.offsetLeft + clearButton.offsetWidth;786 todayClearAreaEnd = todayClearArea.offsetLeft + todayClearArea.offsetWidth; 787 787 } 788 788 var maxEnd = Math.max(yearMonthEnd, daysAreaEnd, todayClearAreaEnd); … … 795 795 daysAreaElement.style.width = "100%"; 796 796 daysAreaElement.style.tableLayout = "fixed"; 797 todayClearArea.style.display = "block"; 797 798 this._element.getElementsByClassName(ClassNames.YearMonthUpper)[0].style.display = "-webkit-box"; 798 799 this._element.getElementsByClassName(ClassNames.MonthSelectorBox)[0].style.display = "block";
Note: See TracChangeset
for help on using the changeset viewer.