Changeset 142140 in webkit

Timestamp:

Feb 7, 2013 9:29:30 AM (11 years ago)

Author:

allan.jensen@digia.com

Message:

Scrollbars misplaced with accelerated compositing for overflow scroll
​https://bugs.webkit.org/show_bug.cgi?id=108625

Reviewed by Simon Fraser.

Source/WebCore:

Scrollbars require their own layer if overflow scroll is composited,
otherwise the scrollbars would be rendered on the content layer and
not fixed to the viewport.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):

LayoutTests:

Update the results for the one test that explicitly set accelerated compositing for overflow scroll,
and used to have bad results for non-chromium. The new baselines are almost identical to chomium baseline.

• platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
• platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt (modified) (2 diffs)
• LayoutTests/platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-07  Allan Sandfeld Jensen  <allan.jensen@digia.com>
+
+        Scrollbars misplaced with accelerated compositing for overflow scroll
+        https://bugs.webkit.org/show_bug.cgi?id=108625
+
+        Reviewed by Simon Fraser.
+
+        Update the results for the one test that explicitly set accelerated compositing for overflow scroll,
+        and used to have bad results for non-chromium. The new baselines are almost identical to chomium baseline.
+
+        * platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
+        * platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
+
 2013-02-07  Ádám Kallai  <kadam@inf.u-szeged.hu>
 

trunk/LayoutTests/platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt

@@ -10 +10 @@
           (bounds 202.00 202.00)
           (drawsContent 1)
-          (children 1
+          (children 4
             (GraphicsLayer
               (position 1.00 1.00)
@@ -30 +30 @@
               )
             )
+            (GraphicsLayer
+              (position 1.00 186.00)
+              (bounds 185.00 15.00)
+              (drawsContent 1)
+            )
+            (GraphicsLayer
+              (position 186.00 1.00)
+              (bounds 15.00 185.00)
+              (drawsContent 1)
+            )
+            (GraphicsLayer
+              (position 186.00 186.00)
+              (bounds 15.00 15.00)
+              (drawsContent 1)
+            )
           )
         )

trunk/LayoutTests/platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt

@@ -10 +10 @@
           (bounds 202.00 202.00)
           (drawsContent 1)
-          (children 1
+          (children 4
             (GraphicsLayer
               (position 1.00 1.00)
@@ -30 +30 @@
               )
             )
+            (GraphicsLayer
+              (position 1.00 186.00)
+              (bounds 185.00 15.00)
+              (drawsContent 1)
+            )
+            (GraphicsLayer
+              (position 186.00 1.00)
+              (bounds 15.00 185.00)
+              (drawsContent 1)
+            )
+            (GraphicsLayer
+              (position 186.00 186.00)
+              (bounds 15.00 15.00)
+              (drawsContent 1)
+            )
           )
         )

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-07  Allan Sandfeld Jensen  <allan.jensen@digia.com>
+
+        Scrollbars misplaced with accelerated compositing for overflow scroll
+        https://bugs.webkit.org/show_bug.cgi?id=108625
+
+        Reviewed by Simon Fraser.
+
+        Scrollbars require their own layer if overflow scroll is composited,
+        otherwise the scrollbars would be rendered on the content layer and
+        not fixed to the viewport.
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
+        (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
+        (WebCore::RenderLayerBacking::requiresScrollCornerLayer):
+
 2013-02-07  Mike West  <mkwst@chromium.org>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -973 +973 @@
 {
 #if !PLATFORM(CHROMIUM)
-    if (!m_owningLayer->hasOverlayScrollbars())
+    if (!m_owningLayer->hasOverlayScrollbars() && !m_owningLayer->needsCompositedScrolling())
         return false;
 #endif
@@ -982 +982 @@
 {
 #if !PLATFORM(CHROMIUM)
-    if (!m_owningLayer->hasOverlayScrollbars())
+    if (!m_owningLayer->hasOverlayScrollbars() && !m_owningLayer->needsCompositedScrolling())
         return false;
 #endif
@@ -991 +991 @@
 {
 #if !PLATFORM(CHROMIUM)
-    if (!m_owningLayer->hasOverlayScrollbars())
+    if (!m_owningLayer->hasOverlayScrollbars() && !m_owningLayer->needsCompositedScrolling())
         return false;
 #endif