Changeset 142152 in webkit
- Timestamp:
- Feb 7, 2013 10:48:39 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 4 added
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r142149 r142152 1 2013-01-27 Robert Hogan <robert@webkit.org> 2 3 CSS 2.1 failure: floats-149 fails 4 https://bugs.webkit.org/show_bug.cgi?id=95772 5 6 Reviewed by David Hyatt. 7 8 * css2.1/20110323/floats-149-expected.html: Added. 9 * css2.1/20110323/floats-149.htm: Added. 10 * fast/inline/inline-with-empty-inline-children-expected.txt: Added. 11 * fast/inline/inline-with-empty-inline-children.html: Added. 12 * platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: 13 1 14 2013-02-07 Max Vujovic <mvujovic@adobe.com> 2 15 -
trunk/LayoutTests/platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt
r71592 r142152 108 108 text run at (0,0) width 19 RTL: "\x{5D3}\x{5D4}\x{5D5}" 109 109 text run at (19,0) width 10: "([" 110 RenderInline {SPAN} at (0,0) size 0x19110 RenderInline {SPAN} at (0,0) size 20x19 111 111 RenderInline {SPAN} at (0,0) size 0x19 112 112 RenderText {#text} at (29,0) size 20x19 -
trunk/LayoutTests/platform/efl/TestExpectations
r142142 r142152 1867 1867 webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ] 1868 1868 webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ] 1869 1870 # Rebaseline required after https://webkit.org/b/95772 1871 webkit.org/b/109209 fast/text/international/bidi-ignored-for-first-child-inline.html [ Failure ] -
trunk/LayoutTests/platform/gtk/TestExpectations
r142078 r142152 75 75 webkit.org/b/107567 editing/selection/extend-by-sentence-001.html [ Failure ] 76 76 webkit.org/b/107567 svg/carto.net/combobox.svg [ Failure ] 77 78 # Rebaseline required after https://webkit.org/b/95772 79 webkit.org/b/109209 fast/text/international/bidi-ignored-for-first-child-inline.html [ Failure ] 77 80 #//////////////////////////////////////////////////////////////////////////////////////// 78 81 # Expected failures -
trunk/LayoutTests/platform/mac/TestExpectations
r142142 r142152 1332 1332 webkit.org/b/108257 [ Debug ] compositing/overflow/composited-scrolling-creates-a-stacking-container.html [ Crash ] 1333 1333 webkit.org/b/108257 [ Debug ] compositing/overflow/automatically-opt-into-composited-scrolling.html [ Crash ] 1334 1335 1336 # Rebaseline required after https://webkit.org/b/95772 1337 webkit.org/b/109209 fast/text/international/bidi-ignored-for-first-child-inline.html [ Failure ] -
trunk/LayoutTests/platform/qt/TestExpectations
r142142 r142152 2618 2618 webkit.org/b/91665 fast/dynamic/floating-to-non-floating.html [ Skip ] 2619 2619 webkit.org/b/91665 fast/dynamic/static-positioned-to-absolute-positioned.html [ Skip ] 2620 2621 # Rebaseline required after https://webkit.org/b/95772 2622 webkit.org/b/109209 fast/text/international/bidi-ignored-for-first-child-inline.html [ Failure ] -
trunk/Source/WebCore/ChangeLog
r142151 r142152 1 2013-01-27 Robert Hogan <robert@webkit.org> 2 3 CSS 2.1 failure: floats-149 fails 4 https://bugs.webkit.org/show_bug.cgi?id=95772 5 6 Reviewed by David Hyatt. 7 8 Treat inlines that contain nothing but empty inlines as empty too so that they get a linebox. 9 10 Tests: fast/inline/inline-with-empty-inline-children.html 11 css2.1/20110323/floats-149.htm 12 13 * rendering/InlineIterator.h: 14 (WebCore::isEmptyInline): 15 * rendering/RenderBlockLineLayout.cpp: 16 (WebCore::RenderBlock::layoutRunsAndFloatsInRange): Now that empty inlines get a linebox any out-of-flow 17 objects inside an empty inline (on a line that is otherwise empty) won't get positioned while skipping 18 through leading whitespace. 19 1 20 2013-02-07 peavo@outlook.com <peavo@outlook.com> 2 21 -
trunk/Source/WebCore/rendering/InlineIterator.h
r140693 r142152 182 182 return false; 183 183 184 if (!object->firstChild()) 185 return true; 186 187 return object->firstChild()->isText() && (object->firstChild() == object->lastChild()) && toRenderText(object->firstChild())->isAllCollapsibleWhitespace(); 184 for (RenderObject* curr = object->firstChild(); curr; curr = curr->nextSibling()) { 185 if (curr->isFloatingOrOutOfFlowPositioned()) 186 continue; 187 if (curr->isText() && toRenderText(curr)->isAllCollapsibleWhitespace()) 188 continue; 189 190 if (!isEmptyInline(curr)) 191 return false; 192 } 193 return true; 188 194 } 189 195 -
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
r141783 r142152 1617 1617 } 1618 1618 } 1619 1620 for (size_t i = 0; i < lineBreaker.positionedObjects().size(); ++i) 1621 setStaticPositions(this, lineBreaker.positionedObjects()[i]); 1622 1619 } 1620 1621 for (size_t i = 0; i < lineBreaker.positionedObjects().size(); ++i) 1622 setStaticPositions(this, lineBreaker.positionedObjects()[i]); 1623 1624 if (!layoutState.lineInfo().isEmpty()) { 1623 1625 layoutState.lineInfo().setFirstLine(false); 1624 1626 newLine(lineBreaker.clear());
Note: See TracChangeset
for help on using the changeset viewer.