Changeset 142167 in webkit


Ignore:
Timestamp:
Feb 7, 2013 1:10:50 PM (11 years ago)
Author:
gavinp@chromium.org
Message:

Unreviewed, rolling out r142142.
​http://trac.webkit.org/changeset/142142
​https://bugs.webkit.org/show_bug.cgi?id=109154

Source/WebCore:

Mac expectations were not right. See ​http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and ​http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):

LayoutTests:

Mac expectations were not right. See ​http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-home-button.html

  • inspector/editor/text-editor-home-button-expected.txt: Removed.
  • inspector/editor/text-editor-home-button.html: Removed.
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
Location:
trunk
Files:
2 deleted
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r142164 r142167  
     12013-02-07  Gavin Peters  <gavinp@chromium.org>
     2
     3        Unreviewed, rolling out r142142.
     4        http://trac.webkit.org/changeset/142142
     5        https://bugs.webkit.org/show_bug.cgi?id=109154
     6
     7        Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-home-button.html
     8
     9        * inspector/editor/text-editor-home-button-expected.txt: Removed.
     10        * inspector/editor/text-editor-home-button.html: Removed.
     11        * platform/efl/TestExpectations:
     12        * platform/mac/TestExpectations:
     13        * platform/qt/TestExpectations:
     14
    1152013-02-07  Bear Travis  <betravis@adobe.com>
    216

  • trunk/LayoutTests/platform/efl/TestExpectations

    r142152 r142167  
    18201820inspector/editor/text-editor-formatter.html
    18211821inspector/editor/text-editor-word-jumps.html
    1822 inspector/editor/text-editor-home-button.html
    18231822
    18241823# Remove from list after enabling CANVAS_PATH

  • trunk/LayoutTests/platform/mac/TestExpectations

    r142152 r142167  
    255255inspector/editor/text-editor-formatter.html [ Skip ]
    256256inspector/editor/text-editor-word-jumps.html [ Skip ]
    257 inspector/editor/text-editor-home-button.html [ Skip ]
    258257
    259258# https://bugs.webkit.org/show_bug.cgi?id=71120

  • trunk/LayoutTests/platform/qt/TestExpectations

    r142152 r142167  
    26022602inspector/editor/text-editor-formatter.html
    26032603inspector/editor/text-editor-word-jumps.html
    2604 inspector/editor/text-editor-home-button.html
    26052604
    26062605# Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=14664

  • trunk/Source/WebCore/ChangeLog

    r142166 r142167  
     12013-02-07  Gavin Peters  <gavinp@chromium.org>
     2
     3        Unreviewed, rolling out r142142.
     4        http://trac.webkit.org/changeset/142142
     5        https://bugs.webkit.org/show_bug.cgi?id=109154
     6
     7        Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .
     8
     9
     10        * inspector/front-end/DefaultTextEditor.js:
     11        (WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
     12
    1132013-02-07  Gavin Peters  <gavinp@chromium.org>
    214

  • trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js

    r142142 r142167  
    13981398        this._shortcuts[WebInspector.KeyboardShortcut.makeKey(keys.Tab.code)] = handleTabKey;
    13991399        this._shortcuts[WebInspector.KeyboardShortcut.makeKey(keys.Tab.code, modifiers.Shift)] = handleShiftTabKey;
    1400 
    1401         this._shortcuts[WebInspector.KeyboardShortcut.makeKey(keys.Home.code, modifiers.None)] = this._handleHomeKey.bind(this, false);
    1402         this._shortcuts[WebInspector.KeyboardShortcut.makeKey(keys.Home.code, modifiers.Shift)] = this._handleHomeKey.bind(this, true);
    1403     },
    1404 
    1405     /**
    1406      * @param {boolean} shift
    1407      */
    1408     _handleHomeKey: function(shift)
    1409     {
    1410         var selection = this.selection();
    1411 
    1412         var line = this._textModel.line(selection.endLine);
    1413         var firstNonBlankCharacter = 0;
    1414         while (firstNonBlankCharacter < line.length) {
    1415             var char = line.charAt(firstNonBlankCharacter);
    1416             if (char === " " || char === "\t")
    1417                 ++firstNonBlankCharacter;
    1418             else
    1419                 break;
    1420         }
    1421         if (firstNonBlankCharacter >= line.length || selection.endColumn === firstNonBlankCharacter)
    1422             return false;
    1423 
    1424         selection.endColumn = firstNonBlankCharacter;
    1425         if (!shift)
    1426             selection = selection.collapseToEnd();
    1427         this._restoreSelection(selection);
    1428         return true;
    14291400    },
    14301401
Note: See TracChangeset for help on using the changeset viewer.