Changeset 142289 in webkit

Timestamp:

Feb 8, 2013 9:05:28 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebCore: Fix and test for missing return statement

RTCPeerConnection.getStats() failed when remote stats were instantiated.
​https://bugs.webkit.org/show_bug.cgi?id=109292

Patch by Harald Alvestrand <​hta@google.com> on 2013-02-08
Reviewed by Adam Barth.

Tested by extending the existing mock's behaviour.

• Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::addElement):

Tools: Fix and test for missing return

RTCPeerConnection.getStats() fails when remote stats are instantiated.
​https://bugs.webkit.org/show_bug.cgi?id=109292

Patch by Harald Alvestrand <​hta@google.com> on 2013-02-08
Reviewed by Adam Barth.

• DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediastream/RTCStatsReport.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-08  Harald Alvestrand  <hta@google.com>
+
+        Fix and test for missing return statement
+
+        RTCPeerConnection.getStats() failed when remote stats were instantiated.
+        https://bugs.webkit.org/show_bug.cgi?id=109292
+
+        Reviewed by Adam Barth.
+
+        Tested by extending the existing mock's behaviour.
+
+        * Modules/mediastream/RTCStatsReport.cpp:
+        (WebCore::RTCStatsReport::addElement):
+
 2013-02-08  Anton Vayvod  <avayvod@chromium.org>
 

trunk/Source/WebCore/Modules/mediastream/RTCStatsReport.cpp

@@ -45 +45 @@
         ASSERT(!m_local);
         m_local = RTCStatsElement::create(timestamp);
+        return;
     }
     ASSERT(!m_remote);

trunk/Tools/ChangeLog

@@ +1 @@
+2013-02-08  Harald Alvestrand  <hta@google.com>
+
+        Fix and test for missing return
+
+        RTCPeerConnection.getStats() fails when remote stats are instantiated.
+        https://bugs.webkit.org/show_bug.cgi?id=109292
+
+        Reviewed by Adam Barth.
+
+        * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
+        (MockWebRTCPeerConnectionHandler::getStats):
+
 2013-02-08  Tommy Widenflycht  <tommyw@google.com>
 

trunk/Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp

@@ -283 +283 @@
             response.addElement(reportIndex, true, currentDate);
             response.addStatistic(reportIndex, true, "type", "video");
+            // We add an empty remote report element.
+            response.addElement(reportIndex, false, currentDate);
         }
     }