Changeset 142356 in webkit

Timestamp:

Feb 9, 2013 7:14:20 AM (11 years ago)

Author:

mkwst@chromium.org

Message:

Drop ExceptionCode from IDB's directionToString and modeToString.
​https://bugs.webkit.org/show_bug.cgi?id=109143

Reviewed by Jochen Eisinger.

No caller of either IDBCursor::directionToString or
IDBTransaction::modeToString makes use of the ExceptionCode these
methods require. This patch removes the 'ExceptionCode&' parameter from
both methods and their callsites.

• Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::directionToString):

Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.

• Modules/indexeddb/IDBCursor.h:
• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::modeToString):

Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.

• Modules/indexeddb/IDBTransaction.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/IDBCursor.cpp (modified) (3 diffs)
• Modules/indexeddb/IDBCursor.h (modified) (1 diff)
• Modules/indexeddb/IDBTransaction.cpp (modified) (3 diffs)
• Modules/indexeddb/IDBTransaction.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-09  Mike West  <mkwst@chromium.org>
+
+        Drop ExceptionCode from IDB's directionToString and modeToString.
+        https://bugs.webkit.org/show_bug.cgi?id=109143
+
+        Reviewed by Jochen Eisinger.
+
+        No caller of either IDBCursor::directionToString or
+        IDBTransaction::modeToString makes use of the ExceptionCode these
+        methods require. This patch removes the 'ExceptionCode&' parameter from
+        both methods and their callsites.
+
+        * Modules/indexeddb/IDBCursor.cpp:
+        (WebCore::IDBCursor::direction):
+        (WebCore::IDBCursor::directionToString):
+            Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
+            exception previously generated with ASSERT_NOT_REACHED.
+        * Modules/indexeddb/IDBCursor.h:
+        * Modules/indexeddb/IDBTransaction.cpp:
+        (WebCore::IDBTransaction::mode):
+        (WebCore::IDBTransaction::modeToString):
+            Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
+            exception previously generated with ASSERT_NOT_REACHED.
+        * Modules/indexeddb/IDBTransaction.h:
+
 2013-02-09  Kondapally Kalyan  <kalyan.kondapally@intel.com>
 

trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp

@@ -96 +96 @@
 {
     IDB_TRACE("IDBCursor::direction");
-    return directionToString(m_direction, ASSERT_NO_EXCEPTION);
+    return directionToString(m_direction);
 }
 
@@ -314 +314 @@
 }
 
-const AtomicString& IDBCursor::directionToString(unsigned short direction, ExceptionCode& ec)
+const AtomicString& IDBCursor::directionToString(unsigned short direction)
 {
     switch (direction) {
@@ -330 +330 @@
 
     default:
-        ec = TypeError;
+        ASSERT_NOT_REACHED();
         return IDBCursor::directionNext();
     }

trunk/Source/WebCore/Modules/indexeddb/IDBCursor.h

@@ -63 +63 @@
 
     static IDBCursor::Direction stringToDirection(const String& modeString, ScriptExecutionContext*, ExceptionCode&);
-    static const AtomicString& directionToString(unsigned short mode, ExceptionCode&);
+    static const AtomicString& directionToString(unsigned short mode);
 
     static PassRefPtr<IDBCursor> create(PassRefPtr<IDBCursorBackendInterface>, Direction, IDBRequest*, IDBAny* source, IDBTransaction*);

trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp

@@ -123 +123 @@
 const String& IDBTransaction::mode() const
 {
-    return modeToString(m_mode, ASSERT_NO_EXCEPTION);
+    return modeToString(m_mode);
 }
 
@@ -348 +348 @@
 }
 
-const AtomicString& IDBTransaction::modeToString(IDBTransaction::Mode mode, ExceptionCode& ec)
+const AtomicString& IDBTransaction::modeToString(IDBTransaction::Mode mode)
 {
     switch (mode) {
@@ -364 +364 @@
 
     default:
-        ec = TypeError;
+        ASSERT_NOT_REACHED();
         return IDBTransaction::modeReadOnly();
     }

trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h

@@ -69 +69 @@
 
     static Mode stringToMode(const String&, ScriptExecutionContext*, ExceptionCode&);
-    static const AtomicString& modeToString(Mode, ExceptionCode&);
+    static const AtomicString& modeToString(Mode);
 
     IDBDatabaseBackendInterface* backendDB() const;