Changeset 142382 in webkit


Ignore:
Timestamp:
Feb 9, 2013 3:06:00 PM (11 years ago)
Author:
dmazzoni@google.com
Message:

AX: move isIgnored caching to AXObject
https://bugs.webkit.org/show_bug.cgi?id=109322

Reviewed by Chris Fleizach.

There's some benefit to caching accessibilityIsIgnored
(using AXComputedObjectAttributeCache) for more than just
AXRenderObject, so move the caching code to AXObject.

AXObject now has a protected virtual method
computeAccessibilityIsIgnored, and all subclasses
override that instead.

No new tests.

  • accessibility/AccessibilityImageMapLink.h:

(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityList.h:

(AccessibilityList):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityListBox.h:

(AccessibilityListBox):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityListBoxOption.h:

(AccessibilityListBoxOption):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMediaControls.h:

(AccessibilityMediaControl):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(AccessibilityMediaTimeDisplay):

  • accessibility/AccessibilityMenuList.h:

(WebCore::AccessibilityMenuList::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListOption.h:

(AccessibilityMenuListOption):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListPopup.h:

(AccessibilityMenuListPopup):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibilityIsIgnored):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityProgressIndicator.h:

(AccessibilityProgressIndicator):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityScrollView.h:

(AccessibilityScrollView):

  • accessibility/AccessibilityScrollbar.h:

(WebCore::AccessibilityScrollbar::computeAccessibilityIsIgnored):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):

  • accessibility/AccessibilitySlider.h:

(AccessibilitySlider):
(AccessibilitySliderThumb):

  • accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySpinButtonPart::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTable.h:

(AccessibilityTable):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.h:

(AccessibilityTableCell):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableColumn.h:

(AccessibilityTableColumn):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableHeaderContainer.h:

(AccessibilityTableHeaderContainer):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableRow.h:

(AccessibilityTableRow):

Location:
trunk/Source/WebCore
Files:
39 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r142381 r142382  
     12013-02-09  Dominic Mazzoni  <dmazzoni@google.com>
     2
     3        AX: move isIgnored caching to AXObject
     4        https://bugs.webkit.org/show_bug.cgi?id=109322
     5
     6        Reviewed by Chris Fleizach.
     7
     8        There's some benefit to caching accessibilityIsIgnored
     9        (using AXComputedObjectAttributeCache) for more than just
     10        AXRenderObject, so move the caching code to AXObject.
     11
     12        AXObject now has a protected virtual method
     13        computeAccessibilityIsIgnored, and all subclasses
     14        override that instead.
     15
     16        No new tests.
     17
     18        * accessibility/AccessibilityImageMapLink.h:
     19        (AccessibilityImageMapLink):
     20        (WebCore::AccessibilityImageMapLink::computeAccessibilityIsIgnored):
     21        * accessibility/AccessibilityList.cpp:
     22        (WebCore::AccessibilityList::computeAccessibilityIsIgnored):
     23        * accessibility/AccessibilityList.h:
     24        (AccessibilityList):
     25        * accessibility/AccessibilityListBox.cpp:
     26        (WebCore::AccessibilityListBox::computeAccessibilityIsIgnored):
     27        * accessibility/AccessibilityListBox.h:
     28        (AccessibilityListBox):
     29        * accessibility/AccessibilityListBoxOption.cpp:
     30        (WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):
     31        * accessibility/AccessibilityListBoxOption.h:
     32        (AccessibilityListBoxOption):
     33        * accessibility/AccessibilityMediaControls.cpp:
     34        (WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
     35        (WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):
     36        * accessibility/AccessibilityMediaControls.h:
     37        (AccessibilityMediaControl):
     38        (WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
     39        (AccessibilityMediaTimeDisplay):
     40        * accessibility/AccessibilityMenuList.h:
     41        (WebCore::AccessibilityMenuList::computeAccessibilityIsIgnored):
     42        * accessibility/AccessibilityMenuListOption.cpp:
     43        (WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):
     44        * accessibility/AccessibilityMenuListOption.h:
     45        (AccessibilityMenuListOption):
     46        * accessibility/AccessibilityMenuListPopup.cpp:
     47        (WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):
     48        * accessibility/AccessibilityMenuListPopup.h:
     49        (AccessibilityMenuListPopup):
     50        * accessibility/AccessibilityNodeObject.cpp:
     51        (WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):
     52        * accessibility/AccessibilityNodeObject.h:
     53        (AccessibilityNodeObject):
     54        * accessibility/AccessibilityObject.cpp:
     55        (WebCore::AccessibilityObject::accessibilityIsIgnored):
     56        (WebCore):
     57        * accessibility/AccessibilityObject.h:
     58        (AccessibilityObject):
     59        (WebCore::AccessibilityObject::computeAccessibilityIsIgnored):
     60        * accessibility/AccessibilityProgressIndicator.cpp:
     61        (WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):
     62        * accessibility/AccessibilityProgressIndicator.h:
     63        (AccessibilityProgressIndicator):
     64        * accessibility/AccessibilityRenderObject.cpp:
     65        (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
     66        * accessibility/AccessibilityRenderObject.h:
     67        (AccessibilityRenderObject):
     68        * accessibility/AccessibilityScrollView.cpp:
     69        (WebCore::AccessibilityScrollView::computeAccessibilityIsIgnored):
     70        * accessibility/AccessibilityScrollView.h:
     71        (AccessibilityScrollView):
     72        * accessibility/AccessibilityScrollbar.h:
     73        (WebCore::AccessibilityScrollbar::computeAccessibilityIsIgnored):
     74        * accessibility/AccessibilitySlider.cpp:
     75        (WebCore::AccessibilitySlider::computeAccessibilityIsIgnored):
     76        (WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):
     77        * accessibility/AccessibilitySlider.h:
     78        (AccessibilitySlider):
     79        (AccessibilitySliderThumb):
     80        * accessibility/AccessibilitySpinButton.h:
     81        (WebCore::AccessibilitySpinButton::computeAccessibilityIsIgnored):
     82        (WebCore::AccessibilitySpinButtonPart::computeAccessibilityIsIgnored):
     83        * accessibility/AccessibilityTable.cpp:
     84        (WebCore::AccessibilityTable::computeAccessibilityIsIgnored):
     85        * accessibility/AccessibilityTable.h:
     86        (AccessibilityTable):
     87        * accessibility/AccessibilityTableCell.cpp:
     88        (WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):
     89        * accessibility/AccessibilityTableCell.h:
     90        (AccessibilityTableCell):
     91        * accessibility/AccessibilityTableColumn.cpp:
     92        (WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
     93        * accessibility/AccessibilityTableColumn.h:
     94        (AccessibilityTableColumn):
     95        * accessibility/AccessibilityTableHeaderContainer.cpp:
     96        (WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):
     97        * accessibility/AccessibilityTableHeaderContainer.h:
     98        (AccessibilityTableHeaderContainer):
     99        * accessibility/AccessibilityTableRow.cpp:
     100        (WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored):
     101        * accessibility/AccessibilityTableRow.h:
     102        (AccessibilityTableRow):
     103
    11042013-02-09  David Farler  <dfarler@apple.com>
    2105
  • trunk/Source/WebCore/accessibility/AccessibilityImageMapLink.h

    r131905 r142382  
    5353       
    5454    virtual AccessibilityRole roleValue() const;
    55     virtual bool accessibilityIsIgnored() const { return false; }
    5655    virtual bool isEnabled() const { return true; }
    5756   
     
    7675    virtual void accessibilityText(Vector<AccessibilityText>&);
    7776    virtual bool isImageMapLink() const { return true; }
     77    virtual bool computeAccessibilityIsIgnored() const { return false; }
    7878};
    7979   
  • trunk/Source/WebCore/accessibility/AccessibilityList.cpp

    r140974 r142382  
    5454}
    5555
    56 bool AccessibilityList::accessibilityIsIgnored() const
     56bool AccessibilityList::computeAccessibilityIsIgnored() const
    5757{
    5858    AccessibilityObjectInclusion decision = accessibilityIsIgnoredBase();
  • trunk/Source/WebCore/accessibility/AccessibilityList.h

    r140974 r142382  
    5454
    5555    virtual AccessibilityRole roleValue() const { return ListRole; }
    56     virtual bool accessibilityIsIgnored() const;
    57    
     56private:
     57    virtual bool computeAccessibilityIsIgnored() const;
    5858};
    5959   
  • trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp

    r140658 r142382  
    153153}
    154154   
    155 bool AccessibilityListBox::accessibilityIsIgnored() const
     155bool AccessibilityListBox::computeAccessibilityIsIgnored() const
    156156{
    157157    AccessibilityObjectInclusion decision = accessibilityIsIgnoredBase();
  • trunk/Source/WebCore/accessibility/AccessibilityListBox.h

    r124582 r142382  
    5555private:   
    5656    AccessibilityObject* listBoxOptionAccessibilityObject(HTMLElement*) const;
    57     virtual bool accessibilityIsIgnored() const;
     57    virtual bool computeAccessibilityIsIgnored() const;
    5858    virtual AccessibilityObject* elementAccessibilityHitTest(const IntPoint&) const;
    5959};
  • trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp

    r137168 r142382  
    121121}
    122122
    123 bool AccessibilityListBoxOption::accessibilityIsIgnored() const
     123bool AccessibilityListBoxOption::computeAccessibilityIsIgnored() const
    124124{
    125125    if (!m_optionElement)
  • trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.h

    r100892 r142382  
    5252   
    5353    virtual AccessibilityRole roleValue() const { return ListBoxOptionRole; }
    54     virtual bool accessibilityIsIgnored() const;
    5554    virtual bool isSelected() const;
    5655    virtual bool isEnabled() const;
     
    7473    IntRect listBoxOptionRect() const;
    7574    AccessibilityObject* listBoxOptionAccessibilityObject(HTMLElement*) const;
     75    virtual bool computeAccessibilityIsIgnored() const;
    7676};
    7777   
  • trunk/Source/WebCore/accessibility/AccessibilityMediaControls.cpp

    r140658 r142382  
    174174}
    175175
    176 bool AccessibilityMediaControl::accessibilityIsIgnored() const
     176bool AccessibilityMediaControl::computeAccessibilityIsIgnored() const
    177177{
    178178    if (!m_renderer || !m_renderer->style() || m_renderer->style()->visibility() != VISIBLE || controlType() == MediaTimelineContainer)
     
    301301}
    302302
    303 bool AccessibilityMediaTimeDisplay::accessibilityIsIgnored() const
     303bool AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored() const
    304304{
    305305    if (!m_renderer || !m_renderer->style() || m_renderer->style()->visibility() != VISIBLE)
  • trunk/Source/WebCore/accessibility/AccessibilityMediaControls.h

    r131905 r142382  
    4545
    4646    virtual AccessibilityRole roleValue() const;
    47     virtual bool accessibilityIsIgnored() const;
    4847
    4948    virtual String title() const;
     
    5655    String controlTypeName() const;
    5756    virtual void accessibilityText(Vector<AccessibilityText>&);
     57    virtual bool computeAccessibilityIsIgnored() const;
    5858};
    5959
     
    8383
    8484    virtual AccessibilityRole roleValue() const { return ToolbarRole; }
    85     virtual bool accessibilityIsIgnored() const { return false; }
    8685
    8786    virtual String helpText() const;
     
    9291    bool controllingVideoElement() const;
    9392    const String elementTypeName() const;
     93    virtual bool computeAccessibilityIsIgnored() const { return false; }
    9494};
    9595
     
    102102
    103103    virtual AccessibilityRole roleValue() const { return StaticTextRole; }
    104     virtual bool accessibilityIsIgnored() const;
    105104
    106105    virtual String stringValue() const;
     
    110109    explicit AccessibilityMediaTimeDisplay(RenderObject*);
    111110    virtual bool isMediaControlLabel() const { return true; }
     111    virtual bool computeAccessibilityIsIgnored() const;
    112112};
    113113
  • trunk/Source/WebCore/accessibility/AccessibilityMenuList.h

    r124582 r142382  
    5050    virtual bool isMenuList() const { return true; }
    5151    virtual AccessibilityRole roleValue() const { return PopUpButtonRole; }
    52     virtual bool accessibilityIsIgnored() const { return false; }
     52    virtual bool computeAccessibilityIsIgnored() const { return false; }
    5353    virtual bool canSetFocusAttribute() const;
    5454
  • trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp

    r116376 r142382  
    9797}
    9898
    99 bool AccessibilityMenuListOption::accessibilityIsIgnored() const
     99bool AccessibilityMenuListOption::computeAccessibilityIsIgnored() const
    100100{
    101101    return accessibilityPlatformIncludesObject() != IncludeObject;
  • trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.h

    r116125 r142382  
    3838    static PassRefPtr<AccessibilityMenuListOption> create() { return adoptRef(new AccessibilityMenuListOption); }
    3939
    40     virtual bool accessibilityIsIgnored() const;
    41 
    4240    void setElement(HTMLElement*);
    4341
     
    6058    virtual LayoutRect elementRect() const;
    6159    virtual String stringValue() const;
     60    virtual bool computeAccessibilityIsIgnored() const;
    6261
    6362    RefPtr<HTMLElement> m_element;
  • trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp

    r141783 r142382  
    6363}
    6464
    65 bool AccessibilityMenuListPopup::accessibilityIsIgnored() const
     65bool AccessibilityMenuListPopup::computeAccessibilityIsIgnored() const
    6666{
    6767    return accessibilityPlatformIncludesObject() != IncludeObject;
  • trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h

    r116125 r142382  
    4242    virtual bool isEnabled() const;
    4343    virtual bool isOffScreen() const;
    44     virtual bool accessibilityIsIgnored() const;
    4544
    4645    void didUpdateActiveOption(int optionIndex);
     
    5958    virtual void addChildren();
    6059    virtual void childrenChanged();
     60    virtual bool computeAccessibilityIsIgnored() const;
    6161
    6262    AccessibilityMenuListOption* menuListOptionAccessibilityObject(HTMLElement*) const;
  • trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

    r140660 r142382  
    390390}
    391391
    392 bool AccessibilityNodeObject::accessibilityIsIgnored() const
     392bool AccessibilityNodeObject::computeAccessibilityIsIgnored() const
    393393{
    394394#ifndef NDEBUG
  • trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h

    r140658 r142382  
    166166
    167167    virtual bool canHaveChildren() const;
    168     virtual bool accessibilityIsIgnored() const;
    169168    AccessibilityRole ariaRoleAttribute() const;
    170169    AccessibilityRole determineAriaRoleAttribute() const;
     
    199198    String alternativeTextForWebArea() const;
    200199    void ariaLabeledByText(Vector<AccessibilityText>&) const;
     200    virtual bool computeAccessibilityIsIgnored() const;
    201201};
    202202
  • trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

    r142368 r142382  
    18441844}
    18451845
     1846bool AccessibilityObject::accessibilityIsIgnored() const
     1847{
     1848    AXComputedObjectAttributeCache* attributeCache = axObjectCache()->computedObjectAttributeCache();
     1849    if (attributeCache) {
     1850        AccessibilityObjectInclusion ignored = attributeCache->getIgnored(axObjectID());
     1851        switch (ignored) {
     1852        case IgnoreObject:
     1853            return true;
     1854        case IncludeObject:
     1855            return false;
     1856        case DefaultBehavior:
     1857            break;
     1858        }
     1859    }
     1860
     1861    bool result = computeAccessibilityIsIgnored();
     1862
     1863    if (attributeCache)
     1864        attributeCache->setIgnored(axObjectID(), result ? IgnoreObject : IncludeObject);
     1865
     1866    return result;
     1867}
     1868
    18461869} // namespace WebCore
  • trunk/Source/WebCore/accessibility/AccessibilityObject.h

    r142368 r142382  
    486486    virtual Node* node() const { return 0; }
    487487    virtual RenderObject* renderer() const { return 0; }
    488     virtual bool accessibilityIsIgnored() const  { return true; }
     488    virtual bool accessibilityIsIgnored() const;
    489489
    490490    int blockquoteLevel() const;
     
    834834    AccessibilityRole m_role;
    835835    AccessibilityObjectInclusion m_lastKnownIsIgnoredValue;
    836    
     836
     837    virtual bool computeAccessibilityIsIgnored() const { return true; }
     838
    837839    // If this object itself scrolls, return its ScrollableArea.
    838840    virtual ScrollableArea* getScrollableAreaIfScrollable() const { return 0; }
  • trunk/Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp

    r140658 r142382  
    4343}
    4444
    45 bool AccessibilityProgressIndicator::accessibilityIsIgnored() const
     45bool AccessibilityProgressIndicator::computeAccessibilityIsIgnored() const
    4646{
    4747    return accessibilityIsIgnoredBase() == IgnoreObject;
  • trunk/Source/WebCore/accessibility/AccessibilityProgressIndicator.h

    r124582 r142382  
    4646
    4747    HTMLProgressElement* element() const;
    48     virtual bool accessibilityIsIgnored() const;
     48    virtual bool computeAccessibilityIsIgnored() const;
    4949};
    5050
  • trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

    r142375 r142382  
    11231123
    11241124
    1125 bool AccessibilityRenderObject::accessibilityIsIgnored() const
     1125bool AccessibilityRenderObject::computeAccessibilityIsIgnored() const
    11261126{
    11271127#ifndef NDEBUG
     
    11291129#endif
    11301130
    1131     AXComputedObjectAttributeCache* attributeCache = axObjectCache()->computedObjectAttributeCache();
    1132     if (attributeCache) {
    1133         AccessibilityObjectInclusion ignored = attributeCache->getIgnored(axObjectID());
    1134         switch (ignored) {
    1135         case IgnoreObject:
    1136             return true;
    1137         case IncludeObject:
    1138             return false;
    1139         case DefaultBehavior:
    1140             break;
    1141         }
    1142     }
    1143 
    1144     bool result = computeAccessibilityIsIgnored();
    1145 
    1146     if (attributeCache)
    1147         attributeCache->setIgnored(axObjectID(), result ? IgnoreObject : IncludeObject);
    1148 
    1149     return result;
    1150 }
    1151 
    1152 bool AccessibilityRenderObject::computeAccessibilityIsIgnored() const
    1153 {
    11541131    // Check first if any of the common reasons cause this element to be ignored.
    11551132    // Then process other use cases that need to be applied to all the various roles
  • trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h

    r141655 r142382  
    9595    // Provides common logic used by all elements when determining isIgnored.
    9696    AccessibilityObjectInclusion accessibilityIsIgnoredBase() const;
    97     virtual bool accessibilityIsIgnored() const;
    9897   
    9998    virtual int layoutCount() const;
     
    225224
    226225    virtual AccessibilityRole determineAccessibilityRole();
     226    virtual bool computeAccessibilityIsIgnored() const;
    227227
    228228private:
     
    280280    bool inheritsPresentationalRole() const;
    281281
    282     bool computeAccessibilityIsIgnored() const;
    283    
    284282#if ENABLE(MATHML)
    285283    // All math elements return true for isMathElement().
  • trunk/Source/WebCore/accessibility/AccessibilityScrollView.cpp

    r132699 r142382  
    145145}
    146146
    147 bool AccessibilityScrollView::accessibilityIsIgnored() const
     147bool AccessibilityScrollView::computeAccessibilityIsIgnored() const
    148148{
    149149    AccessibilityObject* webArea = webAreaObject();
  • trunk/Source/WebCore/accessibility/AccessibilityScrollView.h

    r132699 r142382  
    5151    explicit AccessibilityScrollView(ScrollView*);
    5252   
    53     virtual bool accessibilityIsIgnored() const;
     53    virtual bool computeAccessibilityIsIgnored() const;
    5454    virtual bool isAccessibilityScrollView() const { return true; }
    5555    virtual bool isEnabled() const { return true; }
  • trunk/Source/WebCore/accessibility/AccessibilityScrollbar.h

    r124582 r142382  
    4545    explicit AccessibilityScrollbar(Scrollbar*);
    4646
    47     virtual bool accessibilityIsIgnored() const { return false; }
     47    virtual bool computeAccessibilityIsIgnored() const { return false; }
    4848    virtual bool canSetValueAttribute() const { return true; }
    4949    virtual bool canSetNumericValue() const { return true; }
  • trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp

    r140658 r142382  
    114114}
    115115
    116 bool AccessibilitySlider::accessibilityIsIgnored() const
     116bool AccessibilitySlider::computeAccessibilityIsIgnored() const
    117117{
    118118    AccessibilityObjectInclusion decision = accessibilityIsIgnoredBase();
     
    179179}
    180180
    181 bool AccessibilitySliderThumb::accessibilityIsIgnored() const
     181bool AccessibilitySliderThumb::computeAccessibilityIsIgnored() const
    182182{
    183183    AccessibilityObjectInclusion decision = accessibilityPlatformIncludesObject();
  • trunk/Source/WebCore/accessibility/AccessibilitySlider.h

    r124582 r142382  
    4848private:
    4949    HTMLInputElement* element() const;
    50     virtual bool accessibilityIsIgnored() const;
     50    virtual bool computeAccessibilityIsIgnored() const;
    5151    virtual AccessibilityObject* elementAccessibilityHitTest(const IntPoint&) const;
    5252
     
    7878    virtual LayoutRect elementRect() const;
    7979
    80     virtual bool accessibilityIsIgnored() const;
    81 
    8280private:
    8381    AccessibilitySliderThumb();
     82
     83    virtual bool computeAccessibilityIsIgnored() const;
    8484};
    8585
  • trunk/Source/WebCore/accessibility/AccessibilitySpinButton.h

    r125866 r142382  
    4949
    5050    virtual AccessibilityRole roleValue() const { return SpinButtonRole; }
    51     virtual bool accessibilityIsIgnored() const { return false; }
     51    virtual bool computeAccessibilityIsIgnored() const { return false; }
    5252    virtual bool isSpinButton() const { return true; }
    5353    virtual void addChildren();
     
    7373    virtual bool isSpinButtonPart() const { return true; }
    7474    virtual LayoutRect elementRect() const;
    75     virtual bool accessibilityIsIgnored() const { return false; }
     75    virtual bool computeAccessibilityIsIgnored() const { return false; }
    7676};
    7777   
  • trunk/Source/WebCore/accessibility/AccessibilityTable.cpp

    r141783 r142382  
    593593}
    594594   
    595 bool AccessibilityTable::accessibilityIsIgnored() const
     595bool AccessibilityTable::computeAccessibilityIsIgnored() const
    596596{
    597597    AccessibilityObjectInclusion decision = accessibilityIsIgnoredBase();
     
    602602   
    603603    if (!isAccessibilityTable())
    604         return AccessibilityRenderObject::accessibilityIsIgnored();
     604        return AccessibilityRenderObject::computeAccessibilityIsIgnored();
    605605       
    606606    return false;
  • trunk/Source/WebCore/accessibility/AccessibilityTable.h

    r124582 r142382  
    5959    virtual bool isAriaTable() const { return false; }
    6060   
    61     virtual bool accessibilityIsIgnored() const;
    62    
    6361    virtual void addChildren();
    6462    virtual void clearChildren();
     
    9391    bool hasARIARole() const;
    9492    bool isTableExposableThroughAccessibility() const;
     93    virtual bool computeAccessibilityIsIgnored() const;
    9594};
    9695   
  • trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp

    r140658 r142382  
    5555}
    5656
    57 bool AccessibilityTableCell::accessibilityIsIgnored() const
     57bool AccessibilityTableCell::computeAccessibilityIsIgnored() const
    5858{
    5959    AccessibilityObjectInclusion decision = accessibilityIsIgnoredBase();
     
    6464   
    6565    if (!isTableCell())
    66         return AccessibilityRenderObject::accessibilityIsIgnored();
     66        return AccessibilityRenderObject::computeAccessibilityIsIgnored();
    6767   
    6868    return false;
  • trunk/Source/WebCore/accessibility/AccessibilityTableCell.h

    r140340 r142382  
    4444    virtual bool isTableCell() const;
    4545   
    46     virtual bool accessibilityIsIgnored() const;
    47 
    4846    // fills in the start location and row span of cell
    4947    virtual void rowIndexRange(pair<int, int>& rowRange);
     
    6058    virtual AccessibilityObject* titleUIElement() const;
    6159    virtual bool exposesTitleUIElement() const { return true; }
     60    virtual bool computeAccessibilityIsIgnored() const;
    6261};
    6362   
  • trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp

    r114031 r142382  
    153153}
    154154   
    155 bool AccessibilityTableColumn::accessibilityIsIgnored() const
     155bool AccessibilityTableColumn::computeAccessibilityIsIgnored() const
    156156{
    157157    if (!m_parent)
  • trunk/Source/WebCore/accessibility/AccessibilityTableColumn.h

    r114031 r142382  
    4848    AccessibilityObject* headerObject();
    4949       
    50     virtual bool accessibilityIsIgnored() const;
    5150    virtual AccessibilityRole roleValue() const { return ColumnRole; }
    5251    virtual bool isTableColumn() const { return true; }
     
    6564   
    6665    AccessibilityObject* headerObjectForSection(RenderTableSection*, bool thTagRequired);
     66    virtual bool computeAccessibilityIsIgnored() const;
    6767};
    6868   
  • trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp

    r114031 r142382  
    5656}
    5757
    58 bool AccessibilityTableHeaderContainer::accessibilityIsIgnored() const
     58bool AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored() const
    5959{
    6060    if (!m_parent)
  • trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.h

    r114031 r142382  
    5353    LayoutRect m_headerRect;
    5454   
    55     virtual bool accessibilityIsIgnored() const;
     55    virtual bool computeAccessibilityIsIgnored() const;
    5656};
    5757   
  • trunk/Source/WebCore/accessibility/AccessibilityTableRow.cpp

    r140658 r142382  
    8787}
    8888   
    89 bool AccessibilityTableRow::accessibilityIsIgnored() const
     89bool AccessibilityTableRow::computeAccessibilityIsIgnored() const
    9090{   
    9191    AccessibilityObjectInclusion decision = accessibilityIsIgnoredBase();
     
    9696   
    9797    if (!isTableRow())
    98         return AccessibilityRenderObject::accessibilityIsIgnored();
     98        return AccessibilityRenderObject::computeAccessibilityIsIgnored();
    9999
    100100    return false;
  • trunk/Source/WebCore/accessibility/AccessibilityTableRow.h

    r140095 r142382  
    4343   
    4444    virtual bool isTableRow() const;
    45     virtual bool accessibilityIsIgnored() const;
    4645
    4746    // retrieves the "row" header (a th tag in the rightmost column)
     
    6362   
    6463    virtual AccessibilityObject* observableObject() const;
     64    virtual bool computeAccessibilityIsIgnored() const;
    6565};
    6666   
Note: See TracChangeset for help on using the changeset viewer.