Changeset 142391 in webkit

Timestamp:

Feb 10, 2013 2:00:29 AM (11 years ago)

Author:

Philippe Normand

Message:

[GStreamer] audio is muted when playback rate is between 0.8 and 2.0
​https://bugs.webkit.org/show_bug.cgi?id=109362

Reviewed by Martin Robinson.

Don't mute sound if the audio pitch is preserved. If this is not
the case mute it if it's too extreme, as the HTML5 spec recommends.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setRate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-10  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] audio is muted when playback rate is between 0.8 and 2.0
+        https://bugs.webkit.org/show_bug.cgi?id=109362
+
+        Reviewed by Martin Robinson.
+
+        Don't mute sound if the audio pitch is preserved. If this is not
+        the case mute it if it's too extreme, as the HTML5 spec recommends.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::setRate):
+
 2013-02-09  Dominic Mazzoni  <dmazzoni@google.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -542 +542 @@
     LOG_MEDIA_MESSAGE("Set Rate to %f", rate);
     if (rate > 0) {
-        // Mute the sound if the playback rate is too extreme.
-        // TODO: in other cases we should perform pitch adjustments.
-        mute = (bool) (rate < 0.8 || rate > 2);
+        // Mute the sound if the playback rate is too extreme and
+        // audio pitch is not adjusted.
+        mute = (!m_preservesPitch && (rate < 0.8 || rate > 2));
         start = currentPosition;
         end = GST_CLOCK_TIME_NONE;