Changeset 142395 in webkit


Ignore:
Timestamp:
Feb 10, 2013 3:23:23 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
​https://bugs.webkit.org/show_bug.cgi?id=104266

Patch by Jae Hyun Park <​jae.park08@gmail.com> on 2013-02-10
Reviewed by Philippe Normand.

Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
the existing macro naming conventions.

From Platform.h
USE() - use a particular third-party library or optional OS service
ENABLE() - turn on a specific feature of WebKit

.:

  • Source/autotools/SetupAutoconfHeader.m4:
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

No new tests, no new functionality.

  • WebCore.pri:

Source/WebKit/gtk:

  • gyp/Configuration.gypi:

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):

  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:

Source/WTF:

  • WTF.pri:
  • wtf/Platform.h:
  • wtf/gobject/GOwnPtr.cpp:
  • wtf/gobject/GOwnPtr.h:
  • wtf/gobject/GRefPtr.cpp:
  • wtf/gobject/GRefPtr.h:
Location:
trunk
Files:
18 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r142352 r142395  
     12013-02-10  Jae Hyun Park  <jae.park08@gmail.com>
     2
     3        Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
     4        https://bugs.webkit.org/show_bug.cgi?id=104266
     5
     6        Reviewed by Philippe Normand.
     7
     8        Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
     9        the existing macro naming conventions.
     10
     11        From Platform.h
     12        USE() - use a particular third-party library or optional OS service
     13        ENABLE() - turn on a specific feature of WebKit
     14
     15        * Source/autotools/SetupAutoconfHeader.m4:
     16        * Source/cmake/OptionsEfl.cmake:
     17
    1182013-02-09  Philippe Normand  <pnormand@igalia.com>
    219

  • trunk/Source/WTF/ChangeLog

    r142336 r142395  
     12013-02-10  Jae Hyun Park  <jae.park08@gmail.com>
     2
     3        Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
     4        https://bugs.webkit.org/show_bug.cgi?id=104266
     5
     6        Reviewed by Philippe Normand.
     7
     8        Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
     9        the existing macro naming conventions.
     10
     11        From Platform.h
     12        USE() - use a particular third-party library or optional OS service
     13        ENABLE() - turn on a specific feature of WebKit
     14
     15        * WTF.pri:
     16        * wtf/Platform.h:
     17        * wtf/gobject/GOwnPtr.cpp:
     18        * wtf/gobject/GOwnPtr.h:
     19        * wtf/gobject/GRefPtr.cpp:
     20        * wtf/gobject/GRefPtr.h:
     21
    1222013-02-08  Michael Saboff  <msaboff@apple.com>
    223

  • trunk/Source/WTF/WTF.pri

    r133896 r142395  
    2222
    2323linux-*:use?(GSTREAMER) {
    24     DEFINES += ENABLE_GLIB_SUPPORT=1
     24    DEFINES += WTF_USE_GLIB=1
    2525    PKGCONFIG += glib-2.0 gio-2.0
    2626}

  • trunk/Source/WTF/wtf/Platform.h

    r142327 r142395  
    11221122#endif
    11231123
    1124 #if ENABLE(GLIB_SUPPORT)
     1124#if USE(GLIB)
    11251125#include <wtf/gobject/GTypedefs.h>
    11261126#endif

  • trunk/Source/WTF/wtf/gobject/GOwnPtr.cpp

    r111778 r142395  
    2020#include "GOwnPtr.h"
    2121
    22 #if ENABLE(GLIB_SUPPORT)
     22#if USE(GLIB)
    2323
    2424#include <gio/gio.h>
    … …  
    6969} // namespace WTF
    7070
    71 #endif // ENABLE(GLIB_SUPPORT)
     71#endif // USE(GLIB)

  • trunk/Source/WTF/wtf/gobject/GOwnPtr.h

    r111778 r142395  
    2323#define GOwnPtr_h
    2424
    25 #if ENABLE(GLIB_SUPPORT)
     25#if USE(GLIB)
    2626
    2727#include <algorithm>
    … …  
    139139using WTF::GOwnPtr;
    140140
    141 #endif // ENABLE(GLIB_SUPPORT)
     141#endif // USE(GLIB)
    142142
    143143#endif // GOwnPtr_h

  • trunk/Source/WTF/wtf/gobject/GRefPtr.cpp

    r130491 r142395  
    2020#include "GRefPtr.h"
    2121
    22 #if ENABLE(GLIB_SUPPORT)
     22#if USE(GLIB)
    2323
    2424#include <glib.h>
    … …  
    167167} // namespace WTF
    168168
    169 #endif // ENABLE(GLIB_SUPPORT)
     169#endif // USE(GLIB)

  • trunk/Source/WTF/wtf/gobject/GRefPtr.h

    r130491 r142395  
    2424#define WTF_GRefPtr_h
    2525
    26 #if ENABLE(GLIB_SUPPORT)
     26#if USE(GLIB)
    2727
    2828#include <wtf/AlwaysInline.h>
    … …  
    234234using WTF::adoptGRef;
    235235
    236 #endif // ENABLE(GLIB_SUPPORT)
     236#endif // USE(GLIB)
    237237
    238238#endif // WTF_GRefPtr_h

  • trunk/Source/WebCore/ChangeLog

    r142392 r142395  
     12013-02-10  Jae Hyun Park  <jae.park08@gmail.com>
     2
     3        Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
     4        https://bugs.webkit.org/show_bug.cgi?id=104266
     5
     6        Reviewed by Philippe Normand.
     7
     8        Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
     9        the existing macro naming conventions.
     10
     11        From Platform.h
     12        USE() - use a particular third-party library or optional OS service
     13        ENABLE() - turn on a specific feature of WebKit
     14
     15        No new tests, no new functionality.
     16
     17        * WebCore.pri:
     18
    1192013-02-10  Zan Dobersek  <zdobersek@igalia.com>
    220

  • trunk/Source/WebCore/WebCore.pri

    r142143 r142395  
    170170
    171171use?(GSTREAMER) {
    172     DEFINES += ENABLE_GLIB_SUPPORT=1
     172    DEFINES += WTF_USE_GLIB=1
    173173    PKGCONFIG += glib-2.0 gio-2.0 gstreamer-0.10 gstreamer-app-0.10 gstreamer-base-0.10 gstreamer-interfaces-0.10 gstreamer-pbutils-0.10 gstreamer-plugins-base-0.10 gstreamer-video-0.10
    174174}

  • trunk/Source/WebKit/gtk/ChangeLog

    r142348 r142395  
     12013-02-10  Jae Hyun Park  <jae.park08@gmail.com>
     2
     3        Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
     4        https://bugs.webkit.org/show_bug.cgi?id=104266
     5
     6        Reviewed by Philippe Normand.
     7
     8        Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
     9        the existing macro naming conventions.
     10
     11        From Platform.h
     12        USE() - use a particular third-party library or optional OS service
     13        ENABLE() - turn on a specific feature of WebKit
     14
     15        * gyp/Configuration.gypi:
     16
    1172013-02-08  Benjamin Poulain  <bpoulain@apple.com>
    218

  • trunk/Source/WebKit/gtk/gyp/Configuration.gypi

    r142298 r142395  
    66    'javascriptcore_soname_version': '0.13.8',
    77    'default_defines': [
    8       'ENABLE_GLIB_SUPPORT=1',
     8      'WTF_USE_GLIB=1',
    99      'BUILDING_CAIRO__=1',
    1010      'BUILDING_GTK__=1',

  • trunk/Source/WebKit/mac/ChangeLog

    r142348 r142395  
     12013-02-10  Jae Hyun Park  <jae.park08@gmail.com>
     2
     3        Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
     4        https://bugs.webkit.org/show_bug.cgi?id=104266
     5
     6        Reviewed by Philippe Normand.
     7
     8        Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
     9        the existing macro naming conventions.
     10
     11        From Platform.h
     12        USE() - use a particular third-party library or optional OS service
     13        ENABLE() - turn on a specific feature of WebKit
     14
     15        * WebView/WebView.mm:
     16        (-[WebView _commonInitializationWithFrameName:groupName:]):
     17        (-[WebView _close]):
     18        * WebView/WebViewData.h:
     19        * WebView/WebViewInternal.h:
     20
    1212013-02-08  Benjamin Poulain  <bpoulain@apple.com>
    222

  • trunk/Source/WebKit/mac/WebView/WebView.mm

    r142225 r142395  
    201201#endif
    202202
    203 #if ENABLE(GLIB_SUPPORT)
     203#if USE(GLIB)
    204204#import <glib.h>
    205205#endif
    … …  
    435435- (BOOL)_continuousCheckingAllowed;
    436436- (NSResponder *)_responderForResponderOperations;
    437 #if ENABLE(GLIB_SUPPORT)
     437#if USE(GLIB)
    438438- (void)_clearGlibLoopObserver;
    439439#endif
    … …  
    834834        ResourceHandle::forceContentSniffing();
    835835
    836 #if ENABLE(GLIB_SUPPORT)
     836#if USE(GLIB)
    837837    [self _scheduleGlibContextIterations];
    838838#endif
    … …  
    11491149#endif
    11501150   
    1151 #if ENABLE(GLIB_SUPPORT)
     1151#if USE(GLIB)
    11521152    [self _clearGlibLoopObserver];
    11531153#endif
    … …  
    62066206}
    62076207
    6208 #if ENABLE(GLIB_SUPPORT)
     6208#if USE(GLIB)
    62096209- (void)_clearGlibLoopObserver
    62106210{
    … …  
    65246524#endif
    65256525
    6526 #if ENABLE(GLIB_SUPPORT)
     6526#if USE(GLIB)
    65276527
    65286528static void glibContextIterationCallback(CFRunLoopObserverRef, CFRunLoopActivity, void*)

  • trunk/Source/WebKit/mac/WebView/WebViewData.h

    r127757 r142395  
    189189#endif
    190190
    191 #if ENABLE(GLIB_SUPPORT)
     191#if USE(GLIB)
    192192    CFRunLoopObserverRef glibRunLoopObserver;
    193193#endif

  • trunk/Source/WebKit/mac/WebView/WebViewInternal.h

    r130400 r142395  
    106106#endif
    107107
    108 #if ENABLE(GLIB_SUPPORT)
     108#if USE(GLIB)
    109109- (void)_scheduleGlibContextIterations;
    110110#endif

  • trunk/Source/autotools/SetupAutoconfHeader.m4

    r142284 r142395  
    11# Configuration flags that are used throughout WebKitGTK+.
    2 AC_DEFINE([ENABLE_GLIB_SUPPORT], [1], [ ])
     2AC_DEFINE([WTF_USE_GLIB], [1], [ ])
    33AC_DEFINE([WTF_USE_FREETYPE], [1], [ ])
    44AC_DEFINE([WTF_USE_HARFBUZZ], [1], [ ])

  • trunk/Source/cmake/OptionsEfl.cmake

    r141439 r142395  
    3030set(WTF_USE_SOUP 1)
    3131
    32 add_definitions(-DENABLE_GLIB_SUPPORT=1)
     32add_definitions(-DWTF_USE_GLIB=1)
    3333add_definitions(-DWTF_USE_SOUP=1)
    3434add_definitions(-DWTF_USE_PTHREADS=1)
Note: See TracChangeset for help on using the changeset viewer.