Changeset 142492 in webkit

Timestamp:

Feb 11, 2013 11:48:56 AM (11 years ago)

Author:

abarth@webkit.org

Message:

document.write during window.onload can trigger DumpRenderTree to dump the render tree
​https://bugs.webkit.org/show_bug.cgi?id=109465

Reviewed by Eric Seidel.

Source/WebCore:

This patch is a partial revert of
​http://trac.webkit.org/changeset/142378. It's not safe to call
checkComplete during the load event. We'll need to find another way of
calling checkComplete at the right time.

Test: fast/parser/document-write-during-load.html

• dom/Document.cpp:

(WebCore::Document::decrementActiveParserCount):

LayoutTests:

• fast/parser/document-write-during-load-expected.txt: Added.
• fast/parser/document-write-during-load.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/document-write-during-load-expected.txt (added)
• LayoutTests/fast/parser/document-write-during-load.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-11  Adam Barth  <abarth@webkit.org>
+
+        document.write during window.onload can trigger DumpRenderTree to dump the render tree
+        https://bugs.webkit.org/show_bug.cgi?id=109465
+
+        Reviewed by Eric Seidel.
+
+        * fast/parser/document-write-during-load-expected.txt: Added.
+        * fast/parser/document-write-during-load.html: Added.
+
 2013-02-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-11  Adam Barth  <abarth@webkit.org>
+
+        document.write during window.onload can trigger DumpRenderTree to dump the render tree
+        https://bugs.webkit.org/show_bug.cgi?id=109465
+
+        Reviewed by Eric Seidel.
+
+        This patch is a partial revert of
+        http://trac.webkit.org/changeset/142378. It's not safe to call
+        checkComplete during the load event. We'll need to find another way of
+        calling checkComplete at the right time.
+
+        Test: fast/parser/document-write-during-load.html
+
+        * dom/Document.cpp:
+        (WebCore::Document::decrementActiveParserCount):
+
 2013-02-11  Andrey Kosyakov  <caseq@chromium.org>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -5772 +5772 @@
 bool Document::hasActiveParser()
 {
-    return m_activeParserCount || (m_parser && m_parser->processingData());
+    return m_parser && m_parser->processingData();
 }
 
@@ -5778 +5778 @@
 {
     --m_activeParserCount;
-    if (!frame())
-        return;
-    frame()->loader()->checkLoadComplete();
 }