Changeset 142594 in webkit

Timestamp:

Feb 12, 2013 1:20:48 AM (11 years ago)

Author:

yurys@chromium.org

Message:

Web Inspector: stack trace is cut at native bind if inspector is closed
​https://bugs.webkit.org/show_bug.cgi?id=109427

Reviewed by Pavel Feldman.

Source/WebCore:

Only top frame is collected instead of full stack trace when inspector
front-end is closed to avoid expensive operations when exceptions are
thrown.

Test: http/tests/inspector-enabled/console-exception-while-no-inspector.html

• inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

LayoutTests:

Test that stack trace for uncaught exceptions is collected when inspector
front-end is closed.

• http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
• http/tests/inspector-enabled/console-exception-while-no-inspector.html: Added.
• platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt (added)
• LayoutTests/http/tests/inspector-enabled/console-exception-while-no-inspector.html (added)
• LayoutTests/platform/chromium/http/tests/inspector-enabled (added)
• LayoutTests/platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/InspectorConsoleAgent.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-11  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: stack trace is cut at native bind if inspector is closed
+        https://bugs.webkit.org/show_bug.cgi?id=109427
+
+        Reviewed by Pavel Feldman.
+
+        Test that stack trace for uncaught exceptions is collected when inspector
+        front-end is closed.
+
+        * http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
+        * http/tests/inspector-enabled/console-exception-while-no-inspector.html: Added.
+        * platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
+
 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-11  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: stack trace is cut at native bind if inspector is closed
+        https://bugs.webkit.org/show_bug.cgi?id=109427
+
+        Reviewed by Pavel Feldman.
+
+        Only top frame is collected instead of full stack trace when inspector
+        front-end is closed to avoid expensive operations when exceptions are
+        thrown.
+
+        Test: http/tests/inspector-enabled/console-exception-while-no-inspector.html
+
+        * inspector/InspectorConsoleAgent.cpp:
+        (WebCore::InspectorConsoleAgent::addMessageToConsole):
+
 2013-02-12  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp

@@ -189 +189 @@
     }
 
-    addConsoleMessage(adoptPtr(new ConsoleMessage(!isWorkerAgent(), source, type, level, message, scriptId, lineNumber, state, requestIdentifier)));
+    bool canGenerateCallStack = !isWorkerAgent() && m_frontend;
+    addConsoleMessage(adoptPtr(new ConsoleMessage(canGenerateCallStack, source, type, level, message, scriptId, lineNumber, state, requestIdentifier)));
 }