Changeset 142603 in webkit


Ignore:
Timestamp:
Feb 12, 2013 4:04:02 AM (11 years ago)
Author:
caseq@chromium.org
Message:

Web Inspector: fix closure compiler warnings in extension server and API
​https://bugs.webkit.org/show_bug.cgi?id=109563

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ExtensionAPI.js: drive-by: make sure we fail if extensionServer is not defined in outer scope.
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

  • inspector/front-end/externs.js: add extensionServer
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r142598 r142603  
     12013-02-12  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Web Inspector: fix closure compiler warnings in extension server and API
     4        https://bugs.webkit.org/show_bug.cgi?id=109563
     5
     6        Reviewed by Vsevolod Vlasov.
     7
     8        * inspector/front-end/ExtensionAPI.js: drive-by: make sure we fail if extensionServer is not defined in outer scope.
     9        * inspector/front-end/ExtensionServer.js:
     10        (WebInspector.ExtensionServer.prototype.):
     11        (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
     12        * inspector/front-end/externs.js: add extensionServer
     13
    1142013-02-12  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
    215

  • trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js

    r142486 r142603  
    866866var Timeline = declareInterfaceClass(TimelineImpl);
    867867
    868 // Closure variable defined by the glue below.
    869 extensionServer = new ExtensionServerClient();
     868// extensionServer is a closure variable defined by the glue below -- make sure we fail if it's not there.
     869if (!extensionServer)
     870    extensionServer = new ExtensionServerClient();
    870871
    871872return new InspectorExtensionAPI();

  • trunk/Source/WebCore/inspector/front-end/ExtensionServer.js

    r142486 r142603  
    330330        function callback(error, resultPayload, wasThrown)
    331331        {
     332            var result;
    332333            if (error)
    333334                result = this._status.E_PROTOCOLERROR(error.toString());

  • trunk/Source/WebCore/inspector/front-end/externs.js

    r140539 r142603  
    278278function Timeline() {}
    279279
     280var extensionServer;
     281
    280282/** @type {string} */
    281283Location.prototype.origin = "";
Note: See TracChangeset for help on using the changeset viewer.