Changeset 142614 in webkit

Timestamp:

Feb 12, 2013 6:29:10 AM (11 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Introduce version controller to migrate settings versions.
​https://bugs.webkit.org/show_bug.cgi?id=109553

Reviewed by Yury Semikhatsky.

Source/WebCore:

This patch introduces version controller that could be used to migrate inspector settings.

Test: inspector/version-controller.html

• inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.VersionController):
(WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
(WebInspector.VersionController.prototype._updateVersionFrom0To1):

• inspector/front-end/inspector.js:

LayoutTests:

• inspector/version-controller-expected.txt: Added.
• inspector/version-controller.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/version-controller-expected.txt (added)
• LayoutTests/inspector/version-controller.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/Settings.js (modified) (2 diffs)
• Source/WebCore/inspector/front-end/inspector.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-12  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Introduce version controller to migrate settings versions.
+        https://bugs.webkit.org/show_bug.cgi?id=109553
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/version-controller-expected.txt: Added.
+        * inspector/version-controller.html: Added.
+
 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-12  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Introduce version controller to migrate settings versions.
+        https://bugs.webkit.org/show_bug.cgi?id=109553
+
+        Reviewed by Yury Semikhatsky.
+
+        This patch introduces version controller that could be used to migrate inspector settings.
+
+        Test: inspector/version-controller.html
+
+        * inspector/front-end/Settings.js:
+        (WebInspector.Settings):
+        (WebInspector.VersionController):
+        (WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
+        (WebInspector.VersionController.prototype._updateVersionFrom0To1):
+        * inspector/front-end/inspector.js:
+
 2013-02-12  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/Settings.js

@@ -124 +124 @@
     this.workerInspectorHeight = this.createSetting("workerInspectorHeight", 600);
     this.messageURLFilters = this.createSetting("messageURLFilters", {});
-
-    // If there are too many breakpoints in a storage, it is likely due to a recent bug that caused
-    // periodical breakpoints duplication leading to inspector slowness.
-    if (this.breakpoints.get().length > 500000)
-        this.breakpoints.set([]);
 }
 
@@ -352 +347 @@
 }
 
+/**
+ * @constructor
+ */
+WebInspector.VersionController = function()
+{
+}
+
+WebInspector.VersionController.currentVersion = 1;
+
+WebInspector.VersionController.prototype = {
+    updateVersion: function()
+    {
+        var versionSetting = WebInspector.settings.createSetting("inspectorVersion", 0);
+        var currentVersion = WebInspector.VersionController.currentVersion;
+        var oldVersion = versionSetting.get();
+        var methodsToRun = this._methodsToRunToUpdateVersion(oldVersion, currentVersion);
+        for (var i = 0; i < methodsToRun.length; ++i)
+            this[methodsToRun[i]].call(this);
+        versionSetting.set(currentVersion);
+    },
+
+    /**
+     * @param {number} oldVersion
+     * @param {number} currentVersion
+     */
+    _methodsToRunToUpdateVersion: function(oldVersion, currentVersion)
+    {
+        var result = [];
+        for (var i = oldVersion; i < currentVersion; ++i)
+            result.push("_updateVersionFrom" + i + "To" + (i + 1));
+        return result;
+    },
+
+    _updateVersionFrom0To1: function()
+    {
+        this._clearBreakpointsWhenTooMany(WebInspector.settings.breakpoints);
+    },
+
+    /**
+     * @param {WebInspector.Setting} breakpointsSetting
+     */
+    _clearBreakpointsWhenTooMany: function(breakpointsSetting)
+    {
+        // If there are too many breakpoints in a storage, it is likely due to a recent bug that caused
+        // periodical breakpoints duplication leading to inspector slowness.
+        if (breakpointsSetting.get().length > 500000)
+            breakpointsSetting.set([]);
+    }
+}
+
 WebInspector.settings = new WebInspector.Settings();
 WebInspector.experimentsSettings = new WebInspector.ExperimentsSettings();

trunk/Source/WebCore/inspector/front-end/inspector.js

@@ -382 +382 @@
 WebInspector._doLoadedDoneWithCapabilities = function()
 {
+    new WebInspector.VersionController().updateVersion();
+
     WebInspector.shortcutsScreen = new WebInspector.ShortcutsScreen();
     this._registerShortcuts();