Changeset 142718 in webkit

Timestamp:

Feb 12, 2013 9:17:18 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Remove unnecessary and confusing includes from StreamBuffer.h.
​https://bugs.webkit.org/show_bug.cgi?id=109652

Patch by Takeshi Yoshino <​tyoshino@google.com> on 2013-02-12
Reviewed by Benjamin Poulain.

StreamBuffer.h is using OwnPtr for storing Vectors into a Deque.
FixedArray.h and PassOwnPtr.h are included but not used.

VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy.
So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > >
is even slower).

• wtf/StreamBuffer.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/StreamBuffer.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-02-12  Takeshi Yoshino  <tyoshino@google.com>
+
+        Remove unnecessary and confusing includes from StreamBuffer.h.
+        https://bugs.webkit.org/show_bug.cgi?id=109652
+
+        Reviewed by Benjamin Poulain.
+
+        StreamBuffer.h is using OwnPtr for storing Vectors into a Deque.
+        FixedArray.h and PassOwnPtr.h are included but not used.
+
+        VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy.
+        So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > >
+        is even slower).
+
+        * wtf/StreamBuffer.h:
+
 2013-02-12  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WTF/wtf/StreamBuffer.h

@@ -33 +33 @@
 
 #include <wtf/Deque.h>
-#include <wtf/FixedArray.h>
 #include <wtf/OwnPtr.h>
-#include <wtf/PassOwnPtr.h>
 
 namespace WTF {