Changeset 142770 in webkit


Ignore:
Timestamp:
Feb 13, 2013 12:11:43 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

WebKit ignores column-rules wider than column-gap
​https://bugs.webkit.org/show_bug.cgi?id=15553

Paint column rules even if they are wider than the gap.
Rules wider than the gap should just overlap with column contents.

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-02-13
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/rule-thicker-than-gap.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):

LayoutTests:

  • fast/multicol/rule-thicker-than-gap-expected.html: Added.
  • fast/multicol/rule-thicker-than-gap.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r142765 r142770  
     12013-02-13  Morten Stenshorne  <mstensho@opera.com>
     2
     3        WebKit ignores column-rules wider than column-gap
     4        https://bugs.webkit.org/show_bug.cgi?id=15553
     5
     6        Paint column rules even if they are wider than the gap.
     7        Rules wider than the gap should just overlap with column contents.
     8
     9        Reviewed by Eric Seidel.
     10
     11        * fast/multicol/rule-thicker-than-gap-expected.html: Added.
     12        * fast/multicol/rule-thicker-than-gap.html: Added.
     13
    1142013-02-13  Philip Rogers  <pdr@google.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r142765 r142770  
     12013-02-13  Morten Stenshorne  <mstensho@opera.com>
     2
     3        WebKit ignores column-rules wider than column-gap
     4        https://bugs.webkit.org/show_bug.cgi?id=15553
     5
     6        Paint column rules even if they are wider than the gap.
     7        Rules wider than the gap should just overlap with column contents.
     8
     9        Reviewed by Eric Seidel.
     10
     11        Test: fast/multicol/rule-thicker-than-gap.html
     12
     13        * rendering/RenderBlock.cpp:
     14        (WebCore::RenderBlock::paintColumnRules):
     15
    1162013-02-13  Philip Rogers  <pdr@google.com>
    217

  • trunk/Source/WebCore/rendering/RenderBlock.cpp

    r142657 r142770  
    28062806    LayoutUnit ruleThickness = style()->columnRuleWidth();
    28072807    LayoutUnit colGap = columnGap();
    2808     bool renderRule = ruleStyle > BHIDDEN && !ruleTransparent && ruleThickness <= colGap;
     2808    bool renderRule = ruleStyle > BHIDDEN && !ruleTransparent;
    28092809    if (!renderRule)
    28102810        return;
Note: See TracChangeset for help on using the changeset viewer.