Changeset 142787 in webkit

Timestamp:

Feb 13, 2013 1:33:18 PM (11 years ago)

Author:

arko@motorola.com

Message:

[Microdata] HTMLPropertiesCollection code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=109721

Reviewed by Ryosuke Niwa.

Removed forward declaration of DOMStringList class.
Removed unused findRefElements() method declaration.
Also Removed unused parameter Element* from updatePropertyCache() method.

No new test since no change in behavior.

• html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::updateNameCache):

• html/HTMLPropertiesCollection.h:

(WebCore):
(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLPropertiesCollection.cpp (modified) (2 diffs)
• html/HTMLPropertiesCollection.h (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-13  Arko Saha  <arko@motorola.com>
+
+        [Microdata] HTMLPropertiesCollection code cleanup
+        https://bugs.webkit.org/show_bug.cgi?id=109721
+
+        Reviewed by Ryosuke Niwa.
+
+        Removed forward declaration of DOMStringList class.
+        Removed unused findRefElements() method declaration.
+        Also Removed unused parameter Element* from updatePropertyCache() method.
+
+        No new test since no change in behavior.
+
+        * html/HTMLPropertiesCollection.cpp:
+        (WebCore::HTMLPropertiesCollection::updateNameCache):
+        * html/HTMLPropertiesCollection.h:
+        (WebCore):
+        (HTMLPropertiesCollection):
+        (WebCore::HTMLPropertiesCollection::updatePropertyCache):
+
 2013-02-13  Kondapally Kalyan  <kalyan.kondapally@intel.com>
 

trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp

@@ -36 +36 @@
 
 #include "DOMSettableTokenList.h"
-#include "DOMStringList.h"
 #include "HTMLElement.h"
 #include "HTMLNames.h"
@@ -123 +122 @@
             DOMSettableTokenList* itemProperty = element->itemProp();
             for (unsigned propertyIndex = 0; propertyIndex < itemProperty->length(); ++propertyIndex)
-                updatePropertyCache(element, itemProperty->item(propertyIndex));
+                updatePropertyCache(itemProperty->item(propertyIndex));
         }
     }

trunk/Source/WebCore/html/HTMLPropertiesCollection.h

@@ -39 +39 @@
 namespace WebCore {
 
-class DOMStringList;
 class PropertyNodeList;
 
@@ -62 +61 @@
     HTMLPropertiesCollection(Node*);
 
-    Node* findRefElements(Node* previous) const;
-
     virtual Element* virtualItemAfter(unsigned& offsetInArray, Element*) const OVERRIDE;
     HTMLElement* virtualItemAfter(HTMLElement* base, Element* previous) const;
@@ -69 +66 @@
     void updateNameCache() const;
 
-    void updatePropertyCache(Element*, const AtomicString& propertyName) const
+    void updatePropertyCache(const AtomicString& propertyName) const
     {
         if (!m_propertyNames)