Changeset 142807 in webkit

Timestamp:

Feb 13, 2013 2:54:11 PM (11 years ago)

Author:

abarth@webkit.org

Message:

Remove bogus ASSERT in WebFrameProxy::didStartProvisionalLoad
​https://bugs.webkit.org/show_bug.cgi?id=109733

Reviewed by Sam Weinig.

After ​http://trac.webkit.org/changeset/142555, this ASSERT is
triggering on these tests:

fast/dom/window-load-crash.html
fast/frames/seamless/seamless-hyperlink-named.html
fast/frames/seamless/seamless-hyperlink.html

The ASSERT appears to be bogus. This patch removes it.

• UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebFrameProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-02-13  Adam Barth  <abarth@webkit.org>
+
+        Remove bogus ASSERT in WebFrameProxy::didStartProvisionalLoad
+        https://bugs.webkit.org/show_bug.cgi?id=109733
+
+        Reviewed by Sam Weinig.
+
+        After http://trac.webkit.org/changeset/142555, this ASSERT is
+        triggering on these tests:
+
+        fast/dom/window-load-crash.html
+        fast/frames/seamless/seamless-hyperlink-named.html
+        fast/frames/seamless/seamless-hyperlink.html
+
+        The ASSERT appears to be bogus. This patch removes it.
+
+        * UIProcess/WebFrameProxy.cpp:
+        (WebKit::WebFrameProxy::didStartProvisionalLoad):
+
 2013-02-13  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp

@@ -130 +130 @@
 void WebFrameProxy::didStartProvisionalLoad(const String& url)
 {
-    ASSERT(m_loadState == LoadStateFinished);
     ASSERT(m_provisionalURL.isEmpty());
     m_loadState = LoadStateProvisional;