Changeset 142890 in webkit

Timestamp:

Feb 14, 2013 10:17:54 AM (11 years ago)

Author:

dgrogan@chromium.org

Message:

IndexedDB: Add a few more histogram calls
​https://bugs.webkit.org/show_bug.cgi?id=109762

Reviewed by Tony Chang.

A few places where commits could fail weren't being logged.

• Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::Transaction::commit):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/IDBBackingStore.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-14  David Grogan  <dgrogan@chromium.org>
+
+        IndexedDB: Add a few more histogram calls
+        https://bugs.webkit.org/show_bug.cgi?id=109762
+
+        Reviewed by Tony Chang.
+
+        A few places where commits could fail weren't being logged.
+
+        * Modules/indexeddb/IDBBackingStore.cpp:
+        (WebCore::IDBBackingStore::deleteDatabase):
+        (WebCore::IDBBackingStore::Transaction::commit):
+
 2013-02-14  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp

@@ -72 +72 @@
     GetNewVersionNumber,
     CreateIDBDatabaseMetaData,
+    DeleteDatabase,
+    TransactionCommit,
     IDBLevelDBBackingStoreInternalErrorMax,
 };
@@ -588 +590 @@
     transaction->remove(key);
 
-    return transaction->commit();
+    if (!transaction->commit()) {
+        INTERNAL_WRITE_ERROR(DeleteDatabase);
+        return false;
+    }
+    return true;
 }
 
@@ -1844 +1850 @@
     bool result = m_transaction->commit();
     m_transaction.clear();
+    if (!result)
+        INTERNAL_WRITE_ERROR(TransactionCommit);
     return result;
 }