Changeset 142907 in webkit

Timestamp:

Feb 14, 2013 1:34:00 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r142825.
​http://trac.webkit.org/changeset/142825
​https://bugs.webkit.org/show_bug.cgi?id=109856

Causes some inspector tests to time out (Requested by anttik
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-14

• platform/mac/SharedTimerMac.mm:

(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/SharedTimerMac.mm (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-14  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r142825.
+        http://trac.webkit.org/changeset/142825
+        https://bugs.webkit.org/show_bug.cgi?id=109856
+
+        Causes some inspector tests to time out (Requested by anttik
+        on #webkit).
+
+        * platform/mac/SharedTimerMac.mm:
+        (WebCore):
+        (WebCore::PowerObserver::restartSharedTimer):
+        (WebCore::setSharedTimerFireInterval):
+        (WebCore::stopSharedTimer):
+
 2013-02-14  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
 

trunk/Source/WebCore/platform/mac/SharedTimerMac.mm

@@ -43 +43 @@
 namespace WebCore {
 
-static const CFTimeInterval distantFuture = 60 * 60 * 24 * 365 * 10; // Decade.
-
+static CFRunLoopTimerRef sharedTimer;
 static void (*sharedTimerFiredFunction)();
 static void timerFired(CFRunLoopTimerRef, void*);
@@ -145 +144 @@
     ASSERT(CFRunLoopGetCurrent() == CFRunLoopGetMain());
 
+    if (!sharedTimer)
+        return;
+
     stopSharedTimer();
     timerFired(0, 0);
 }
 
-static CFRunLoopTimerRef sharedTimer()
-{
-    static CFRunLoopTimerRef timer;
-    static dispatch_once_t onceToken;
-    dispatch_once(&onceToken, ^{
-        timer = CFRunLoopTimerCreate(0, CFAbsoluteTimeGetCurrent() + distantFuture, distantFuture, 0, 0, timerFired, 0);
-        CFRunLoopAddTimer(CFRunLoopGetCurrent(), timer, kCFRunLoopCommonModes);
-
-        static PowerObserver* powerObserver;
-        powerObserver = PowerObserver::create().leakPtr();
-    });
-    return timer;
-};
+static PowerObserver* PowerObserver;
 
 void setSharedTimerFiredFunction(void (*f)())
@@ -181 +171 @@
 {
     ASSERT(sharedTimerFiredFunction);
+
+    if (sharedTimer) {
+        CFRunLoopTimerInvalidate(sharedTimer);
+        CFRelease(sharedTimer);
+    }
+
     CFAbsoluteTime fireDate = CFAbsoluteTimeGetCurrent() + interval;
-    CFRunLoopTimerSetNextFireDate(sharedTimer(), fireDate);
+    sharedTimer = CFRunLoopTimerCreate(0, fireDate, 0, 0, 0, timerFired, 0);
+    CFRunLoopAddTimer(CFRunLoopGetCurrent(), sharedTimer, kCFRunLoopCommonModes);
+    
+    if (!PowerObserver)
+        PowerObserver = PowerObserver::create().leakPtr();
 }
 
 void stopSharedTimer()
 {
-    CFRunLoopTimerSetNextFireDate(sharedTimer(), CFAbsoluteTimeGetCurrent() + distantFuture);
+    if (sharedTimer) {
+        CFRunLoopTimerInvalidate(sharedTimer);
+        CFRelease(sharedTimer);
+        sharedTimer = 0;
+    }
 }