Changeset 143033 in webkit

Timestamp:

Feb 15, 2013 12:45:54 PM (11 years ago)

Author:

zandobersek@gmail.com

Message:

webkit-patch suggest-reviewers should limit itself to 5 reviewers
​https://bugs.webkit.org/show_bug.cgi?id=107528

Reviewed by Eric Seidel.

• Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.suggested_reviewers): Iterate through the sorted commit info list,
scraping reviewers from the commit information and in the end producing a list
of reviewers that's sorted from the most to least recent activity of any reviewer
that has reviewed or authored patches for the changed files.

• Scripts/webkitpy/tool/commands/queries.py:

(SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
the same logic.
(SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
defaults to False.

• Scripts/webkitpy/tool/steps/suggestreviewers.py:

(SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
on a single line. Only ask for CC-ing the suggested reviewers to the bug if the
bug ID is located in the command's state.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/checkout/checkout.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/queries.py (modified) (2 diffs)
• Scripts/webkitpy/tool/steps/suggestreviewers.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-02-15  Zan Dobersek  <zdobersek@igalia.com>
+
+        webkit-patch suggest-reviewers should limit itself to 5 reviewers
+        https://bugs.webkit.org/show_bug.cgi?id=107528
+
+        Reviewed by Eric Seidel.
+
+        * Scripts/webkitpy/common/checkout/checkout.py:
+        (Checkout.suggested_reviewers): Iterate through the sorted commit info list,
+        scraping reviewers from the commit information and in the end producing a list
+        of reviewers that's sorted from the most to least recent activity of any reviewer
+        that has reviewed or authored patches for the changed files.
+        * Scripts/webkitpy/tool/commands/queries.py:
+        (SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
+        the same logic.
+        (SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
+        defaults to False.
+        * Scripts/webkitpy/tool/steps/suggestreviewers.py:
+        (SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
+        on a single line.  Only ask for CC-ing the suggested reviewers to the bug if the
+        bug ID is located in the command's state.
+
 2013-02-15  Pablo Flouret  <pablof@motorola.com>
 

trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py

@@ -136 +136 @@
     def suggested_reviewers(self, git_commit, changed_files=None):
         changed_files = self.modified_non_changelogs(git_commit, changed_files)
-        commit_infos = self.recent_commit_infos_for_files(changed_files)
-        reviewers = [commit_info.reviewer() for commit_info in commit_infos if commit_info.reviewer()]
-        reviewers.extend([commit_info.author() for commit_info in commit_infos if commit_info.author() and commit_info.author().can_review])
-        return sorted(set(reviewers))
+        commit_infos = sorted(self.recent_commit_infos_for_files(changed_files), key=lambda info: info.revision(), reverse=True)
+        reviewers = filter(lambda person: person and person.can_review, sum(map(lambda info: [info.reviewer(), info.author()], commit_infos), []))
+        unique_reviewers = reduce(lambda suggestions, reviewer: suggestions + [reviewer if reviewer not in suggestions else None], reviewers, [])
+        return filter(lambda reviewer: reviewer, unique_reviewers)
 
     def bug_id_for_this_commit(self, git_commit, changed_files=None):

trunk/Tools/Scripts/webkitpy/tool/commands/queries.py

@@ -45 +45 @@
 from webkitpy.common.system.crashlogs import CrashLogs
 from webkitpy.common.system.user import User
+from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
 from webkitpy.tool.grammar import pluralize
 from webkitpy.tool.multicommandtool import AbstractDeclarativeCommand
@@ -53 +54 @@
 
 
-class SuggestReviewers(AbstractDeclarativeCommand):
+class SuggestReviewers(AbstractSequencedCommand):
     name = "suggest-reviewers"
     help_text = "Suggest reviewers for a patch based on recent changes to the modified files."
-
-    def __init__(self):
-        options = [
-            steps.Options.git_commit,
-        ]
-        AbstractDeclarativeCommand.__init__(self, options=options)
-
-    def execute(self, options, args, tool):
-        reviewers = tool.checkout().suggested_reviewers(options.git_commit)
-        print "\n".join([reviewer.full_name for reviewer in reviewers])
+    steps = [
+        steps.SuggestReviewers,
+    ]
+
+    def _prepare_state(self, options, args, tool):
+        options.suggest_reviewers = True
 
 

trunk/Tools/Scripts/webkitpy/tool/steps/suggestreviewers.py

@@ -43 +43 @@
             return
 
-        reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit, self._changed_files(state))
+        reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit, self._changed_files(state))[:5]
         print "The following reviewers have recently modified files in your patch:"
-        print "\n".join([reviewer.full_name for reviewer in reviewers])
+        print ", ".join([reviewer.full_name for reviewer in reviewers])
+
+        if not state.get('bug_id'):
+            return
         if not self._tool.user.confirm("Would you like to CC them?"):
             return