Changeset 143101 in webkit


Ignore:
Timestamp:
Feb 16, 2013 4:45:57 AM (11 years ago)
Author:
senorblanco@chromium.org
Message:

[skia] FEOffset should have a Skia implementation.
https://bugs.webkit.org/show_bug.cgi?id=109831

Reviewed by James Robinson.

Source/WebCore:

Covered by css3/filters/effect-reference.html and -hw.html.

  • WebCore.gypi:
  • platform/graphics/filters/FEOffset.h: Implement createImageFilter()

for the Skia path.

  • platform/graphics/filters/skia/FEOffsetSkia.cpp: Added.

(WebCore::FEOffset::createImageFilter):
Instantiate an SkOffsetImageFilter when building the Skia DAG.

LayoutTests:

  • css3/filters/effect-reference-hw.html:
  • css3/filters/effect-reference.html:
  • platform/chromium/TestExpectations:
Location:
trunk
Files:
1 added
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r143100 r143101  
     12013-02-16  Stephen White  <senorblanco@chromium.org>
     2
     3        [skia] FEOffset should have a Skia implementation.
     4        https://bugs.webkit.org/show_bug.cgi?id=109831
     5
     6        Reviewed by James Robinson.
     7
     8        * css3/filters/effect-reference-hw.html:
     9        * css3/filters/effect-reference.html:
     10        * platform/chromium/TestExpectations:
     11
    1122013-02-16  Vsevolod Vlasov  <vsevik@chromium.org>
    213
  • trunk/LayoutTests/css3/filters/effect-reference-hw.html

    r133638 r143101  
    2929      <feBlend in2="SourceGraphic" mode="multiply"/>
    3030    </filter>
     31    <filter id="offset" x="0%">
     32      <feOffset dx="10" dy="10"/>
     33    </filter>
    3134  </defs>
    3235</svg>
     
    4447<img style="-webkit-filter: url(#blend); filter: url(#blend);" src="resources/reference.png">
    4548<img style="-webkit-filter: url(#lighting); filter: url(#lighting);" src="resources/reference.png">
     49<img style="-webkit-filter: url(#offset); filter: url(#offset);" src="resources/reference.png">
  • trunk/LayoutTests/css3/filters/effect-reference.html

    r133638 r143101  
    2929      <feBlend in2="SourceGraphic" mode="multiply"/>
    3030    </filter>
     31    <filter id="offset" x="0%">
     32      <feOffset dx="10" dy="10"/>
     33    </filter>
    3134  </defs>
    3235</svg>
     
    4346<img style="-webkit-filter: url(#blend); filter: url(#blend);" src="resources/reference.png">
    4447<img style="-webkit-filter: url(#lighting); filter: url(#lighting);" src="resources/reference.png">
     48<img style="-webkit-filter: url(#offset); filter: url(#offset);" src="resources/reference.png">
  • trunk/LayoutTests/platform/chromium/TestExpectations

    r143046 r143101  
    43464346webkit.org/b/108163 [ Debug ] platform/chromium/virtual/deferred/fast/images/icon-0colors.html [ Crash ]
    43474347
     4348# New test cases added to these tests will require rebaselines.
     4349webkit.org/b/109831 css3/filters/effect-reference.html
     4350webkit.org/b/109831 css3/filters/effect-reference-hw.html
     4351
    43484352# New clamping logic in the tile shader will causes slight diffs. These images must be rebaselined.
    43494353crbug.com/170722 [ Mac Win Linux ] compositing/color-matching/image-color-matching.html [ ImageOnlyFailure ]
  • trunk/Source/WebCore/ChangeLog

    r143100 r143101  
     12013-02-16  Stephen White  <senorblanco@chromium.org>
     2
     3        [skia] FEOffset should have a Skia implementation.
     4        https://bugs.webkit.org/show_bug.cgi?id=109831
     5
     6        Reviewed by James Robinson.
     7
     8        Covered by css3/filters/effect-reference.html and -hw.html.
     9
     10        * WebCore.gypi:
     11        * platform/graphics/filters/FEOffset.h:  Implement createImageFilter()
     12        for the Skia path.
     13        * platform/graphics/filters/skia/FEOffsetSkia.cpp: Added.
     14        (WebCore::FEOffset::createImageFilter):
     15        Instantiate an SkOffsetImageFilter when building the Skia DAG.
     16
    1172013-02-16  Vsevolod Vlasov  <vsevik@chromium.org>
    218
  • trunk/Source/WebCore/WebCore.gypi

    r143090 r143101  
    40334033            'platform/graphics/filters/skia/FEMorphologySkia.cpp',
    40344034            'platform/graphics/filters/skia/FELightingSkia.cpp',
     4035            'platform/graphics/filters/skia/FEOffsetSkia.cpp',
    40354036            'platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp',
    40364037            'platform/graphics/filters/skia/SkiaImageFilterBuilder.h',
  • trunk/Source/WebCore/platform/graphics/filters/FEOffset.h

    r97853 r143101  
    4646    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
    4747
     48#if USE(SKIA)
     49    virtual SkImageFilter* createImageFilter(SkiaImageFilterBuilder*);
     50#endif
     51
    4852private:
    4953    FEOffset(Filter*, float dx, float dy);
Note: See TracChangeset for help on using the changeset viewer.