Changeset 143227 in webkit

Timestamp:

Feb 18, 2013 8:54:19 AM (11 years ago)

Author:

pfeldman@chromium.org

Message:

Web Inspector: Disable hiding the debugger when it is below the source code
​https://bugs.webkit.org/show_bug.cgi?id=110106

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-02-18
Reviewed by Pavel Feldman.

When the "Split horizontally" option is checked in the Sources panel the button responsible for the sidebar
visibility is hidden and the sidebar is force-shown. Also set the "Split sidebar" option default to true.

No new tests.

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

• inspector/front-end/scriptsPanel.css:

(.split-view-horizontal #scripts-debug-sidebar-resizer-widget):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ScriptsPanel.js (modified) (3 diffs)
• inspector/front-end/scriptsPanel.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-18  Vladislav Kaznacheev  <kaznacheev@chromium.org>
+
+        Web Inspector: Disable hiding the debugger when it is below the source code
+        https://bugs.webkit.org/show_bug.cgi?id=110106
+
+        Reviewed by Pavel Feldman.
+
+        When the "Split horizontally" option is checked in the Sources panel the button responsible for the sidebar
+        visibility is hidden and the sidebar is force-shown. Also set the "Split sidebar" option default to true.
+
+        No new tests.
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel):
+        * inspector/front-end/scriptsPanel.css:
+        (.split-view-horizontal #scripts-debug-sidebar-resizer-widget):
+
 2013-02-18  Bear Travis  <betravis@adobe.com>
 

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -121 +121 @@
     }
 
-    WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._dockSideChanged.bind(this));
-    this._dockSideChanged();
-
     this.sidebarPanes.callstack.registerShortcuts(this.registerShortcuts.bind(this));
     this.registerShortcuts(WebInspector.ScriptsPanelDescriptor.ShortcutKeys.EvaluateSelectionInConsole, this._evaluateSelectionInConsole.bind(this));
@@ -152 +149 @@
 
     this._installDebuggerSidebarController();
+
+    WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._dockSideChanged.bind(this));
+    this._dockSideChanged();
 
     this._sourceFramesByUISourceCode = new Map();
@@ -1175 +1175 @@
             this.sidebarElement.appendChild(this.debugToolbar);
         } else {
+            this._showDebuggerSidebar();
+
             this.sidebarPaneView = new WebInspector.SplitView(true, this.name + "PanelSplitSidebarRatio", 0.5);
 

trunk/Source/WebCore/inspector/front-end/scriptsPanel.css

@@ -265 +265 @@
 }
 
+.split-view-horizontal button.status-bar-item.scripts-debugger-show-hide-button,
+.split-view-horizontal #scripts-debug-sidebar-resizer-widget {
+    display: none;
+}
+
 button.status-bar-item.scripts-debugger-show-hide-button:active {
     top: 1px;