Changeset 143361 in webkit

Timestamp:

Feb 19, 2013 11:10:45 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Remove unnecessary (and problematic) copy-constructor from LayoutUnit
​https://bugs.webkit.org/show_bug.cgi?id=110121

This copy constructor does what a default copy constructor would do, so
it's not necessary. Furthermore, this copy constructor is the only
reason why LayoutUnit becomes non-POD, and that triggers a gdb bug,
making it impossible to do things like "print location()" when inside
some RenderBlock, for instance.

Gdb bug ​http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported.

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-02-19
Reviewed by Benjamin Poulain.

No tests. Apart from dealing with buggy debuggers, this is just code cleanup.

• platform/LayoutUnit.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/LayoutUnit.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-19  Morten Stenshorne  <mstensho@opera.com>
+
+        Remove unnecessary (and problematic) copy-constructor from LayoutUnit
+        https://bugs.webkit.org/show_bug.cgi?id=110121
+
+        This copy constructor does what a default copy constructor would do, so
+        it's not necessary. Furthermore, this copy constructor is the only
+        reason why LayoutUnit becomes non-POD, and that triggers a gdb bug,
+        making it impossible to do things like "print location()" when inside
+        some RenderBlock, for instance.
+
+        Gdb bug http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported.
+
+        Reviewed by Benjamin Poulain.
+
+        No tests. Apart from dealing with buggy debuggers, this is just code cleanup.
+
+        * platform/LayoutUnit.h:
+
 2013-02-19  Emil A Eklund  <eae@chromium.org>
 

trunk/Source/WebCore/platform/LayoutUnit.h

@@ -117 +117 @@
     LayoutUnit(double value) { REPORT_OVERFLOW(isInBounds(value)); m_value = value; }
 #endif
-    LayoutUnit(const LayoutUnit& value) { m_value = value.rawValue(); }
 
     static LayoutUnit fromFloatCeil(float value)