Changeset 143382 in webkit

Timestamp:

Feb 19, 2013 2:02:47 PM (11 years ago)

Author:

pilgrim@chromium.org

Message:

[Chromium] Remove idbFactory from WebKitPlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Kentaro Hara.

Now that ​https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

• public/platform/WebKitPlatformSupport.h:

(WebKit):

• src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/platform/WebKitPlatformSupport.h (modified) (1 diff)
• src/IDBFactoryBackendProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-02-19  Mark Pilgrim  <pilgrim@chromium.org>
+
+        [Chromium] Remove idbFactory from WebKitPlatformSupport
+        https://bugs.webkit.org/show_bug.cgi?id=106457
+
+        Reviewed by Kentaro Hara.
+
+        Now that https://codereview.chromium.org/12230054 has landed, the
+        idbFactory method is no longer needed. (Embedders must now call
+        the new setIDBFactory method upon initialization.) Part of a
+        larger refactoring series; see tracking bug 82948.
+
+        * public/platform/WebKitPlatformSupport.h:
+        (WebKit):
+        * src/IDBFactoryBackendProxy.cpp:
+        (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
+
 2013-02-19  Alexandre Elias  <aelias@chromium.org>
 

trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h

@@ -36 +36 @@
 namespace WebKit {
 
-class WebIDBFactory; // FIXME: Does this belong in platform?
-
-// FIXME: Eventually all these API will need to move to WebKit::Platform.
 class WebKitPlatformSupport : public Platform {
-public:
-    // Indexed Database ----------------------------------------------------
-
-    virtual WebIDBFactory* idbFactory() { return 0; }
-
 protected:
     ~WebKitPlatformSupport() { }

trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp

@@ -54 +54 @@
 #include "WorkerScriptController.h"
 #include "WorkerThread.h"
-#include "platform/WebKitPlatformSupport.h"
 #include <public/WebVector.h>
 
@@ -76 +75 @@
 IDBFactoryBackendProxy::IDBFactoryBackendProxy()
 {
-    if (s_webIDBFactory)
-        m_webIDBFactory = s_webIDBFactory;
-    else
-        m_webIDBFactory = webKitPlatformSupport()->idbFactory();
+    ASSERT(s_webIDBFactory);
+    m_webIDBFactory = s_webIDBFactory;
 }