Changeset 143387 in webkit


Ignore:
Timestamp:
Feb 19, 2013 3:01:20 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
https://bugs.webkit.org/show_bug.cgi?id=110254

Patch by Kentaro Hara <haraken@google.com> on 2013-02-19
Reviewed by Adam Barth.

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951

Currently ScriptRunner::runCompiledScript() calls
ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
hitting the ASSERT(). The ASSERT() does not make sense at all.
Instead, we should return an empty handle when OOM occurs.

No tests. The bug happens only when OOM occurs.

  • bindings/v8/ScriptRunner.cpp:

(WebCore::ScriptRunner::runCompiledScript):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r143386 r143387  
     12013-02-19  Kentaro Hara  <haraken@google.com>
     2
     3        [V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
     4        https://bugs.webkit.org/show_bug.cgi?id=110254
     5
     6        Reviewed by Adam Barth.
     7
     8        Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951
     9
     10        Currently ScriptRunner::runCompiledScript() calls
     11        ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
     12        hitting the ASSERT(). The ASSERT() does not make sense at all.
     13        Instead, we should return an empty handle when OOM occurs.
     14
     15        No tests. The bug happens only when OOM occurs.
     16
     17        * bindings/v8/ScriptRunner.cpp:
     18        (WebCore::ScriptRunner::runCompiledScript):
     19
    1202013-02-19  Elliott Sprehn  <esprehn@chromium.org>
    221
  • trunk/Source/WebCore/bindings/v8/ScriptRunner.cpp

    r129026 r143387  
    4444
    4545    if (handleOutOfMemory())
    46         ASSERT(script.IsEmpty());
     46        return v8::Local<v8::Value>();
    4747
    4848    // Run the script and keep track of the current recursion depth.
Note: See TracChangeset for help on using the changeset viewer.